From c7ba7bd4ada7c5d35fbfdeb739e2e6e93f3f8010 Mon Sep 17 00:00:00 2001
From: kvan7 <kvan.valve@gmail.com>
Date: Sun, 3 May 2026 13:44:35 -0500
Subject: [PATCH] slightly safer tooltip?

---
 .../src/web/price-check/trade/TradeItem.vue   | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/renderer/src/web/price-check/trade/TradeItem.vue b/renderer/src/web/price-check/trade/TradeItem.vue
index 715025c7..d1c8e2f6 100644
--- a/renderer/src/web/price-check/trade/TradeItem.vue
+++ b/renderer/src/web/price-check/trade/TradeItem.vue
@@ -124,11 +124,12 @@
 
 <script lang="ts">
 import {
+  App,
   computed,
   createApp,
   defineComponent,
+  onBeforeUnmount,
   onMounted,
-  onUnmounted,
   PropType,
   ref,
 } from "vue";
@@ -187,6 +188,8 @@ export default defineComponent({
     const target = ref<HTMLElement>(null!);
     const { t } = useI18nNs("trade_result");
     let instance: Instance;
+    let tooltipApp: App<Element> | undefined;
+
     // Shift Key Detection
     const isShiftPressed = ref(false);
     const isCtrlPressed = ref(false);
@@ -233,26 +236,28 @@ export default defineComponent({
         delay: [0, 0],
         animation: false,
         maxWidth: "none",
-        onShow() {
-          const app = createApp(TooltipItem, {
+        onMount() {
+          tooltipApp = createApp(TooltipItem, {
             result: props.result,
           });
           const tooltipContainer = document.createElement("div");
-          app.mount(tooltipContainer);
+          tooltipApp.mount(tooltipContainer);
           instance.setContent(tooltipContainer);
         },
+        onDestroy() {
+          tooltipApp?.unmount();
+        },
       });
       if (tooltipOption.value === "keybind") {
         instance.disable();
       }
     });
 
-    onUnmounted(() => {
+    onBeforeUnmount(() => {
       window.removeEventListener("keydown", handleKeyDown);
       window.removeEventListener("keyup", handleKeyUp);
 
-      // tippy stuff
-      instance.destroy();
+      instance?.destroy();
     });
     return {
       t,