From 38700aed95d4c54ddeb523df2f5eefc7b7fcc4cf Mon Sep 17 00:00:00 2001 From: jamesread Date: Tue, 21 Jul 2026 15:47:29 +0100 Subject: [PATCH] fix: windows signing signpath upload --- .github/workflows/build-and-release.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-and-release.yml b/.github/workflows/build-and-release.yml index 61225203..d465ebda 100644 --- a/.github/workflows/build-and-release.yml +++ b/.github/workflows/build-and-release.yml @@ -156,8 +156,10 @@ jobs: if: steps.release.outputs.new_release_published == 'true' uses: actions/upload-artifact@v7 with: - name: unsigned-windows-zip + # Upload as-is so SignPath receives OliveTin-windows-amd64.zip, not a wrapper zip. + # With archive: false, the artifact name is the filename (`name` is ignored). path: dist/OliveTin-windows-amd64.zip + archive: false if-no-files-found: error - name: Upload unsigned Windows MSI for SignPath @@ -165,8 +167,8 @@ jobs: if: steps.release.outputs.new_release_published == 'true' uses: actions/upload-artifact@v7 with: - name: unsigned-windows-msi path: dist/OliveTin-windows-amd64.msi + archive: false if-no-files-found: error - name: Archive binaries @@ -219,6 +221,8 @@ jobs: artifact-configuration-slug: windows-zip github-artifact-id: ${{ needs.build.outputs.windows_zip_artifact_id }} wait-for-completion: true + # Preserve the signed .zip/.msi files; default decompress would unpack the zip. + skip-decompress: true output-artifact-directory: signed-windows-zip - name: Sign Windows MSI @@ -231,6 +235,7 @@ jobs: artifact-configuration-slug: windows-msi github-artifact-id: ${{ needs.build.outputs.windows_msi_artifact_id }} wait-for-completion: true + skip-decompress: true output-artifact-directory: signed-windows-msi - name: Publish signed Windows assets and undraft release