package executor import ( config "github.com/OliveTin/OliveTin/internal/config" log "github.com/sirupsen/logrus" "errors" "net/url" "regexp" "strings" ) var ( typecheckRegex = map[string]string{ "very_dangerous_raw_string": "", "int": "^[\\d]+$", "ascii": "^[a-zA-Z0-9]+$", "ascii_identifier": "^[a-zA-Z0-9\\-\\.\\_]+$", "ascii_sentence": "^[a-zA-Z0-9 \\,\\.]+$", } ) func parseActionArguments(rawShellCommand string, values map[string]string, action *config.Action) (string, error) { log.WithFields(log.Fields{ "cmd": rawShellCommand, }).Infof("Before Parse Args") r := regexp.MustCompile("{{ *?([a-zA-Z0-9_]+?) *?}}") matches := r.FindAllStringSubmatch(rawShellCommand, -1) for _, match := range matches { argValue, argProvided := values[match[1]] if !argProvided { log.Infof("%v", values) return "", errors.New("Required arg not provided: " + match[1]) } err := typecheckActionArgument(match[1], argValue, action) if err != nil { return "", err } log.WithFields(log.Fields{ "name": match[1], "value": argValue, }).Debugf("Arg assigned") rawShellCommand = strings.ReplaceAll(rawShellCommand, match[0], argValue) } log.WithFields(log.Fields{ "cmd": rawShellCommand, }).Infof("After Parse Args") return rawShellCommand, nil } func typecheckActionArgument(name string, value string, action *config.Action) error { arg := action.FindArg(name) if arg == nil { return errors.New("Action arg not defined: " + name) } if len(arg.Choices) > 0 { return typecheckChoice(value, arg) } return TypeSafetyCheck(name, value, arg.Type) } func typecheckChoice(value string, arg *config.ActionArgument) error { for _, choice := range arg.Choices { if value == choice.Value { return nil } } return errors.New("argument value is not one of the predefined choices") } // TypeSafetyCheck checks argument values match a specific type. The types are // defined in typecheckRegex, and, you guessed it, uses regex to check for allowed // characters. func TypeSafetyCheck(name string, value string, argumentType string) error { if argumentType == "url" { return typeSafetyCheckUrl(name, value) } return typeSafetyCheckRegex(name, value, argumentType) } func typeSafetyCheckRegex(name string, value string, argumentType string) error { pattern, found := typecheckRegex[argumentType] if !found { return errors.New("argument type not implemented " + argumentType) } matches, _ := regexp.MatchString(pattern, value) if !matches { log.WithFields(log.Fields{ "name": name, "value": value, "type": argumentType, }).Warn("Arg type check safety failure") return errors.New("invalid argument, doesn't match " + argumentType) } return nil } func typeSafetyCheckUrl(name string, value string) error { _, err := url.ParseRequestURI(value) return err }