diff --git a/services/supabase/SETUP.md b/services/supabase/SETUP.md index 6b784bb9..36a4b3be 100644 --- a/services/supabase/SETUP.md +++ b/services/supabase/SETUP.md @@ -42,7 +42,7 @@ The local desktop app already referenced this Supabase project before setup. Its 2. Test app-initiated email signup/sign-in and Google login end to end. The local UI uses magic links for both signup and sign-in. Verify Azure and GitHub provider configuration before enabling those sign-in options for release. Email templates are saved live; the app changes are not released. 3. Decide the production fallback URL. The UI requires a Supabase session and offers Google, Microsoft, GitHub, and email magic links. There is no local demo or guest login. 4. Verify a real desktop feedback submission. Add cleanup for interrupted uploads and old quota rows through the appropriate server-side APIs. -5. Cloud recording ownership, five-slot quotas, byte limits, cleanup code, and management UI are implemented locally; the private staging schema is migrated. Complete real-account and protected staging tests before deployment. See `../recordly-share/worker/STAGING.md`. +5. Cloud recording ownership, five-slot quotas, byte limits, cleanup, and management UI are deployed to staging. A real desktop upload/playback/delete test passed; large multipart uploads, another-account isolation, and packaged callbacks still need live verification. See `../recordly-share/worker/STAGING.md`. 6. Configure payments after these foundations and the planned frontend changes. -Only three approved email DNS records under `auth.recordly.dev` were added. Framer hosting, root/www DNS, marketplace, media, Google provider credentials, and payment settings are unchanged. Cloudflare's recording Worker remains undeployed. +Only three approved email DNS records under `auth.recordly.dev` were added. Framer hosting, root/www DNS, marketplace, media, Google provider credentials, and payment settings are unchanged. The isolated Cloudflare recording Worker is deployed to staging; production deployment remains separate. diff --git a/tests/ui/account-settings.spec.ts b/tests/ui/account-settings.spec.ts index ddc9fcea..195542f9 100644 --- a/tests/ui/account-settings.spec.ts +++ b/tests/ui/account-settings.spec.ts @@ -13,19 +13,23 @@ test("account settings save the Supabase profile and share it with the dashboard await installDesktopBridge(page); await page.goto("/?windowType=editor"); let account = await openAccountSettings(page); - await expect(account.getByLabel("Display name", { exact: true })).toHaveValue("Test User"); + await expect(account.getByRole("textbox", { name: /^Display name\*?$/ })).toHaveValue( + "Test User", + ); await expect(account.getByRole("list", { name: "Connected sign-in methods" })).toHaveText( "Email magic link", ); await expect(account.getByRole("button", { name: "Save profile" })).toBeDisabled(); - await account.getByLabel("Display name", { exact: true }).fill(" Jordan Chen "); + await account.getByRole("textbox", { name: /^Display name\*?$/ }).fill(" Jordan Chen "); const update = page.waitForRequest( (request) => request.method() === "PUT" && request.url().includes("/auth/v1/user"), ); await account.getByRole("button", { name: "Save profile" }).click(); expect((await update).postDataJSON().data).toEqual({ full_name: "Jordan Chen" }); await expect(account.getByRole("status")).toHaveText("Profile saved."); - await expect(account.getByLabel("Display name", { exact: true })).toHaveValue("Jordan Chen"); + await expect(account.getByRole("textbox", { name: /^Display name\*?$/ })).toHaveValue( + "Jordan Chen", + ); await expect( page .getByRole("button", { name: "Recordly account", exact: true }) @@ -33,12 +37,16 @@ test("account settings save the Supabase profile and share it with the dashboard ).toBeVisible(); await page.reload(); account = await openAccountSettings(page); - await expect(account.getByLabel("Display name", { exact: true })).toHaveValue("Jordan Chen"); + await expect(account.getByRole("textbox", { name: /^Display name\*?$/ })).toHaveValue( + "Jordan Chen", + ); await page.getByRole("button", { name: "Home", exact: true }).click(); const dashboard = page.getByRole("dialog", { name: "Projects dashboard", exact: true }); await dashboard.getByRole("button", { name: "Settings", exact: true }).click(); await dashboard.getByRole("row", { name: "Account", exact: true }).click(); - await expect(dashboard.getByLabel("Display name", { exact: true })).toHaveValue("Jordan Chen"); + await expect(dashboard.getByRole("textbox", { name: /^Display name\*?$/ })).toHaveValue( + "Jordan Chen", + ); await page.screenshot({ path: "test-results/dashboard-account-settings.png", animations: "disabled", @@ -53,9 +61,9 @@ test("email changes use a PKCE confirmation and retain the current email until c const account = await openAccountSettings(page); const change = account.getByRole("button", { name: "Change email", exact: true }); await expect(change).toBeDisabled(); - await account.getByLabel("Email address", { exact: true }).fill("invalid@example"); + await account.getByRole("textbox", { name: /^Email address\*?$/ }).fill("invalid@example"); await expect(change).toBeDisabled(); - await account.getByLabel("Email address", { exact: true }).fill("new@example.com"); + await account.getByRole("textbox", { name: /^Email address\*?$/ }).fill("new@example.com"); const update = page.waitForRequest( (request) => request.method() === "PUT" && request.url().includes("/auth/v1/user"), ); @@ -77,7 +85,7 @@ test("email changes use a PKCE confirmation and retain the current email until c await expect(change).toBeDisabled(); await page.reload(); const restored = await openAccountSettings(page); - await expect(restored.getByLabel("Email address", { exact: true })).toHaveValue( + await expect(restored.getByRole("textbox", { name: /^Email address\*?$/ })).toHaveValue( "test@email.com", ); await expect(restored.getByText("Awaiting confirmation: new@example.com")).toBeVisible(); @@ -96,12 +104,14 @@ test("account update errors preserve the session and allow retry", async ({ page }); await page.goto("/?windowType=editor"); const account = await openAccountSettings(page); - await account.getByLabel("Display name", { exact: true }).fill("New Name"); + await account.getByRole("textbox", { name: /^Display name\*?$/ }).fill("New Name"); await account.getByRole("button", { name: "Save profile" }).click(); await expect(account.getByRole("alert")).toHaveText( "Please wait before updating your profile.", ); - await expect(account.getByLabel("Display name", { exact: true })).toHaveValue("New Name"); + await expect(account.getByRole("textbox", { name: /^Display name\*?$/ })).toHaveValue( + "New Name", + ); await account.getByRole("button", { name: "Save profile" }).click(); await expect(account.getByRole("status")).toHaveText("Profile saved."); await expect(account.getByRole("alert")).toHaveCount(0); diff --git a/tests/ui/hud-layout.spec.ts b/tests/ui/hud-layout.spec.ts index 40e24754..df27d1e5 100644 --- a/tests/ui/hud-layout.spec.ts +++ b/tests/ui/hud-layout.spec.ts @@ -17,11 +17,14 @@ test("HUD dividers are vertically centered", async ({ page }) => { const home = page.getByRole("button", { name: "Home", exact: true }); await expect(home.locator("svg")).toHaveAttribute("data-icon-style", "bold"); await expect(page.getByRole("button", { name: "More", exact: true })).toHaveCount(0); - const icon = await home.locator("svg").evaluate((element) => ({ - width: element.getBoundingClientRect().width, - height: element.getBoundingClientRect().height, - })); - expect(icon).toEqual({ width: 20, height: 20 }); + await expect + .poll(() => + home.locator("svg").evaluate((element) => ({ + width: Math.round(element.getBoundingClientRect().width), + height: Math.round(element.getBoundingClientRect().height), + })), + ) + .toEqual({ width: 20, height: 20 }); await page.screenshot({ path: "test-results/hud-idle.png", animations: "disabled" }); await home.click(); await expect(page.locator("html")).toHaveAttribute("data-dashboard-opened", "true"); diff --git a/tests/ui/login.spec.ts b/tests/ui/login.spec.ts index 97f9b3b4..b8a40865 100644 --- a/tests/ui/login.spec.ts +++ b/tests/ui/login.spec.ts @@ -21,7 +21,7 @@ test("sign-in offers only providers enabled in Supabase", async ({ page }) => { await expect( login.getByRole("button", { name: "Continue with GitHub", exact: true }), ).toHaveCount(0); - const email = login.getByLabel("Email", { exact: true }); + const email = login.getByRole("textbox", { name: /^Email\*?$/ }); const magicLink = login.getByRole("button", { name: "Email me a magic link" }); await expect(magicLink).toHaveCount(0); await email.fill("owner@example"); @@ -52,7 +52,7 @@ test("email sign-in reports Supabase errors and allows retry without granting ac }); await page.goto("/?windowType=editor"); const login = page.getByRole("dialog", { name: "Welcome to Recordly" }); - await login.getByLabel("Email", { exact: true }).fill("owner@example.test"); + await login.getByRole("textbox", { name: /^Email\*?$/ }).fill("owner@example.test"); await login.getByRole("button", { name: "Email me a magic link" }).click(); await expect(login.getByText("Please wait before requesting another email.")).toBeVisible(); await expect(login).toHaveAttribute("data-onboarding-state", "login"); @@ -72,7 +72,7 @@ test("a rejected Supabase callback keeps sign-in mandatory", async ({ page }) => ); await page.goto("/?windowType=editor"); const login = page.getByRole("dialog", { name: "Welcome to Recordly" }); - await login.getByLabel("Email", { exact: true }).fill("owner@example.test"); + await login.getByRole("textbox", { name: /^Email\*?$/ }).fill("owner@example.test"); await login.getByRole("button", { name: "Email me a magic link" }).click(); await expect(login.getByText(/Check your inbox/)).toBeVisible(); await completeSupabaseSignIn(page); @@ -139,7 +139,7 @@ test("sign-in banner fills spare space and keeps the email action usable in a sh const banner = login.locator("[data-onboarding-artwork]"); const submit = login.getByRole("button", { name: "Email me a magic link" }); const pages = login.getByRole("navigation", { name: "Onboarding pages" }); - await login.getByLabel("Email", { exact: true }).fill("owner@example.test"); + await login.getByRole("textbox", { name: /^Email\*?$/ }).fill("owner@example.test"); await expect(submit).toBeVisible(); const tallBanner = (await banner.boundingBox())!; expect(tallBanner.height).toBeGreaterThan(128); @@ -153,7 +153,7 @@ test("sign-in banner fills spare space and keeps the email action usable in a sh await page.setViewportSize({ width: 390, height: 600 }); await expect(banner).toBeInViewport(); expect((await banner.boundingBox())!.height).toBeLessThan(tallBanner.height); - await login.getByLabel("Email", { exact: true }).fill("owner@example.test"); + await login.getByRole("textbox", { name: /^Email\*?$/ }).fill("owner@example.test"); await expect(login.getByLabel("Password", { exact: true })).toHaveCount(0); await expect(login.getByRole("navigation", { name: "Onboarding pages" })).toBeInViewport(); await submit.scrollIntoViewIfNeeded();