From 75835362a3536706ea41257ccdc9af13fd4af41b Mon Sep 17 00:00:00 2001 From: webadderall <131426131+webadderall@users.noreply.github.com> Date: Mon, 16 Mar 2026 22:06:30 +1100 Subject: [PATCH] fix(ci): unblock release builds on Windows/Linux/macOS - Rename invalid .github instructions filename for Windows checkout compatibility - Remove unused i18n symbols causing TypeScript/lint build failures --- .github/instructions/general.instructions.md | 1 + src/components/video-editor/VideoEditor.tsx | 2 +- src/components/video-editor/timeline/Item.tsx | 2 -- src/components/video-editor/timeline/TimelineEditor.tsx | 1 - 4 files changed, 2 insertions(+), 4 deletions(-) create mode 100644 .github/instructions/general.instructions.md diff --git a/.github/instructions/general.instructions.md b/.github/instructions/general.instructions.md new file mode 100644 index 00000000..79eba3df --- /dev/null +++ b/.github/instructions/general.instructions.md @@ -0,0 +1 @@ +Review this PR. Do not leave line comments. Provide exactly one summary comment including: 1. A letter grade (A-F), 2. Major shortcomings blocking merge 3. Nice-to-have shortcomings 4. Merge readiness (Yes/No). \ No newline at end of file diff --git a/src/components/video-editor/VideoEditor.tsx b/src/components/video-editor/VideoEditor.tsx index e61af90d..34bec02c 100644 --- a/src/components/video-editor/VideoEditor.tsx +++ b/src/components/video-editor/VideoEditor.tsx @@ -4,7 +4,7 @@ import { useCallback, useEffect, useMemo, useRef, useState } from "react"; import { Panel, PanelGroup, PanelResizeHandle } from "react-resizable-panels"; import { toast } from "sonner"; import { Toaster } from "@/components/ui/sonner"; -import { useI18n, useScopedT } from "@/contexts/I18nContext"; +import { useI18n } from "@/contexts/I18nContext"; import { useShortcuts } from "@/contexts/ShortcutsContext"; import { SUPPORTED_LOCALES } from "@/i18n/config"; import type { AppLocale } from "@/i18n/config"; diff --git a/src/components/video-editor/timeline/Item.tsx b/src/components/video-editor/timeline/Item.tsx index b68f2127..50670f4c 100644 --- a/src/components/video-editor/timeline/Item.tsx +++ b/src/components/video-editor/timeline/Item.tsx @@ -2,7 +2,6 @@ import type { Span } from "dnd-timeline"; import { useItem } from "dnd-timeline"; import { Gauge, MessageSquare, Music, Scissors, ZoomIn } from "lucide-react"; import { useMemo } from "react"; -import { useScopedT } from "@/contexts/I18nContext"; import { cn } from "@/lib/utils"; import glassStyles from "./ItemGlass.module.css"; @@ -49,7 +48,6 @@ export default function Item({ variant = "zoom", children, }: ItemProps) { - const t = useScopedT("timeline"); const { setNodeRef, attributes, listeners, itemStyle, itemContentStyle } = useItem({ id, span, diff --git a/src/components/video-editor/timeline/TimelineEditor.tsx b/src/components/video-editor/timeline/TimelineEditor.tsx index 66a397e6..27d02dce 100644 --- a/src/components/video-editor/timeline/TimelineEditor.tsx +++ b/src/components/video-editor/timeline/TimelineEditor.tsx @@ -11,7 +11,6 @@ import { Plus, Scissors, ZoomIn, MessageSquare, ChevronDown, Check, Gauge, WandS import { toast } from "sonner"; import { cn } from "@/lib/utils"; import { v4 as uuidv4 } from 'uuid'; -import { useScopedT } from "@/contexts/I18nContext"; import { useShortcuts } from "@/contexts/ShortcutsContext"; import { matchesShortcut } from "@/lib/shortcuts"; import { ASPECT_RATIOS, type AspectRatio, getAspectRatioLabel, isCustomAspectRatio } from "@/utils/aspectRatioUtils";