From bf3a36e621602c939a1200a7ea7ed6bc9ae8cce9 Mon Sep 17 00:00:00 2001
From: webadderall <131426131+webadderall@users.noreply.github.com>
Date: Sun, 29 Mar 2026 00:30:16 +1100
Subject: [PATCH] fix(release): align asset names and upload globs

---
 .github/workflows/release.yml | 37 +++++++++++++++++++++++------------
 electron-builder.json5        |  6 +++---
 2 files changed, 27 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 91a6d3c1..d38cfdc1 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -475,20 +475,31 @@ jobs:
         shell: bash
         run: |
           set -euo pipefail
+          shopt -s nullglob
+
+          assets=(
+            release-assets/macos-x64/*.dmg
+            release-assets/macos-x64/*.zip
+            release-assets/macos-x64/*.blockmap
+            release-assets/macos-arm64/*.dmg
+            release-assets/macos-arm64/*.zip
+            release-assets/macos-arm64/*.blockmap
+            release-assets/macos-merged/latest-mac.yml
+            release-assets/windows-x64/*.exe
+            release-assets/windows-x64/*.blockmap
+            release-assets/windows-x64/latest*.yml
+            release-assets/linux-x64/*.AppImage
+            release-assets/linux-x64/*.blockmap
+            release-assets/linux-x64/latest-linux.yml
+          )
+
+          if [ ${#assets[@]} -eq 0 ]; then
+            echo "No release assets found to upload."
+            exit 1
+          fi
+
           gh release upload "${{ needs.prepare-release.outputs.tag_name }}" \
-            release-assets/macos-x64/*.dmg \
-            release-assets/macos-x64/*.zip \
-            release-assets/macos-x64/*.blockmap \
-            release-assets/macos-arm64/*.dmg \
-            release-assets/macos-arm64/*.zip \
-            release-assets/macos-arm64/*.blockmap \
-            release-assets/macos-merged/latest-mac.yml \
-            release-assets/windows-x64/*.exe \
-            release-assets/windows-x64/*.blockmap \
-            release-assets/windows-x64/latest*.yml \
-            release-assets/linux-x64/*.AppImage \
-            release-assets/linux-x64/*.blockmap \
-            release-assets/linux-x64/latest-linux.yml \
+            "${assets[@]}" \
             --repo "${{ github.repository }}" \
             --clobber
         env:
diff --git a/electron-builder.json5 b/electron-builder.json5
index b66ada09..25c33118 100644
--- a/electron-builder.json5
+++ b/electron-builder.json5
@@ -58,7 +58,7 @@
       }
     ],
     "icon": "icons/icons/mac/icon.icns",
-    "artifactName": "${productName}-${version}-${arch}.${ext}",
+    "artifactName": "${productName}-${arch}.${ext}",
     "extendInfo": {
       "NSAudioCaptureUsageDescription": "Recordly needs audio capture permission to record system audio.",
       "NSMicrophoneUsageDescription": "Recordly needs microphone access to record voice audio.",
@@ -71,7 +71,7 @@
       "AppImage"
     ],
     "icon": "icons/icons/png",
-    "artifactName": "${productName}-${version}-${arch}.${ext}",
+    "artifactName": "${productName}-linux-${arch}.${ext}",
     "category": "AudioVideo"
   },
   "win": {
@@ -81,7 +81,7 @@
     "icon": "icons/icons/win/icon.ico"
     ,
     "executableName": "Recordly",
-    "artifactName": "${productName}-Setup-${version}-${arch}.${ext}"
+    "artifactName": "${productName}-windows-${arch}.${ext}"
   }
 }