lee/Recordly
1
0
Fork 0
mirror of https://github.com/webadderallorg/Recordly.git synced 2026-09-25 15:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Restore motion blur behavior and bake stronger defaults"

Browse Source 
This reverts commit 869e63e237.
This commit is contained in:
webadderall
2026-05-11 21:08:54 +10:00
parent 869e63e237
commit dbc4962fe8
7 changed files with 11 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/video-editor/SettingsPanel.tsx
+2 -2
View File
@@ -2734,7 +2734,7 @@ export function SettingsPanel({
.maxDirectionalBlurPx
}
min={0}
max={64}
max={32}
step={0.1}
onChange={(value) =>
onZoomMotionBlurTuningChange?.({
@@ -2778,7 +2778,7 @@ export function SettingsPanel({
.maxRadialBlurStrength
}
min={0}
max={1}
max={0.5}
step={0.005}
onChange={(value) =>
onZoomMotionBlurTuningChange?.({
src/components/video-editor/VideoEditor.tsx
+1 -2
View File
@@ -4361,8 +4361,7 @@ export default function VideoEditor() {
? (smokeExportConfig.fps ?? settings.mp4FrameRate ?? mp4FrameRate)
: (settings.mp4FrameRate ?? mp4FrameRate);
const pipelineModel = smokeExportConfig.enabled
? (smokeExportConfig.pipelineModel ??
(smokeExportConfig.useNativeExport ? "modern" : "legacy"))
? (smokeExportConfig.pipelineModel ?? "modern")
: (settings.pipelineModel ?? exportPipelineModel);
const useExperimentalNativeExport =
pipelineModel === "modern" &&
src/components/video-editor/editorPreferences.test.ts
+2 -11
View File
@@ -75,17 +75,8 @@ describe("editorPreferences", () => {
expect(DEFAULT_EDITOR_PREFERENCES.cursorSway).toBe(0.25);
});
it("bakes in the stronger split motion blur tuning defaults", () => {
expect(DEFAULT_EDITOR_PREFERENCES.zoomMotionBlurTuning).toMatchObject({
panVelocityThreshold: 0,
zoomVelocityThreshold: 0,
maxDirectionalBlurPx: 48.2,
maxRadialBlurStrength: 0.755,
});
});
it("defaults MP4 exports to the legacy pipeline", () => {
expect(DEFAULT_EDITOR_PREFERENCES.exportPipelineModel).toBe("legacy");
it("defaults MP4 exports to the Lightning pipeline", () => {
expect(DEFAULT_EDITOR_PREFERENCES.exportPipelineModel).toBe("modern");
});
it("loads stored editor control preferences", () => {
src/components/video-editor/projectPersistence.ts
+3 -3
View File
@@ -177,7 +177,7 @@ export function normalizeExportPipelineModel(value: unknown): ExportPipelineMode
return value;
}
return "legacy";
return "modern";
}
export function normalizeExportMp4FrameRate(value: unknown): ExportMp4FrameRate {
@@ -360,10 +360,10 @@ export function normalizeProjectEditor(editor: Partial<ProjectEditorState>): Pro
? clamp(rawZoomMotionBlurTuning.zoomVelocityThreshold, 0, 0.4)
: DEFAULT_ZOOM_MOTION_BLUR_TUNING.zoomVelocityThreshold,
maxDirectionalBlurPx: isFiniteNumber(rawZoomMotionBlurTuning.maxDirectionalBlurPx)
? clamp(rawZoomMotionBlurTuning.maxDirectionalBlurPx, 0, 64)
? clamp(rawZoomMotionBlurTuning.maxDirectionalBlurPx, 0, 32)
: DEFAULT_ZOOM_MOTION_BLUR_TUNING.maxDirectionalBlurPx,
maxRadialBlurStrength: isFiniteNumber(rawZoomMotionBlurTuning.maxRadialBlurStrength)
? clamp(rawZoomMotionBlurTuning.maxRadialBlurStrength, 0, 1)
? clamp(rawZoomMotionBlurTuning.maxRadialBlurStrength, 0, 0.5)
: DEFAULT_ZOOM_MOTION_BLUR_TUNING.maxRadialBlurStrength,
panResponsePerSecond: isFiniteNumber(rawZoomMotionBlurTuning.panResponsePerSecond)
? clamp(rawZoomMotionBlurTuning.panResponsePerSecond, 1, 30)
src/components/video-editor/types.ts
+3 -3
View File
@@ -116,9 +116,9 @@ export interface ZoomMotionBlurTuning {
export const DEFAULT_ZOOM_MOTION_BLUR_TUNING: ZoomMotionBlurTuning = {
panVelocityThreshold: 0,
zoomVelocityThreshold: 0,
maxDirectionalBlurPx: 48.2,
maxRadialBlurStrength: 0.755,
zoomVelocityThreshold: 0.025,
maxDirectionalBlurPx: 11,
maxRadialBlurStrength: 0.175,
panResponsePerSecond: 11,
zoomResponsePerSecond: 9,
zoomSafeZoneRadiusPx: 6,
src/lib/exporter/modernVideoExporter.nativeStaticLayout.test.ts
-23
View File
@@ -308,29 +308,6 @@ describe("ModernVideoExporter native static-layout eligibility", () => {
).toBe("unsupported-background-video");
});
it("skips native static-layout when motion blur is enabled", () => {
const exporter = createExporter({
zoomMotionBlur: 0.8,
zoomTemporalMotionBlur: 0.6,
cursorMotionBlur: 0.4,
});
expect(
exporter.getNativeStaticLayoutSkipReasons(
{
audioMode: "edited-track",
strategy: "offline-render-fallback",
},
videoInfo,
59,
),
).toEqual([
"unsupported-zoom-motion-blur",
"unsupported-zoom-temporal-motion-blur",
"unsupported-cursor-motion-blur",
]);
});
it("collects every native static-layout blocker for beta diagnostics", () => {
const exporter = createExporter({
width: 1921,
src/lib/exporter/modernVideoExporter.ts
-12
View File
@@ -1409,18 +1409,6 @@ export class ModernVideoExporter {
reasons.push("unsupported-background-video");
}
if ((this.config.zoomMotionBlur ?? 0) > 0) {
reasons.push("unsupported-zoom-motion-blur");
}
if ((this.config.zoomTemporalMotionBlur ?? 0) > 0) {
reasons.push("unsupported-zoom-temporal-motion-blur");
}
if ((this.config.cursorMotionBlur ?? 0) > 0) {
reasons.push("unsupported-cursor-motion-blur");
}
const hasZoomRegions = (this.config.zoomRegions ?? []).length > 0;
const needsTimelineMap = this.shouldUseNativeStaticLayoutTimelineMap(
videoInfo,