mirror of
https://github.com/webadderallorg/Recordly.git
synced 2026-09-25 23:35:43 +00:00
Address CodeRabbit review feedback
This commit is contained in:
@@ -1477,8 +1477,15 @@ export function LaunchWindow() {
|
||||
<DropdownItem
|
||||
icon={<RefreshCw size={16} />}
|
||||
onClick={() => {
|
||||
void window.electronAPI.previewUpdateToast();
|
||||
setActiveDropdown("none");
|
||||
void window.electronAPI
|
||||
.previewUpdateToast()
|
||||
.catch((error) => {
|
||||
console.warn(
|
||||
"Failed to preview update toast:",
|
||||
error,
|
||||
);
|
||||
});
|
||||
}}
|
||||
>
|
||||
{t("recording.previewUpdateUi", "Preview Update UI")}
|
||||
|
||||
@@ -157,6 +157,7 @@ function WallpaperVideoPreview({ src }: { src: string }) {
|
||||
|
||||
useEffect(() => {
|
||||
let cancelled = false;
|
||||
setResolvedSrc(src);
|
||||
|
||||
void (async () => {
|
||||
try {
|
||||
|
||||
@@ -1012,11 +1012,12 @@ const VideoPlayback = forwardRef<VideoPlaybackRef, VideoPlaybackProps>(
|
||||
const bgVideo = bgVideoRef.current;
|
||||
if (!bgVideo) return;
|
||||
|
||||
const clipTimelineTime = currentTime;
|
||||
const videoDuration =
|
||||
Number.isFinite(bgVideo.duration) && bgVideo.duration > 0 ? bgVideo.duration : null;
|
||||
const targetTime = videoDuration
|
||||
? currentTime % videoDuration
|
||||
: clampMediaTimeToDuration(currentTime, videoDuration);
|
||||
? clipTimelineTime % videoDuration
|
||||
: clampMediaTimeToDuration(clipTimelineTime, videoDuration);
|
||||
|
||||
const activeSpeedRegion = speedRegionsRef.current.find(
|
||||
(region) => currentTime * 1000 >= region.startMs && currentTime * 1000 < region.endMs,
|
||||
@@ -1036,7 +1037,8 @@ const VideoPlayback = forwardRef<VideoPlaybackRef, VideoPlaybackProps>(
|
||||
|
||||
const previousTimelineTime = lastBackgroundSyncTimeRef.current;
|
||||
const timelineJumped =
|
||||
previousTimelineTime === null || Math.abs(targetTime - previousTimelineTime) > 0.25;
|
||||
previousTimelineTime === null ||
|
||||
Math.abs(clipTimelineTime - previousTimelineTime) > 0.25;
|
||||
const driftThreshold = isPlaying ? 0.35 : 0.01;
|
||||
if (timelineJumped || Math.abs(bgVideo.currentTime - targetTime) > driftThreshold) {
|
||||
try {
|
||||
@@ -1055,7 +1057,7 @@ const VideoPlayback = forwardRef<VideoPlaybackRef, VideoPlaybackProps>(
|
||||
bgVideo.pause();
|
||||
}
|
||||
|
||||
lastBackgroundSyncTimeRef.current = targetTime;
|
||||
lastBackgroundSyncTimeRef.current = clipTimelineTime;
|
||||
}, [currentTime, isPlaying]);
|
||||
|
||||
useEffect(() => {
|
||||
|
||||
Reference in New Issue
Block a user