From aaa8eb773f035ae38fafc7fbb33b901ea72bb642 Mon Sep 17 00:00:00 2001 From: henrygd Date: Wed, 29 Apr 2026 18:05:40 -0400 Subject: [PATCH] updates --- agent/probe.go | 3 +-- agent/probe_ping_test.go | 9 ++++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/agent/probe.go b/agent/probe.go index 32b0084a..5c052910 100644 --- a/agent/probe.go +++ b/agent/probe.go @@ -17,7 +17,6 @@ import ( "github.com/henrygd/beszel/internal/entities/probe" ) -// Probe functionality overview: // Probes run at user-defined intervals (e.g., every 10s). // To keep memory usage low and constant, data is stored in two layers: // 1. Raw samples: The most recent individual results (kept for probeRawRetention). @@ -25,7 +24,7 @@ import ( // wall-clock minute. Samples collected within the same minute are aggregated // (sum, min, max, count) into a single bucket. // -// Short-term requests (<= 2m) use raw samples for perfect accuracy. +// Short-term requests (<= 70s) use raw samples. // Long-term requests (up to 1h) use the minute buckets to avoid storing thousands // of individual data points. diff --git a/agent/probe_ping_test.go b/agent/probe_ping_test.go index 2df0feb0..9d5c8f90 100644 --- a/agent/probe_ping_test.go +++ b/agent/probe_ping_test.go @@ -96,21 +96,24 @@ func TestDetectICMPMode(t *testing.T) { func TestResolveICMPTarget(t *testing.T) { t.Run("IPv4 literal", func(t *testing.T) { - family, ip := resolveICMPTarget("127.0.0.1") + family, ip, err := resolveICMPTarget("127.0.0.1") + require.NoError(t, err) require.NotNil(t, family) assert.False(t, family.isIPv6) assert.Equal(t, "127.0.0.1", ip.String()) }) t.Run("IPv6 literal", func(t *testing.T) { - family, ip := resolveICMPTarget("::1") + family, ip, err := resolveICMPTarget("::1") + require.NoError(t, err) require.NotNil(t, family) assert.True(t, family.isIPv6) assert.Equal(t, "::1", ip.String()) }) t.Run("IPv4-mapped IPv6 resolves as IPv4", func(t *testing.T) { - family, ip := resolveICMPTarget("::ffff:127.0.0.1") + family, ip, err := resolveICMPTarget("::ffff:127.0.0.1") + require.NoError(t, err) require.NotNil(t, family) assert.False(t, family.isIPv6) assert.Equal(t, "127.0.0.1", ip.String())