From 440e10c34d0858e60ff0befa0baa58457e05d534 Mon Sep 17 00:00:00 2001
From: Clement Tsang <34804052+ClementTsang@users.noreply.github.com>
Date: Sat, 6 May 2023 17:35:10 -0400
Subject: [PATCH] other: disable logging when building with default features
 (#1133)

* other: disable logging when building with default features

* update docs
---
 Cargo.toml                                             | 9 +++++++--
 docs/content/contribution/development/build_process.md | 2 +-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index 8e08424e..a1ef8d9d 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -66,11 +66,14 @@ nvidia = ["nvml-wrapper"]
 zfs = []
 
 # The features we use by default.
-default = ["fern", "log", "battery", "gpu", "zfs"]
+default = ["deploy"]
 
 # The features we use on deploy. Logging is not included as that is primarily (for now) just for debugging locally.
 deploy = ["battery", "gpu", "zfs"]
 
+# Including logging for debugging purposes.
+logging = ["fern", "log"]
+
 [dependencies]
 anyhow = "1.0.71"
 backtrace = "0.3.67"
@@ -131,7 +134,9 @@ filedescriptor = "0.8.2"
 
 [dev-dependencies]
 assert_cmd = "2.0.11"
-cargo-husky = { version = "1.5.0", default-features = false, features = ["user-hooks"] }
+cargo-husky = { version = "1.5.0", default-features = false, features = [
+    "user-hooks",
+] }
 predicates = "3.0.3"
 
 [build-dependencies]
diff --git a/docs/content/contribution/development/build_process.md b/docs/content/contribution/development/build_process.md
index 09efe5cd..8b8fb234 100644
--- a/docs/content/contribution/development/build_process.md
+++ b/docs/content/contribution/development/build_process.md
@@ -28,7 +28,7 @@ Binaries are built currently for various targets. Note that not all of these are
 - Enable cache.
 - Build a release build with:
 
-  - `--features deploy`, which disables unneeded dev features in bottom.
+  - `--features deploy`, which enables only crates needed for release builds.
   - `--locked` to lock the dependency versions.
   - The following env variables set: