lee/bottom
1
0
Fork 0
mirror of https://github.com/ClementTsang/bottom.git synced 2026-08-26 13:26:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: unify cache keys in actions (#890)

Browse Source 
* ci: unify cache keys in actions

* some docs

* because empty strings are false in JS

* update comment

* fix build cache naming
This commit is contained in:
Clement Tsang
2022-11-11 23:45:27 -05:00
committed by GitHub
parent 1960c40a30
commit f41e7cd66d
5 changed files with 59 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/content/contribution/issues-and-pull-requests.md
+1 -1
View File
@@ -28,6 +28,6 @@ The expected workflow for a pull request is:
3. Make any documentation changes if necessary - if you add a new feature, it'll probably need documentation changes. See [here](./documentation.md) for tips on documentation.
4. Commit and create a pull request to merge into the `master` branch. **Please follow the pull request template**.
5. Ask/wait for a maintainer to review your pull request.
- Check if tests pass. These consist of clippy lints, rustfmt checks, and basic tests.
- Check if the CI workflow passes. These consist of clippy lints, rustfmt checks, and basic tests.
- If changes are suggested or any comments are made, they should probably be addressed.
6. Once it looks good, it'll be merged! Note that _generally_, PRs are squashed, though feel free to ask otherwise if that isn't preferable.