Commit Graph
52 Commits
Author SHA1 Message Date
fazzi 4be359f9ff bug: handle Linux cmdline that don't have null byte separators (#2210) 2026-08-25 03:09:06 -04:00
Clement Tsang a10eadd2d5 bug: fix cgroups v1 swap collection around sentinel max value (#2195)
Problem was that with cgroups v1, if the swap had an unlimited value set, it would be done by just setting a huge integer, which would break things.
2026-08-13 05:22:40 -04:00
Clement Tsang e68dd616de other: remove rfind optimization for linux process stat parsing (#2164)
We're removing this micro-optimization in favour of not potentially breaking against the unstable ABI for process lengths. Sucks but oh well.
2026-07-20 01:03:02 +00:00
Clement Tsang 204c1edf9b bug: fix incorrect bound length for comm parentheses searching (#2163)
I made the assumption that the max length of the comm field is 16 bytes. This is wrong though - it's now 64.

Note we may want to change it in the future to work regardless of potential length.
2026-07-19 23:30:19 +00:00
Clement Tsang c696597e81 bug: fix parsing issue certain comm entries to be missing (#2145)
The bug would cause something like `(sd-pam)` to be missing, because what would happen is this:

1. We have something like `"123 ((sd-pam)) blah blah blah"`
2. We parse `start_paren` to be index 5.
3. We parse `end_paren` to be index 13.
4. Our `comm` is `"(sd-pam"`, and the rest of our string is `") blah blah blah"`... which is problematic, as then the rest of the parsing will be incorrect, and the entry gets rejected!
2026-07-12 00:13:49 -04:00
Clement Tsang e19480591d deps: bump ratatui to 0.30.2 and ratatui-core to 0.1.2 (#2098) 2026-06-20 22:26:40 +00:00
Clement Tsang 5fde90fc3f bug: fix memory collection using cgroup v1 sentinel max as total (#2093)
Fixes a bug with cgroups v1, where the "total" if there isn't a limit set may be some crazy high number which would be interpreted as many terabytes large. This is obviously incorrect, so we should not use that as the total, and instead, use the min of the actual total and the cgroups value (so if a lower cgroup v1 value is set, we use that instead).
2026-06-20 04:51:54 -04:00
Justin Martin 3542c0bc49 feature: FreeBSD add ufs disk io counters (#2055)
This PR adds ufs disk io counters on freebsd by using sysinfo. This PR also updates the Cargo.toml to use the dep syntax for the unused feature flags starship-battery and nvml-wrapper.
2026-06-20 02:39:47 -04:00
Clement Tsang 382dfdb80c other: bump min version to 1.95.0 (#2052)
Bumps the minimum version set to 1.95.0. This should give us a couple of neat new features to work with.
2026-06-20 06:16:51 +00:00
Clement Tsang ddc169c6d0 feature: add option to track unmounted disks on Linux (#2088)
This PR adds the option to additionally scan unmounted disk partitions. This currently only works on Linux.
2026-06-20 04:19:32 +00:00
Clement Tsang a629056da9 other: support cgroups for CPU usage% calculations (#2066)
This change makes it so we consider cgroup settings (namely, number of allowed CPUs) when considering average CPU usage/process CPU usage.
2026-05-18 07:36:53 +00:00
Clement Tsang 859ec27a05 feature: take cgroups into account for memory usage (#2061)
This PR adds support for taking cgroup usage/total into account when calculating memory and swap usage.
2026-05-10 07:40:18 +00:00
Clement Tsang 797129156d feature: add temperature graph (#2048)
Add support for a temperature graph widget. Quick-and-dirty implementation for now, will clean this up with other widgets later (maybe after adding a disk graph widget).
2026-05-03 07:19:49 +00:00
Clement Tsang b0ab3e99e7 bug: address possible memory usage growth in AMD GPU stat gathering (#2042)
* driveby changelog update

* fix missing cleanup for AMD GPU stat gathering

* update changelog

* relegate counter to get_amd_vecs
2026-04-18 02:00:35 -04:00
Ada Freya Ahmed fc7f9f4ce1 other: update amdgpu marketing names (#2037) 2026-04-14 01:40:29 -04:00
Clement Tsang 8b548ada95 refactor: run nightly fmt (#2036)
* refactor: run nightly fmt

* manually fix some multilines

* run it again
2026-04-13 05:34:53 +00:00
Clement Tsang 3545a31881 refactor: run nightly format (#2033)
Run `cargo +nightly fmt` using the nightly options (other than wrap comments).
2026-04-12 20:39:30 +00:00
Clement Tsang 8353f15a55 refactor: effectively vendor nohash (#2019) 2026-04-11 04:55:33 -04:00
Clement TsangandWqyJh 42ee4c79af feat: add packet size & packet rate (#1980)
* feat: add packet size & packet rate

* feat: add packet size & packet rate for network basic panel

* update wording

* some text shifting fixes

* fix most things

---------

Co-authored-by: WqyJh <781345688@qq.com>
2026-03-11 23:41:07 -04:00
Clement Tsang 1973ce4ed8 ci: granular checks in CI (#1991)
* ci: granular checks in CI

* cleanup

* update comments

* fix some jobs failing for now

* change cfg

* add comment on why freebsd tests don't work
2026-02-28 06:51:56 -05:00
Clement Tsang 7682f9d6b3 refactor: run nightly format on code (#1951) 2026-01-05 03:59:14 -05:00
Frederick Zhang 14178fc8e3 bug: fix crash caused by multi-byte UTF8 chars in process names (#1943)
When a process name contains multi-byte characters, cmdline[start..end]
is unsafe since it operates on bytes and can cause panic when start/end
are not char boundaries.
2025-12-30 14:11:37 -05:00
Clement Tsang 870d68ab3e bug: fix Windows memory leak caused by getting priority (#1933)
Looks like the issue was related to how we were getting priority in Windows, using the winprocinfo crate. This is resolved by just manually doing the windows API calls necessary.

---

* test if leak is caused by winprocinfo

* manually implement priority code

* cleanup

* update changelog
2025-12-27 11:43:43 -05:00
Clement Tsang d458d1958b other: fix some config code for nice/priority (#1911)
* other: fix some config code for nice/priority

* driveby change from cfg(target_family=unix) to just cfg(unix)

* remove nice as a default for now
2025-12-21 15:22:00 -05:00
Adarsh Das 102ae6b247 feat: Added priority and nice as columns in process view (#1881)
* basic priority and nice functionality

* fix fmt, clippy and tests

* trying to fix other platform build errors

* fmt fix

* trying more fixes

* clean project

* refactored nice to be for all unix systems

* few more places where I had to change cfg for Nice

* Fix scheme names issues

* fix for schema

* fmt

* fixed clippy errors

* 'nice' fix

* fmt

* fixed cfg in tests also

* trying to fix macos test errors

* fix nice value extraction for mac

* modularised nice and priority for mac and freebsd

* fmt

* more multi target to unix

* removing unnecesary guards

* added safety comments

- also reverted string array reference changes

utils fix

* weird utils clippy error fix

* removed unneeded commit

* not needed after main merge(?)
2025-12-21 14:31:43 -05:00
Clement Tsang 94af05ee06 refactor: use rustc-hash and nohash (#1902)
* add nohash and rustc-hash

* use fxhash by default

* comment

* fmt

* clippy

* use nohash for pid stuff

* fix import

* fix imports again

* fix windows type for gpu pid
2025-12-19 03:42:46 -05:00
rezky_nightky f277dff2b2 fix: correct spelling across docs, comments, and configs (#1891) 2025-11-30 16:42:06 -05:00
Clement Tsang 86b35bcd79 refactor: use clippy::unwrap_used (#1882)
* refactor: use clippy::unwrap_used

* fix log format use

* fix a bunch of macos ones

* oop

* allow schema script

* driveby schema bump
2025-11-22 23:26:02 -05:00
Guillaume Gomez f88d9d9404 other: Simplify cfg condition (#1862) 2025-11-15 11:05:57 -05:00
Clement Tsang 3c42f6502a bug: fix issues introduced with average CPU usage refactor (#1846)
* fix potential logic bug with generate points logic, but this isn't the actual issue

* update changelog

* why was that there

* okay let's not bother

* Revert "okay let's not bother"

This reverts commit 1ce8f5619f.

* Revert "why was that there"

This reverts commit 6a2a4da04a.

* Revert "fix potential logic bug with generate points logic, but this isn't the actual issue"

This reverts commit 7f7de8055b.

* Revert "bug/refactor: draw average CPU last, refactor CPU data code (#1804)"

This reverts commit 43e1b34899.

* reverse as a lazy fix for avg
2025-11-04 12:58:46 -05:00
Justin Martin 118bb5e061 feature: free arc (#1812)
* feature: free arc

* freebsd clippy no-default-features

* add alias to free_arc

* add get_threads to default config

* clippy

* code review: combine zfs feature and target_os build cfgs
2025-10-12 15:08:55 -04:00
Piotr Kubaj 59b1db530d bug: fix build on FreeBSD on ARM / POWER (#1817)
Both ARM and POWER use unsigned char. This PR fixes `process_ext.rs` to use `libc::c_char` rather than the previous `i8`.
2025-09-17 11:37:39 -04:00
Clement Tsang e4b814fd0b refactor: optimize username cloning for Unix processes (#1816)
* refactor: rename/update comments for uid_to_username

* use arc<str> instead of cloning user repeatedly

* clippy

* oop

* oop2

* hmmm hopefully that works?

* ugh
2025-09-14 23:47:49 -04:00
Justin MartinandClement Tsang b07f940970 feature: hide k-threads (#1772)
* hide k-threads init

comment

* add config for hide_k_threads

arg help

* update docs for hide_k_threads

* add test_toggle_k_thread for process_table

* update help text and schema

* add hide_k_threads to sample_configs default

* add Virt column to sample default config

* update sample demo config column name for schema ci

* force_rerender_and_update from toggle_k_threads for updates when frozen

* use is_kernel for ProcessType

* remove todo

* Apply suggestions from code review

Co-authored-by: Clement Tsang <34804052+ClementTsang@users.noreply.github.com>

---------

Co-authored-by: Clement Tsang <34804052+ClementTsang@users.noreply.github.com>
2025-09-07 18:56:56 -04:00
Clement Tsang f1017d6f6f bug: fix issue with process name isolation on Linux (#1809)
* driveby fix for dash cmdline bin name

* fmt
2025-09-01 21:50:53 -04:00
Clement Tsang 43e1b34899 bug/refactor: draw average CPU last, refactor CPU data code (#1804)
This PR makes it so we draw the average CPU on top again. This also refactors internals to have the average CPU stored separately.
2025-08-22 04:19:03 +00:00
Clement Tsang 47cc0b346a bug: fix colon at end of process name for now on Linux (#1800)
* driveby use rustix

* refactor some code aeround

* bug: fix colon at end of process name for now

* clippy

* comments

* changelog

* some other changes + test

* extra test
2025-08-21 07:21:44 -04:00
Clement Tsang 3ff7977e6f feature: add support for threads in linux (#1793)
* feature: add support for threads in linux

* bump version too

* only enable for linux for now

* thread some things around

* update changelog

* add highlighting support

* fmt and run schema

* how did this get added

* hmmm cfg in if seems to not work

* fix updated fields

* fixes

* revert uptime rename

* some cleanup

* fix doc

* oop
2025-08-17 07:07:50 +00:00
Clement Tsang 51c67ee599 other: change how we calculate swap usage in Windows (#1769)
* bump sysinfo

* other: change how we calculate swap usage in Windows

* update changelog

* update comments

* add test?

* adjust test
2025-08-03 05:25:11 +00:00
Clement Tsang 4d935bdd70 feature: support virtual memory column for processes (#1767)
* quick refactor of bytes/name

* oop

* Add virt mem field

* add value

* add virtual memory columns + tests

* fix

* Changelog
2025-07-30 04:24:21 +00:00
Clement Tsang 2e6ac01f99 bug: fix parsing issue around certain disk names (#1755)
* bug: fix parsing issue around certain disk names

Turns out that in /proc/mount disk names may have weird escape
characters - these need to be changed when parsing it.

* update changelog

* back to the slow

* Add test
2025-07-17 02:15:55 +00:00
Clement Tsang 1769ee0987 deps: bump sysinfo to 0.35 (#1738)
* deps: bump sysinfo, fix cpu

* fix things for at least Linux

* bump some other stuff

* more things

* windows

* more stuff

* display

* ahhhh it's not stable

* redundant f32

* fix freebsd
2025-06-09 03:00:09 -04:00
Clement Tsang 134888dfec refactor: refactor some process grouping code (#1727)
Remove one clone for process grouping.
2025-05-10 22:24:06 +00:00
Clement Tsang 146b8596cf refactor: some refactoring while stable graphs (#1715)
* update grids

* asdfadf

* asdf

* b

* update loggers

* some formatting and refactoring

* docs

* some comments

* more docs
2025-04-14 06:13:20 +00:00
Clement Tsang 69a4b59573 other: fix clippy warnings (#1712) 2025-04-10 23:20:11 +00:00
Ada Ahmed 37a546ab0f other: update amdgpu marketing names and trim excess keywords (#1692) 2025-03-21 20:04:31 -04:00
Clement Tsang d2177ed022 refactor: don't duplicate AMD GPU temperature retrieval (#1682)
* some file/struct renaming

* refactor: don't get AMD gpu temperatures twice
2025-02-23 06:21:12 +00:00
Clement Tsang f7d070f944 refactor: somewhat migrate to Rust 2024 edition (#1681)
* refactor: try bumping to rust 2024 edition

* now run nightly fmt

* fix some macos changes

* only apply a few of these settings
2025-02-22 02:12:08 +00:00
Clement Tsang d63ca07cae refactor: clean up some file structure, process code, and terminal cleanup (#1676)
* move widgets

* reduce allocations needed

* ah

* more possible optimizations around reducing allocs

* some fixes

* I forgot to clear the buffer oops

* missing

* only run terminal cleanup after certain point
2025-02-15 02:32:09 -05:00
Clement Tsang 702775f58d refactor: use nonzero in mem data (#1673)
* refactor: use nonzerou64 for mem data

* clippy

* comment
2025-02-12 05:58:15 +00:00