Translations - Playwright macro unused, add extra linting for translations, add TRANSLATORS.md (#4087)

.github/workflows/test-only.yml

@@ -44,10 +44,60 @@ jobs:
             exit 1
           fi
 
+  lint-template-i18n:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - name: Check for fragmented gettext calls in templates
+        run: |
+          python3 << 'PYEOF'
+          import re, sys
+          from pathlib import Path
+
+          # Detects adjacent {{ _(...) }} calls on the same line separated only by HTML
+          # tags, whitespace, or non-translating Jinja2 variables — the anti-pattern of
+          # splitting a single sentence across multiple msgids.
+          # See https://github.com/dgtlmoon/changedetection.io/issues/4074 for background.
+          #
+          # The correct fix is to consolidate fragments into one entire-sentence msgid,
+          # injecting dynamic values via %(name)s kwargs — per the GNU gettext manual
+          # sections "Entire sentences" and "No string concatenation". See PR #4076 for
+          # worked examples of each consolidation pattern.
+          #
+          # BASELINE: this limit reflects pre-existing violations present when this check
+          # was introduced. It must only ever go DOWN. Each time you fix a template, lower
+          # the limit by the number of lines fixed so the improvement is locked in.
+          # When the count reaches 0, replace the baseline check with a hard sys.exit(1).
+          BASELINE_LIMIT = 44
+
+          FRAGMENT_RE = re.compile(
+              r'\{\{[^{}]*\b_\s*\([^)]*\)[^{}]*\}\}'
+              r'(?:\s*(?:<[^>]+>|\{\{(?![^}]*\b_\s*\()[^}]*\}\})\s*)+'
+              r'\{\{[^{}]*\b_\s*\([^)]*\)[^{}]*\}\}'
+          )
+
+          violations = []
+          for f in sorted(Path('changedetectionio').rglob('*.html')):
+              for lineno, line in enumerate(f.read_text().splitlines(), 1):
+                  if FRAGMENT_RE.search(line):
+                      violations.append(f"{f}:{lineno}: {line.strip()[:120]}")
+
+          count = len(violations)
+          print(f"Fragmented i18n calls found: {count} (limit: {BASELINE_LIMIT})")
+          for v in violations:
+              print(v)
+
+          if count > BASELINE_LIMIT:
+              print(f"\nERROR: {count} fragmented gettext calls exceed the baseline of {BASELINE_LIMIT}.")
+              print("Consolidate adjacent _() calls into a single entire-sentence msgid.")
+              print("See https://github.com/dgtlmoon/changedetection.io/issues/4074 for patterns.")
+              sys.exit(1)
+          PYEOF
+
   test-application-3-10:
     # Only run on push to master (including PR merges)
     if: github.event_name == 'push' && github.ref == 'refs/heads/master'
-    needs: [lint-code, lint-translations]
+    needs: [lint-code, lint-translations, lint-template-i18n]
     uses: ./.github/workflows/test-stack-reusable-workflow.yml
     with:
       python-version: '3.10'
@@ -55,7 +105,7 @@ jobs:
 
   test-application-3-11:
     # Always run
-    needs: [lint-code, lint-translations]
+    needs: [lint-code, lint-translations, lint-template-i18n]
     uses: ./.github/workflows/test-stack-reusable-workflow.yml
     with:
       python-version: '3.11'
@@ -63,7 +113,7 @@ jobs:
   test-application-3-12:
     # Only run on push to master (including PR merges)
     if: github.event_name == 'push' && github.ref == 'refs/heads/master'
-    needs: [lint-code, lint-translations]
+    needs: [lint-code, lint-translations, lint-template-i18n]
     uses: ./.github/workflows/test-stack-reusable-workflow.yml
     with:
       python-version: '3.12'
@@ -72,7 +122,7 @@ jobs:
   test-application-3-13:
     # Only run on push to master (including PR merges)
     if: github.event_name == 'push' && github.ref == 'refs/heads/master'
-    needs: [lint-code, lint-translations]
+    needs: [lint-code, lint-translations, lint-template-i18n]
     uses: ./.github/workflows/test-stack-reusable-workflow.yml
     with:
       python-version: '3.13'
@@ -81,7 +131,7 @@ jobs:
 
   test-application-3-14:
     #if: github.event_name == 'push' && github.ref == 'refs/heads/master'
-    needs: [lint-code, lint-translations]
+    needs: [lint-code, lint-translations, lint-template-i18n]
     uses: ./.github/workflows/test-stack-reusable-workflow.yml
     with:
       python-version: '3.14'