lee/changedetection.io
1
0
Fork 0
mirror of https://github.com/dgtlmoon/changedetection.io.git synced 2025-12-11 18:45:34 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fetching pages - Custom browser endpoints should not have default proxy info added

Browse Source
This commit is contained in:
dgtlmoon
2024-02-12 19:05:10 +01:00
parent 4163030805
commit ccb42bcb12
4 changed files with 37 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
changedetectionio/processors/__init__.py
View File

@@ -75,8 +75,12 @@ class difference_detection_processor():
proxy_url = None
if preferred_proxy_id:
proxy_url = self.datastore.proxy_list.get(preferred_proxy_id).get('url')
logger.debug(f"Selected proxy key '{preferred_proxy_id}' as proxy URL '{proxy_url}' for {url}")
# Custom browser endpoints should not have a proxy added
if not preferred_proxy_id.startswith('ui-'):
proxy_url = self.datastore.proxy_list.get(preferred_proxy_id).get('url')
logger.debug(f"Selected proxy key '{preferred_proxy_id}' as proxy URL '{proxy_url}' for {url}")
else:
logger.debug(f"Skipping adding proxy data when custom Browser endpoint is specified.")
# Now call the fetcher (playwright/requests/etc) with arguments that only a fetcher would need.
# When browser_connection_url is None, it method should default to working out whats the best defaults (os env vars etc)