lee/changedetection.io
1
0
Fork 0
mirror of https://github.com/dgtlmoon/changedetection.io.git synced 2025-12-09 09:35:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Re #106 - handling empty title with gettr cleanup (#107)

Browse Source
This commit is contained in:
dgtlmoon
2021-06-27 12:29:41 +10:00
committed by GitHub
parent 3fa6bc5ffd
commit db18866b0a
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
backend/html_tools.py
View File

@@ -13,11 +13,14 @@ def css_filter(css_filter, html_content):
# Extract/find element # Extract/find element
def extract_element(find='title', html_content=''): def extract_element(find='title', html_content=''):
html_title = False
#Re #106, be sure to handle when its not found
element_text = None
soup = BeautifulSoup(html_content, 'html.parser') soup = BeautifulSoup(html_content, 'html.parser')
title = soup.find(find) result = soup.find(find)
if title and title.string is not None: if result and result.string:
html_title = title.string.strip() element_text = result.string.strip()
return element_text
return html_title

4
backend/store.py
View File

@@ -185,6 +185,10 @@ class ChangeDetectionStore:
self.__data['watching'][uuid]['viewed'] = False self.__data['watching'][uuid]['viewed'] = False
has_unviewed = True has_unviewed = True
# #106 - Be sure this is None on empty string, False, None, etc
if not self.__data['watching'][uuid]['title']:
self.__data['watching'][uuid]['title'] = None
self.__data['has_unviewed'] = has_unviewed self.__data['has_unviewed'] = has_unviewed
return self.__data return self.__data