mirror of
https://github.com/dgtlmoon/changedetection.io.git
synced 2026-10-29 10:05:45 +00:00
Younes Berianeanddgtlmoon
cb9c6c1426
* Restock - Don't blame stock data when restock detection is off When 'Re-stock detection' is set to "Off, don't follow availability/restock", a page with nothing extractable at all still raised "Unable to extract restock data" / "no embedded stock information was found". The check is still right to fail there - there's nothing to compare on future checks either - but blaming "restock"/stock data is wrong once the user has said they don't care about stock: the actual failure in that case is that no price could be found either, so say that instead. Fixes #4476 * Apply suggestion from @dgtlmoon --------- Co-authored-by: dgtlmoon <leigh@morresi.net>
Change detection post-processors
The concept here is to be able to switch between different domain specific problems to solve.
text_json_diffThe traditional text and JSON comparison handlerrestock_diffOnly cares about detecting if a product looks like it has some text that suggests that it's out of stock, otherwise assumes that it's in stock.
Some suggestions for the future
graphical
API schema extension (api.yaml)
A processor can extend the Watch/Tag API schema by placing an api.yaml alongside its __init__.py.
Define a components.schemas.processor_config_<name> entry and it will be merged into WatchBase at startup,
making processor_config_<name> a valid field on all watch create/update API calls.
The fully merged spec is served live at /api/v1/full-spec.
See restock_diff/api.yaml for a working example.
Todo
- Make each processor return a extra list of sub-processed (so you could configure a single processor in different ways)
- move restock_diff to its own pip/github repo