mirror of
https://github.com/dgtlmoon/changedetection.io.git
synced 2026-10-02 10:08:16 +00:00
TowyTowyandClaude
5e9a8583e2
* Restock detection - fix inverted condition that skipped the OpenGraph availability fallback get_itemprop_availability() only dug through OpenGraph properties when price was missing OR when availability was ALREADY found - so on pages that expose price via JSON-LD but stock state only via the OpenGraph commerce tags (<meta property="product:availability">), the availability (and currency) was silently dropped. The inner loop already guards each field with 'if not value.get(...)', so the outer gate now matches that intent: dig OpenGraph when any of price/availability/currency is still missing. Co-Authored-By: Claude <noreply@anthropic.com> * Normalise availability after the OpenGraph fallback, not before An availability found via OpenGraph was left raw, so the Facebook commerce spelling 'in stock' never matched the 'instock' test and the product read as out of stock. --------- Co-authored-by: Claude <noreply@anthropic.com>
49 lines
2.3 KiB
Python
49 lines
2.3 KiB
Python
#!/usr/bin/env python3
|
|
|
|
# run from dir above changedetectionio/ dir
|
|
# python3 -m unittest changedetectionio.tests.unit.test_restock_logic
|
|
|
|
import unittest
|
|
import os
|
|
|
|
import changedetectionio.processors.restock_diff.processor as restock_diff
|
|
|
|
# mostly
|
|
class TestDiffBuilder(unittest.TestCase):
|
|
|
|
def test_logic(self):
|
|
assert restock_diff.is_between(number=10, lower=9, upper=11) == True, "Between 9 and 11"
|
|
assert restock_diff.is_between(number=10, lower=0, upper=11) == True, "Between 9 and 11"
|
|
assert restock_diff.is_between(number=10, lower=None, upper=11) == True, "Between None and 11"
|
|
assert not restock_diff.is_between(number=12, lower=None, upper=11) == True, "12 is not between None and 11"
|
|
|
|
def test_itemprop_availability_opengraph_fallback(self):
|
|
"""Availability/currency missing from JSON-LD should be filled from OpenGraph
|
|
(Facebook commerce 'product:availability' / 'product:price:currency' meta tags)."""
|
|
html_content = """<!DOCTYPE html>
|
|
<html prefix="og: https://ogp.me/ns# product: https://ogp.me/ns/product#">
|
|
<head>
|
|
<meta property="og:type" content="product">
|
|
<meta property="og:title" content="Some Product">
|
|
<meta property="product:availability" content="in stock">
|
|
<meta property="product:price:currency" content="EUR">
|
|
<script type="application/ld+json">
|
|
{"@context": "https://schema.org", "@type": "Product", "name": "Some Product",
|
|
"offers": {"@type": "Offer", "price": "155.55"}}
|
|
</script>
|
|
</head>
|
|
<body><h1>Some Product</h1></body>
|
|
</html>"""
|
|
|
|
value = restock_diff.get_itemprop_availability(html_content)
|
|
assert value.get('price') == 155.55, "price should be found via JSON-LD"
|
|
assert value.get('currency') == 'EUR', "currency should be found via OpenGraph fallback"
|
|
# Normalised the same way a schema.org value is, so that the in-stock matcher
|
|
# (which looks for 'instock') sees it. OpenGraph spells it 'in stock'.
|
|
assert value.get('availability') == 'instock', "availability should be found via OpenGraph fallback and normalised"
|
|
assert any(s in value.get('availability') for s in ['instock', 'instoreonly']), \
|
|
"a product advertised as available must read as in stock, not out of stock"
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|