mirror of
https://github.com/dgtlmoon/changedetection.io.git
synced 2026-09-19 03:46:37 +00:00
Build and push containers / metadata (push) Canceled after 0s
Build and push containers / build-push-containers (push) Canceled after 0s
Publish Python 🐍distribution 📦 to PyPI and TestPyPI / Build distribution 📦 (push) Canceled after 0s
ChangeDetection.io Container Build Test / Build linux/amd64 (alpine) (push) Canceled after 0s
ChangeDetection.io Container Build Test / Build linux/arm64 (alpine) (push) Canceled after 0s
ChangeDetection.io Container Build Test / Build linux/amd64 (main) (push) Canceled after 0s
ChangeDetection.io Container Build Test / Build linux/arm/v7 (main) (push) Canceled after 0s
ChangeDetection.io Container Build Test / Build linux/arm/v8 (main) (push) Canceled after 0s
ChangeDetection.io Container Build Test / Build linux/arm64 (main) (push) Canceled after 0s
ChangeDetection.io App Test / lint-code (push) Canceled after 0s
ChangeDetection.io App Test / lint-translations (push) Canceled after 0s
ChangeDetection.io App Test / lint-template-i18n (push) Canceled after 0s
Publish Python 🐍distribution 📦 to PyPI and TestPyPI / Test the built package works basically. (push) Canceled after 0s
Publish Python 🐍distribution 📦 to PyPI and TestPyPI / Publish Python 🐍 distribution 📦 to PyPI (push) Canceled after 0s
ChangeDetection.io App Test / test-application-3-11 (push) Canceled after 0s
ChangeDetection.io App Test / test-application-3-12 (push) Canceled after 0s
ChangeDetection.io App Test / test-application-3-13 (push) Canceled after 0s
ChangeDetection.io App Test / test-application-3-14 (push) Canceled after 0s
The `locales` package was installed "For presenting price amounts correctly in
the restock/price detection overview", but nothing ever ran locale-gen. The
package only ships /etc/locale.gen; it does not build any locale. So published
images had only C, C.utf8 and POSIX available, which made the existing
`ENV LC_ALL=en_US.UTF-8` unsatisfiable:
$ docker run --rm --entrypoint bash ghcr.io/dgtlmoon/changedetection.io:latest \
-c 'locale -a'
C
C.utf8
POSIX
locale.setlocale() in flask_app.py therefore raised, was caught by the existing
`except locale.Error` and logged "Unable to set locale ... is not installed
maybe?", and the process stayed on the C locale. The knock-on effect is that the
format_number_locale / format_int_locale Jinja filters lose their thousands
separators, contradicting format_number_locale's own docstring:
before: format_number_locale(1234567.89) -> '1234567.89'
after: format_number_locale(1234567.89) -> '1,234,567.89'
Those filters render prices in the watchlist overview
(blueprint/watchlist/templates/watch-overview-single-row.html), so every
published release has been showing unseparated price amounts.
How it got this way: LC_ALL arrived on master in d1b1dd70f (#3340) without a
locale-gen to satisfy it. The matching `RUN locale-gen en_US.UTF-8` was written
back in 3f73695e7 (2024-07-22), but that commit only ever existed on the
unmerged 2486-charset-encoding branch, so master has never had it.
Generate one glibc locale per UI translation in changedetectionio/translations
rather than only en_US, so that operators can override LC_ALL / LANG to any
language the UI actually offers and get correct local formatting (de_DE gives
1.234.567,89, fr_FR gives 1 234 567,89). Territories for bare language codes
come from CLDR likely-subtags, not from uppercasing the code, which would have
been wrong for cs, ja, ko, uk and zh.
Costs ~21MB and ~16s of build time.
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
178 lines
6.5 KiB
Docker
178 lines
6.5 KiB
Docker
# pip dependencies install stage
|
|
|
|
ARG PYTHON_VERSION=3.11
|
|
|
|
FROM python:${PYTHON_VERSION}-slim-bookworm AS builder
|
|
|
|
# See `cryptography` pin comment in requirements.txt
|
|
|
|
RUN apt-get update && apt-get install -y --no-install-recommends \
|
|
g++ \
|
|
gcc \
|
|
libc-dev \
|
|
libffi-dev \
|
|
libjpeg-dev \
|
|
libssl-dev \
|
|
libxslt-dev \
|
|
make \
|
|
patch \
|
|
pkg-config \
|
|
zlib1g-dev
|
|
|
|
RUN mkdir /install
|
|
WORKDIR /install
|
|
|
|
COPY requirements.txt /requirements.txt
|
|
|
|
# Use cache mounts and multiple wheel sources for faster ARM builds
|
|
ENV PIP_CACHE_DIR=/tmp/pip-cache
|
|
# Help Rust find OpenSSL for cryptography package compilation on ARM
|
|
ENV PKG_CONFIG_PATH="/usr/lib/pkgconfig:/usr/lib/arm-linux-gnueabihf/pkgconfig:/usr/lib/aarch64-linux-gnu/pkgconfig"
|
|
ENV PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1
|
|
ENV OPENSSL_DIR="/usr"
|
|
ENV OPENSSL_LIB_DIR="/usr/lib/arm-linux-gnueabihf"
|
|
ENV OPENSSL_INCLUDE_DIR="/usr/include/openssl"
|
|
# Additional environment variables for cryptography Rust build
|
|
ENV CRYPTOGRAPHY_DONT_BUILD_RUST=1
|
|
|
|
RUN --mount=type=cache,id=pip,sharing=locked,target=/tmp/pip-cache \
|
|
pip install \
|
|
--prefer-binary \
|
|
--extra-index-url https://www.piwheels.org/simple \
|
|
--extra-index-url https://pypi.anaconda.org/ARM-software/simple \
|
|
--cache-dir=/tmp/pip-cache \
|
|
--target=/dependencies \
|
|
-r /requirements.txt
|
|
|
|
# Playwright is an alternative to Selenium
|
|
# Excluded this package from requirements.txt to prevent arm/v6 and arm/v7 builds from failing
|
|
# https://github.com/dgtlmoon/changedetection.io/pull/1067 also musl/alpine (not supported)
|
|
RUN --mount=type=cache,id=pip,sharing=locked,target=/tmp/pip-cache \
|
|
pip install \
|
|
--prefer-binary \
|
|
--cache-dir=/tmp/pip-cache \
|
|
--target=/dependencies \
|
|
playwright~=1.56.0 \
|
|
|| echo "WARN: Failed to install Playwright. The application can still run, but the Playwright option will be disabled."
|
|
|
|
# OpenCV is optional for fast image comparison (pixelmatch is the fallback)
|
|
# Skip on arm/v7 and arm/v8 where builds take weeks - excluded from requirements.txt
|
|
ARG TARGETPLATFORM
|
|
RUN --mount=type=cache,id=pip,sharing=locked,target=/tmp/pip-cache \
|
|
case "$TARGETPLATFORM" in \
|
|
linux/arm/v7|linux/arm/v8) \
|
|
echo "INFO: Skipping OpenCV on $TARGETPLATFORM (build takes too long), using pixelmatch fallback" \
|
|
;; \
|
|
*) \
|
|
pip install \
|
|
--prefer-binary \
|
|
--extra-index-url https://www.piwheels.org/simple \
|
|
--cache-dir=/tmp/pip-cache \
|
|
--target=/dependencies \
|
|
opencv-python-headless>=4.8.0.76 \
|
|
|| echo "WARN: OpenCV install failed, will use pixelmatch fallback" \
|
|
;; \
|
|
esac
|
|
|
|
|
|
# Final image stage
|
|
FROM python:${PYTHON_VERSION}-slim-bookworm
|
|
LABEL org.opencontainers.image.source="https://github.com/dgtlmoon/changedetection.io"
|
|
LABEL org.opencontainers.image.url="https://changedetection.io"
|
|
LABEL org.opencontainers.image.documentation="https://changedetection.io/tutorials"
|
|
LABEL org.opencontainers.image.title="changedetection.io"
|
|
LABEL org.opencontainers.image.description="Self-hosted web page change monitoring and notification service"
|
|
LABEL org.opencontainers.image.licenses="Apache-2.0"
|
|
LABEL org.opencontainers.image.vendor="changedetection.io"
|
|
|
|
RUN apt-get update && apt-get install -y --no-install-recommends \
|
|
libxslt1.1 \
|
|
# For presenting price amounts correctly in the restock/price detection overview
|
|
locales \
|
|
# For pdftohtml
|
|
poppler-utils \
|
|
# favicon type detection and other uses
|
|
file \
|
|
zlib1g \
|
|
# OpenCV dependencies for image processing
|
|
libglib2.0-0 \
|
|
libsm6 \
|
|
libxext6 \
|
|
libxrender-dev \
|
|
&& apt-get clean && rm -rf /var/lib/apt/lists/*
|
|
|
|
# Actually generate the locales. Installing the `locales` package above only
|
|
# ships /etc/locale.gen - it does not build any locale, so the image had just
|
|
# C, C.utf8 and POSIX. That made the `ENV LC_ALL=en_US.UTF-8` below unsatisfiable:
|
|
# locale.setlocale() in flask_app.py failed, fell back to C, and the
|
|
# format_number_locale / format_int_locale Jinja filters silently lost their
|
|
# thousands separators - 1234567.89 rendered as "1234567.89" rather than
|
|
# "1,234,567.89" in the restock/price overview, which is the very thing the
|
|
# `locales` package was added for.
|
|
#
|
|
# More than en_US is generated so that operators can override LC_ALL / LANG and
|
|
# get formatting for their own region (de_DE gives 1.234.567,89, fr_FR gives
|
|
# 1 234 567,89). Costs ~21MB and ~16s of build time.
|
|
#
|
|
# This list mirrors the UI translations in changedetectionio/translations - one
|
|
# glibc locale per language we ship a translation for, so any language a user
|
|
# can pick in the UI also has a working locale. Keep the two in sync when adding
|
|
# a translation. The territory for each bare language code comes from CLDR's
|
|
# likely-subtags (cs -> cs_CZ, ja -> ja_JP, ko -> ko_KR, uk -> uk_UA, zh ->
|
|
# zh_CN, zh_Hant_TW -> zh_TW), NOT from uppercasing the language code.
|
|
RUN for l in cs_CZ de_DE en_GB en_US es_ES fr_FR id_ID it_IT ja_JP ko_KR \
|
|
pl_PL pt_BR ru_RU tr_TR uk_UA zh_CN zh_TW; do \
|
|
sed -i "s/^# *${l}.UTF-8 UTF-8/${l}.UTF-8 UTF-8/" /etc/locale.gen; \
|
|
done \
|
|
&& locale-gen
|
|
|
|
|
|
# https://stackoverflow.com/questions/58701233/docker-logs-erroneously-appears-empty-until-container-stops
|
|
ENV PYTHONUNBUFFERED=1
|
|
|
|
RUN [ ! -d "/datastore" ] && mkdir /datastore
|
|
|
|
# Re #80, sets SECLEVEL=1 in openssl.conf to allow monitoring sites with weak/old cipher suites
|
|
RUN sed -i 's/^CipherString = .*/CipherString = DEFAULT@SECLEVEL=1/' /etc/ssl/openssl.cnf
|
|
|
|
# Copy modules over to the final image and add their dir to PYTHONPATH
|
|
COPY --from=builder /dependencies /usr/local
|
|
ENV PYTHONPATH=/usr/local
|
|
|
|
EXPOSE 5000
|
|
|
|
# The actual flask app module
|
|
COPY changedetectionio /app/changedetectionio
|
|
|
|
# Compile translation files for i18n support
|
|
RUN pybabel compile -d /app/changedetectionio/translations
|
|
|
|
# Also for OpenAPI validation wrapper - needs the YML
|
|
RUN [ ! -d "/app/docs" ] && mkdir /app/docs
|
|
COPY docs/api-spec.yaml /app/docs/api-spec.yaml
|
|
|
|
# Starting wrapper
|
|
COPY changedetection.py /app/changedetection.py
|
|
|
|
# Github Action test purpose(test-only.yml).
|
|
# On production, it is effectively LOGGER_LEVEL=''.
|
|
ARG LOGGER_LEVEL=''
|
|
ENV LOGGER_LEVEL="$LOGGER_LEVEL"
|
|
|
|
# Default
|
|
ENV LC_ALL=en_US.UTF-8
|
|
|
|
WORKDIR /app
|
|
|
|
# Copy and set up entrypoint script for installing extra packages
|
|
COPY docker-entrypoint.sh /docker-entrypoint.sh
|
|
RUN chmod +x /docker-entrypoint.sh
|
|
|
|
# Set entrypoint to handle EXTRA_PACKAGES env var
|
|
ENTRYPOINT ["/docker-entrypoint.sh"]
|
|
|
|
# Default command (can be overridden in docker-compose.yml)
|
|
CMD ["python", "./changedetection.py", "-d", "/datastore"]
|
|
|
|
|