mirror of
https://github.com/dgtlmoon/changedetection.io.git
synced 2026-10-19 18:21:59 +00:00
Jaime KingandClaude Opus 5.5
c8afea1b05
Build and push containers / metadata (push) Canceled after 0s
Build and push containers / build-push-containers (push) Canceled after 0s
Publish Python 🐍distribution 📦 to PyPI and TestPyPI / Build distribution 📦 (push) Canceled after 0s
ChangeDetection.io App Test / lint-code (push) Canceled after 0s
ChangeDetection.io App Test / lint-translations (push) Canceled after 0s
ChangeDetection.io App Test / lint-template-i18n (push) Canceled after 0s
Publish Python 🐍distribution 📦 to PyPI and TestPyPI / Test the built package works basically. (push) Canceled after 0s
Publish Python 🐍distribution 📦 to PyPI and TestPyPI / Publish Python 🐍 distribution 📦 to PyPI (push) Canceled after 0s
ChangeDetection.io App Test / test-application-3-11 (push) Canceled after 0s
ChangeDetection.io App Test / test-application-3-12 (push) Canceled after 0s
ChangeDetection.io App Test / test-application-3-13 (push) Canceled after 0s
ChangeDetection.io App Test / test-application-3-14 (push) Canceled after 0s
The extractors stripped everything but [\d.] before converting, so the decimal comma was thrown away before Restock.parse_currency(), which already understands it, ever saw the value. Route the values through parse_currency() instead, and teach it that a lone "1,299" is a thousands separator so that case does not regress. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
69 lines
4.1 KiB
Python
69 lines
4.1 KiB
Python
#!/usr/bin/env python3
|
|
|
|
# run from dir above changedetectionio/ dir
|
|
# python3 -m unittest changedetectionio.tests.unit.test_restock_logic
|
|
|
|
import unittest
|
|
import os
|
|
|
|
import changedetectionio.processors.restock_diff.processor as restock_diff
|
|
|
|
# mostly
|
|
class TestDiffBuilder(unittest.TestCase):
|
|
|
|
def test_logic(self):
|
|
assert restock_diff.is_between(number=10, lower=9, upper=11) == True, "Between 9 and 11"
|
|
assert restock_diff.is_between(number=10, lower=0, upper=11) == True, "Between 9 and 11"
|
|
assert restock_diff.is_between(number=10, lower=None, upper=11) == True, "Between None and 11"
|
|
assert not restock_diff.is_between(number=12, lower=None, upper=11) == True, "12 is not between None and 11"
|
|
|
|
def test_itemprop_availability_opengraph_fallback(self):
|
|
"""Availability/currency missing from JSON-LD should be filled from OpenGraph
|
|
(Facebook commerce 'product:availability' / 'product:price:currency' meta tags)."""
|
|
html_content = """<!DOCTYPE html>
|
|
<html prefix="og: https://ogp.me/ns# product: https://ogp.me/ns/product#">
|
|
<head>
|
|
<meta property="og:type" content="product">
|
|
<meta property="og:title" content="Some Product">
|
|
<meta property="product:availability" content="in stock">
|
|
<meta property="product:price:currency" content="EUR">
|
|
<script type="application/ld+json">
|
|
{"@context": "https://schema.org", "@type": "Product", "name": "Some Product",
|
|
"offers": {"@type": "Offer", "price": "155.55"}}
|
|
</script>
|
|
</head>
|
|
<body><h1>Some Product</h1></body>
|
|
</html>"""
|
|
|
|
value = restock_diff.get_itemprop_availability(html_content)
|
|
assert value.get('price') == 155.55, "price should be found via JSON-LD"
|
|
assert value.get('currency') == 'EUR', "currency should be found via OpenGraph fallback"
|
|
# Normalised the same way a schema.org value is, so that the in-stock matcher
|
|
# (which looks for 'instock') sees it. OpenGraph spells it 'in stock'.
|
|
assert value.get('availability') == 'instock', "availability should be found via OpenGraph fallback and normalised"
|
|
assert any(s in value.get('availability') for s in ['instock', 'instoreonly']), \
|
|
"a product advertised as available must read as in stock, not out of stock"
|
|
|
|
def test_price_decimal_comma(self):
|
|
"""A decimal comma ("39,99", common for EUR) must not be stripped into 3999"""
|
|
from changedetectionio.processors.restock_diff import Restock
|
|
from changedetectionio.processors.restock_diff.pure_python_extractor import extract_metadata_pure_python, query_price_availability
|
|
|
|
for raw, expected in [("39,99", 39.99), ("12.56", 12.56), ("1.299,00", 1299.0), ("1,299.00", 1299.0),
|
|
("1,299", 1299.0), ("€ 39,99", 39.99), ("$159", 159.0), ("159", 159.0)]:
|
|
assert Restock().parse_currency(raw) == expected, f"parse_currency({raw!r})"
|
|
|
|
microdata = f"""<div itemscope itemtype="http://schema.org/Product"><div itemprop="offers" itemscope itemtype="http://schema.org/Offer">
|
|
<meta itemprop="priceCurrency" content="EUR"><meta itemprop="price" content="{raw}"></div></div>"""
|
|
ld_json = f"""<script type="application/ld+json">{{"@context": "https://schema.org", "@type": "Product", "name": "Some Product",
|
|
"offers": {{"@type": "Offer", "price": "{raw}", "priceCurrency": "EUR"}}}}</script>"""
|
|
microdata_text = f"""<div itemscope itemtype="http://schema.org/Product"><span itemprop="price">{raw}</span></div>"""
|
|
|
|
assert restock_diff.get_itemprop_availability(microdata).get('price') == expected, f"microdata {raw!r}"
|
|
assert restock_diff.get_itemprop_availability(ld_json).get('price') == expected, f"JSON-LD {raw!r}"
|
|
assert query_price_availability(extract_metadata_pure_python(ld_json)).get('price') == expected, f"pure python JSON-LD {raw!r}"
|
|
assert query_price_availability(extract_metadata_pure_python(microdata_text)).get('price') == expected, f"pure python microdata text {raw!r}"
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|