From 5a360242d32760bc93fa3f10932f0edc2a97d04b Mon Sep 17 00:00:00 2001 From: Danny Canter Date: Mon, 16 Jun 2025 17:40:25 -0700 Subject: [PATCH] Fix `make release` goal (#140) We were using a := assignment for BUILD_BIN_DIR which evaluates any variables immediately. Our make release logic sets the envvar and then invokes `all` but at that point the value of BUILD_BIN_DIR has already been determined. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 40fa4e69..940685f9 100644 --- a/Makefile +++ b/Makefile @@ -19,7 +19,7 @@ BUILD_CONFIGURATION ?= debug # Commonly used locations SWIFT := "/usr/bin/swift" ROOT_DIR := $(shell git rev-parse --show-toplevel) -BUILD_BIN_DIR := $(shell $(SWIFT) build -c $(BUILD_CONFIGURATION) --show-bin-path) +BUILD_BIN_DIR = $(shell $(SWIFT) build -c $(BUILD_CONFIGURATION) --show-bin-path) # Variables for libarchive integration LIBARCHIVE_UPSTREAM_REPO := https://github.com/libarchive/libarchive