mirror of
https://github.com/apple/container.git
synced 2026-09-21 15:15:36 +00:00
Ensure two containers cannot use the same DNS hostname. (#490)
- Closes #150, #394. - Introduces `AttachmentConfiguration` type so that we can add key-value options to `--network` in the future. - Eliminates redundant `ContainersService.Item` type. - Since we now ensure at ContainersService that hostnames will not conflict, the network helper IP allocator now simply provides the existing IP if for an allocation on an existing hostname, which should handle (in an eventually consistent way) the case where a container fails to deallocate an IP on shutdown.
This commit is contained in:
@@ -177,8 +177,8 @@ actor NetworksService {
|
||||
// find all containers that refer to the network
|
||||
var referringContainers = Set<String>()
|
||||
for container in containers {
|
||||
for containerNetworkId in container.configuration.networks {
|
||||
if containerNetworkId == id {
|
||||
for attachmentConfiguration in container.configuration.networks {
|
||||
if attachmentConfiguration.network == id {
|
||||
referringContainers.insert(container.configuration.id)
|
||||
break
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user