936c916916
Actually resolve symlink when loading bundle Info.plist. ( #864 )
...
- #859 added the traversal necessary to load the app bundle but forgot
to resolve symlinks. This fix adds the resolution, making it possible to
get default system properties from an app bundle Info.plist even if the
user invokes a command from, for example, `/usr/local/bin/container`
which is a symlink to the actual install path of the bundle.
- Also fixes bugs where an incorrect executable path was supplied in
some calls.
- Breaking change: `CommandLine.executablePathUrl` extension moved from
ContainerPlugin to ContainerVersion.
2025-11-10 17:00:18 -03:00
4944fe1641
Use a consistent capitalization in log and error messages ( #806 )
...
Updates the capitalization in log and error messages to be consistent.
2025-10-24 19:18:32 -07:00
bc70b39182
Fix broken proxy configuration for default kernel fetch. ( #747 )
...
- Closes #466 .
## Type of Change
- [x] Bug fix
- [ ] New feature
- [ ] Breaking change
- [ ] Documentation update
## Motivation and Context
Proxy logic worked well enough for CI but broken in general.
## Testing
- [x] Tested locally
- [x] Added/updated tests
- [ ] Added/updated docs
2025-10-10 10:17:42 -07:00
23b058c53c
Remove StandardErrorPath and StandardOutPath from launchd plists ( #742 )
...
## Type of Change
- [x] Bug fix
## Motivation and Context
We setup logging for the services in `container` using OSLog. See
[here](https://github.com/apple/container/blob/73709232d2705b7008b7380fe90a373059b6074a/Sources/Helpers/APIServer/APIServer.swift#L31 ).
This makes it unnecessary to redirect stderr and stdio for these
services. Additionally, there are some cases where failure to open or
write to the path given for StandardErrorPath or StandardOutPath in a
service's plist could result in a failure to start a service through
`launchctl`.
Related to https://github.com/apple/container/discussions/713
## Testing
- [x] Tested locally
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com >
2025-10-08 16:08:08 -07:00
bfc5ca9222
Removes "all rights reserved" from license header. ( #711 )
...
Closes #63 .
2025-10-03 13:28:16 -07:00
48230f3804
Update license headers in C files ( #693 )
...
## Type of Change
- [x] Bug fix
- [ ] New feature
- [ ] Breaking change
- [ ] Documentation update
## Motivation and Context
There was a duplicated and outdated license header in some files.
## Testing
- [x] Tested locally
- [ ] Added/updated tests
- [ ] Added/updated docs
2025-10-02 09:42:24 -07:00
879dff8fcf
Allow traversing symlink when checking for builtin plugins. ( #528 )
...
- This helps with brew cask packaging, can postflight link
libexec/container/plugins to the appropriate cask location, and the
plugin discovery will traverse the link.
2025-08-20 23:52:24 -07:00
6242706c66
Fixes for install root and plugin detection. ( #467 )
...
- Sets up API server as source of truth for installation root, similarly
to what was done for the data root. `system start` establishes the
install root, setting the environment variable `CONTAINER_INSTALL_ROOT`
when launching the API server.
- The API server propagates the environment variable when launching
helpers, and returns the install root to the CLI via the health check
XPC.
- Includes several fixes for detecting plugins that use app bundle
layout.
2025-08-08 21:44:26 -07:00
88223d8add
Select alternate data path with container system start --app-root path. ( #419 )
...
Closes #418 .
2025-08-06 14:49:09 -07:00
2e1bee1bda
Fix subcommand groups in top level help. ( #351 )
...
- Closes #349 .
2025-07-17 22:10:03 -07:00
1707e1b530
Use {install-root}/libexec/container-plugins for plugins. ( #341 )
...
- Use a directory that's separate from user data, as user-installed
plugins have a distinct lifecycle.
- Closes #340 .
2025-07-15 18:18:38 -07:00
4a4ad40d74
Spelling ( #207 )
...
This PR corrects misspellings identified by the [check-spelling
action](https://github.com/marketplace/actions/check-spelling )
The misspellings have been reported at
https://github.com/jsoref/container/actions/runs/15662939575/attempts/1
The action reports that the changes in this PR would make it happy:
https://github.com/jsoref/container/actions/runs/15662939742/attempts/1#summary-44123289718
---------
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
2025-06-16 10:49:03 -07:00
4d6f7037f3
Plugins: Remove unused devnull var ( #214 )
...
We actually use the output (both stderr and stdout) of the command.
2025-06-16 08:11:25 -07:00
84798601cd
Throw errors in ServiceManager ( #188 )
2025-06-13 17:07:55 -07:00
8e9670c8f8
Initial commit
...
Co-authored-by: Aditya Ramani <a_ramani@apple.com >
Co-authored-by: Agam Dua <agam_dua@apple.com >
Co-authored-by: Danny Canter <danny_canter@apple.com >
Co-authored-by: Dmitry Kovba <dkovba@apple.com >
Co-authored-by: Eric Ernst <eric_ernst@apple.com >
Co-authored-by: Evan Hazlett <ehazlett@apple.com >
Co-authored-by: Gilbert Song <gilbertsong@apple.com >
Co-authored-by: Hugh Bussell <hbussell@apple.com >
Co-authored-by: John Logan <john_logan@apple.com >
Co-authored-by: Kathryn Baldauf <k_baldauf@apple.com >
Co-authored-by: Madhu Venugopal <mvenugopal@apple.com >
Co-authored-by: Michael Crosby <michael_crosby@apple.com >
Co-authored-by: Sidhartha Mani <sidhartha_mani@apple.com >
Co-authored-by: Tanweer Noor <tnoor@apple.com >
Co-authored-by: Ximena Perez Diaz <xperez528@gmail.com >
Co-authored-by: Yibo Zhuang <yzhuang@apple.com >
2025-06-05 15:51:55 -07:00
J Logan