mirror of
https://github.com/apple/container.git
synced 2026-07-13 21:17:05 +00:00
J Logan
d29947121f
- Adds a a `--log-root` option to `swift system start`, propagating the value as `CONTAINER_LOG_ROOT` to services for logging to files instead of the OS log facility. This is not a "production" capability as it neither merges nor rotates logs. - Currently we don't collect logs on CI builds, and we don't have permission to run the `log` command there. The PR adds `--log-root` to the CI test phase, archives the results, and uploads the archive as an artifact. - Use FilePath from swift-system for the log root. Foundation URL is a bit of a footgun for filesystem paths, so unless we identify a showstopper, we should incrementally transition to this type everywhere except where we really need network URLs. - Output the hostname of the CI runner at the start of the test phase so we can identify runner-specific issues where they exist. - Fix formatting for log messages with multiple metadata items, and fix unstructured messages on instances that weren't found using `grep -r 'log\.' Sources`. - Adds command reference documentation for `--log-root`.
105 lines
3.7 KiB
Swift
105 lines
3.7 KiB
Swift
//===----------------------------------------------------------------------===//
|
|
// Copyright © 2025-2026 Apple Inc. and the container project authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import ArgumentParser
|
|
import ContainerAPIClient
|
|
import ContainerResource
|
|
import ContainerizationError
|
|
import Foundation
|
|
|
|
extension Application.VolumeCommand {
|
|
public struct VolumeDelete: AsyncLoggableCommand {
|
|
public static let configuration = CommandConfiguration(
|
|
commandName: "delete",
|
|
abstract: "Delete one or more volumes",
|
|
aliases: ["rm"]
|
|
)
|
|
|
|
@Flag(name: .shortAndLong, help: "Delete all volumes")
|
|
var all = false
|
|
|
|
@OptionGroup
|
|
public var logOptions: Flags.Logging
|
|
|
|
@Argument(help: "Volume names")
|
|
var names: [String] = []
|
|
|
|
public init() {}
|
|
|
|
public func run() async throws {
|
|
let uniqueVolumeNames = Set<String>(names)
|
|
let volumes: [Volume]
|
|
|
|
if all {
|
|
volumes = try await ClientVolume.list()
|
|
} else {
|
|
volumes = try await ClientVolume.list()
|
|
.filter { v in
|
|
uniqueVolumeNames.contains(v.id)
|
|
}
|
|
|
|
// If one of the volumes requested isn't present lets throw. We don't need to do
|
|
// this for --all as --all should be perfectly usable with no volumes to remove,
|
|
// otherwise it'd be quite clunky.
|
|
if volumes.count != uniqueVolumeNames.count {
|
|
let missing = uniqueVolumeNames.filter { id in
|
|
!volumes.contains { v in
|
|
v.id == id
|
|
}
|
|
}
|
|
throw ContainerizationError(
|
|
.notFound,
|
|
message: "failed to delete one or more volumes: \(missing)"
|
|
)
|
|
}
|
|
}
|
|
|
|
var failed = [String]()
|
|
let _log = log
|
|
try await withThrowingTaskGroup(of: Volume?.self) { group in
|
|
for volume in volumes {
|
|
group.addTask {
|
|
do {
|
|
try await ClientVolume.delete(name: volume.id)
|
|
print(volume.id)
|
|
return nil
|
|
} catch {
|
|
_log.error(
|
|
"failed to delete volume",
|
|
metadata: [
|
|
"id": "\(volume.id)",
|
|
"error": "\(error)",
|
|
])
|
|
return volume
|
|
}
|
|
}
|
|
}
|
|
|
|
for try await volume in group {
|
|
guard let volume else {
|
|
continue
|
|
}
|
|
failed.append(volume.id)
|
|
}
|
|
}
|
|
|
|
if failed.count > 0 {
|
|
throw ContainerizationError(.internalError, message: "delete failed for one or more volumes: \(failed)")
|
|
}
|
|
}
|
|
}
|
|
}
|