mirror of
https://github.com/apple/container.git
synced 2026-09-10 17:55:38 +00:00
Aditya Ramani
0846bb6640
Its a bit weird to have to pass `--http` when pulling / pushing images if we are trying to do so from a local registry This PR adds a `RequestScheme` enum type which tries to detect if the connection to the registry should be over http or https. This auto detection is the default behavior and can be overridden by passing the `--scheme http/https` flag to the `run` ,`pull`, `push` `login` and `registry default` command The auto detection works by looking at the hostname / IP. HTTP is used in the following cases - If the hostname starts with `localhost` or is `127.x.x.x` - if the host looks like an IP from the private address space - If the host ends with the current default dns domain name Also in this PR: - Removing some used CLI flag groups and TODOs - Better error messages when registry credentials are not found for a host Signed-off-by: Aditya Ramani <a_ramani@apple.com>
66 lines
2.2 KiB
Swift
66 lines
2.2 KiB
Swift
//===----------------------------------------------------------------------===//
|
|
// Copyright © 2025 Apple Inc. and the container project authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import ArgumentParser
|
|
import ContainerClient
|
|
import Containerization
|
|
import ContainerizationOCI
|
|
import TerminalProgress
|
|
|
|
extension Application {
|
|
struct ImagePush: AsyncParsableCommand {
|
|
static let configuration = CommandConfiguration(
|
|
commandName: "push",
|
|
abstract: "Push an image"
|
|
)
|
|
|
|
@OptionGroup
|
|
var global: Flags.Global
|
|
|
|
@OptionGroup
|
|
var registry: Flags.Registry
|
|
|
|
@Option(help: "Platform string in the form 'os/arch/variant'. Example 'linux/arm64/v8', 'linux/amd64'") var platform: String?
|
|
|
|
@Argument var reference: String
|
|
|
|
func run() async throws {
|
|
var p: Platform?
|
|
if let platform {
|
|
p = try Platform(from: platform)
|
|
}
|
|
|
|
let scheme = try RequestScheme(registry.scheme)
|
|
let image = try await ClientImage.get(reference: reference)
|
|
|
|
let progressConfig = try ProgressConfig(
|
|
description: "Pushing image \(image.reference)",
|
|
itemsName: "blobs",
|
|
showItems: true,
|
|
showSpeed: false,
|
|
ignoreSmallSize: true
|
|
)
|
|
let progress = ProgressBar(config: progressConfig)
|
|
defer {
|
|
progress.finish()
|
|
}
|
|
progress.start()
|
|
_ = try await image.push(platform: p, scheme: scheme, progressUpdate: progress.handler)
|
|
progress.finish()
|
|
}
|
|
}
|
|
}
|