mirror of
https://github.com/apple/container.git
synced 2026-07-13 21:17:05 +00:00
df368b790e
- Fixes: #992 - Port validation previously rejected valid configurations when the same port number was used for different protocols (TCP and UDP). For example: `-p 1024:1024/udp -p 1024:1024/tcp` Although this is a valid and common use case, the validation logic treated it as a conflict. To fix this, I updated the validation key to include the protocol name. The validation now checks for overlapping port numbers only within the same protocol, rather than across all protocols. This change enables binding the same port number for both TCP and UDP, aligning the validation behavior with real-world networking requirements. ## Testing - [x] Tested locally - [x] Added/updated tests - [ ] Added/updated docs
372 lines
15 KiB
Swift
372 lines
15 KiB
Swift
//===----------------------------------------------------------------------===//
|
|
// Copyright © 2025-2026 Apple Inc. and the container project authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import ContainerNetworkService
|
|
import ContainerPersistence
|
|
import Containerization
|
|
import ContainerizationError
|
|
import ContainerizationExtras
|
|
import ContainerizationOCI
|
|
import Foundation
|
|
import TerminalProgress
|
|
|
|
public struct Utility {
|
|
static let publishedPortCountLimit = 64
|
|
|
|
private static let infraImages = [
|
|
DefaultsStore.get(key: .defaultBuilderImage),
|
|
DefaultsStore.get(key: .defaultInitImage),
|
|
]
|
|
|
|
public static func createContainerID(name: String?) -> String {
|
|
guard let name else {
|
|
return UUID().uuidString.lowercased()
|
|
}
|
|
return name
|
|
}
|
|
|
|
public static func isInfraImage(name: String) -> Bool {
|
|
for infraImage in infraImages {
|
|
if name == infraImage {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
public static func trimDigest(digest: String) -> String {
|
|
var digest = digest
|
|
digest.trimPrefix("sha256:")
|
|
if digest.count > 24 {
|
|
digest = String(digest.prefix(24)) + "..."
|
|
}
|
|
return digest
|
|
}
|
|
|
|
public static func validEntityName(_ name: String) throws {
|
|
let pattern = #"^[a-zA-Z0-9][a-zA-Z0-9_.-]+$"#
|
|
let regex = try Regex(pattern)
|
|
if try regex.firstMatch(in: name) == nil {
|
|
throw ContainerizationError(.invalidArgument, message: "invalid entity name \(name)")
|
|
}
|
|
}
|
|
|
|
public static func validMACAddress(_ macAddress: String) throws {
|
|
let pattern = #"^([0-9A-Fa-f]{2}[:-]){5}([0-9A-Fa-f]{2})$"#
|
|
let regex = try Regex(pattern)
|
|
if try regex.firstMatch(in: macAddress) == nil {
|
|
throw ContainerizationError(.invalidArgument, message: "invalid MAC address format \(macAddress), expected format: XX:XX:XX:XX:XX:XX")
|
|
}
|
|
}
|
|
|
|
public static func validPublishPorts(_ publishPorts: [PublishPort]) throws {
|
|
var hostPorts = Set<String>()
|
|
for publishPort in publishPorts {
|
|
for index in publishPort.hostPort..<(publishPort.hostPort + publishPort.count) {
|
|
let hostPortKey = "\(index)/\(publishPort.proto.rawValue)"
|
|
guard !hostPorts.contains(hostPortKey) else {
|
|
throw ContainerizationError(.invalidArgument, message: "host ports for different publish port specs may not overlap")
|
|
}
|
|
hostPorts.insert(hostPortKey)
|
|
}
|
|
}
|
|
}
|
|
|
|
public static func containerConfigFromFlags(
|
|
id: String,
|
|
image: String,
|
|
arguments: [String],
|
|
process: Flags.Process,
|
|
management: Flags.Management,
|
|
resource: Flags.Resource,
|
|
registry: Flags.Registry,
|
|
imageFetch: Flags.ImageFetch,
|
|
progressUpdate: @escaping ProgressUpdateHandler
|
|
) async throws -> (ContainerConfiguration, Kernel) {
|
|
var requestedPlatform = Parser.platform(os: management.os, arch: management.arch)
|
|
// Prefer --platform
|
|
if let platform = management.platform {
|
|
requestedPlatform = try Parser.platform(from: platform)
|
|
}
|
|
let scheme = try RequestScheme(registry.scheme)
|
|
|
|
await progressUpdate([
|
|
.setDescription("Fetching image"),
|
|
.setItemsName("blobs"),
|
|
])
|
|
let taskManager = ProgressTaskCoordinator()
|
|
let fetchTask = await taskManager.startTask()
|
|
let img = try await ClientImage.fetch(
|
|
reference: image,
|
|
platform: requestedPlatform,
|
|
scheme: scheme,
|
|
progressUpdate: ProgressTaskCoordinator.handler(for: fetchTask, from: progressUpdate),
|
|
maxConcurrentDownloads: imageFetch.maxConcurrentDownloads
|
|
)
|
|
|
|
// Unpack a fetched image before use
|
|
await progressUpdate([
|
|
.setDescription("Unpacking image"),
|
|
.setItemsName("entries"),
|
|
])
|
|
let unpackTask = await taskManager.startTask()
|
|
try await img.getCreateSnapshot(
|
|
platform: requestedPlatform,
|
|
progressUpdate: ProgressTaskCoordinator.handler(for: unpackTask, from: progressUpdate))
|
|
|
|
await progressUpdate([
|
|
.setDescription("Fetching kernel"),
|
|
.setItemsName("binary"),
|
|
])
|
|
|
|
let kernel = try await self.getKernel(management: management)
|
|
|
|
// Pull and unpack the initial filesystem
|
|
await progressUpdate([
|
|
.setDescription("Fetching init image"),
|
|
.setItemsName("blobs"),
|
|
])
|
|
let fetchInitTask = await taskManager.startTask()
|
|
let initImage = try await ClientImage.fetch(
|
|
reference: ClientImage.initImageRef, platform: .current, scheme: scheme,
|
|
progressUpdate: ProgressTaskCoordinator.handler(for: fetchInitTask, from: progressUpdate),
|
|
maxConcurrentDownloads: imageFetch.maxConcurrentDownloads)
|
|
|
|
await progressUpdate([
|
|
.setDescription("Unpacking init image"),
|
|
.setItemsName("entries"),
|
|
])
|
|
let unpackInitTask = await taskManager.startTask()
|
|
_ = try await initImage.getCreateSnapshot(
|
|
platform: .current,
|
|
progressUpdate: ProgressTaskCoordinator.handler(for: unpackInitTask, from: progressUpdate))
|
|
|
|
await taskManager.finish()
|
|
|
|
let imageConfig = try await img.config(for: requestedPlatform).config
|
|
let description = img.description
|
|
let pc = try Parser.process(
|
|
arguments: arguments,
|
|
processFlags: process,
|
|
managementFlags: management,
|
|
config: imageConfig
|
|
)
|
|
|
|
var config = ContainerConfiguration(id: id, image: description, process: pc)
|
|
config.platform = requestedPlatform
|
|
|
|
config.resources = try Parser.resources(
|
|
cpus: resource.cpus,
|
|
memory: resource.memory
|
|
)
|
|
|
|
let tmpfs = try Parser.tmpfsMounts(management.tmpFs)
|
|
let volumesOrFs = try Parser.volumes(management.volumes)
|
|
let mountsOrFs = try Parser.mounts(management.mounts)
|
|
|
|
var resolvedMounts: [Filesystem] = []
|
|
resolvedMounts.append(contentsOf: tmpfs)
|
|
|
|
// Resolve volumes and filesystems
|
|
for item in (volumesOrFs + mountsOrFs) {
|
|
switch item {
|
|
case .filesystem(let fs):
|
|
resolvedMounts.append(fs)
|
|
case .volume(let parsed):
|
|
let volume = try await getOrCreateVolume(parsed: parsed)
|
|
let volumeMount = Filesystem.volume(
|
|
name: parsed.name,
|
|
format: volume.format,
|
|
source: volume.source,
|
|
destination: parsed.destination,
|
|
options: parsed.options
|
|
)
|
|
resolvedMounts.append(volumeMount)
|
|
}
|
|
}
|
|
|
|
config.mounts = resolvedMounts
|
|
|
|
config.virtualization = management.virtualization
|
|
|
|
// Parse network specifications with properties
|
|
let parsedNetworks = try management.networks.map { try Parser.network($0) }
|
|
if management.networks.contains(ClientNetwork.noNetworkName) {
|
|
guard management.networks.count == 1 else {
|
|
throw ContainerizationError(.unsupported, message: "no other networks may be created along with network \(ClientNetwork.noNetworkName)")
|
|
}
|
|
config.networks = []
|
|
} else {
|
|
config.networks = try getAttachmentConfigurations(containerId: config.id, networks: parsedNetworks)
|
|
for attachmentConfiguration in config.networks {
|
|
let network: NetworkState = try await ClientNetwork.get(id: attachmentConfiguration.network)
|
|
guard case .running(_, _) = network else {
|
|
throw ContainerizationError(.invalidState, message: "network \(attachmentConfiguration.network) is not running")
|
|
}
|
|
}
|
|
}
|
|
|
|
if management.dnsDisabled {
|
|
config.dns = nil
|
|
} else {
|
|
let domain = management.dnsDomain ?? DefaultsStore.getOptional(key: .defaultDNSDomain)
|
|
config.dns = .init(
|
|
nameservers: management.dnsNameservers,
|
|
domain: domain,
|
|
searchDomains: management.dnsSearchDomains,
|
|
options: management.dnsOptions
|
|
)
|
|
}
|
|
|
|
config.rosetta = management.rosetta || (Platform.current.architecture == "arm64" && requestedPlatform.architecture == "amd64")
|
|
|
|
if management.rosetta && Platform.current.architecture != "arm64" {
|
|
throw ContainerizationError(.unsupported, message: "--rosetta flag requires an arm64 host")
|
|
}
|
|
|
|
config.labels = try Parser.labels(management.labels)
|
|
|
|
config.publishedPorts = try Parser.publishPorts(management.publishPorts)
|
|
guard config.publishedPorts.count <= publishedPortCountLimit else {
|
|
throw ContainerizationError(.invalidArgument, message: "cannot exceed more than \(publishedPortCountLimit) port publish descriptors")
|
|
}
|
|
try validPublishPorts(config.publishedPorts)
|
|
|
|
// Parse --publish-socket arguments and add to container configuration
|
|
// to enable socket forwarding from container to host.
|
|
config.publishedSockets = try Parser.publishSockets(management.publishSockets)
|
|
|
|
config.ssh = management.ssh
|
|
|
|
return (config, kernel)
|
|
}
|
|
|
|
static func getAttachmentConfigurations(containerId: String, networks: [Parser.ParsedNetwork]) throws -> [AttachmentConfiguration] {
|
|
// Validate MAC addresses if provided
|
|
for network in networks {
|
|
if let mac = network.macAddress {
|
|
try validMACAddress(mac)
|
|
}
|
|
}
|
|
|
|
// make an FQDN for the first interface
|
|
let fqdn: String?
|
|
if !containerId.contains(".") {
|
|
// add default domain if it exists, and container ID is unqualified
|
|
if let dnsDomain = DefaultsStore.getOptional(key: .defaultDNSDomain) {
|
|
fqdn = "\(containerId).\(dnsDomain)."
|
|
} else {
|
|
fqdn = nil
|
|
}
|
|
} else {
|
|
// use container ID directly if fully qualified
|
|
fqdn = "\(containerId)."
|
|
}
|
|
|
|
guard networks.isEmpty else {
|
|
// Check if this is only the default network with properties (e.g., MAC address)
|
|
let isOnlyDefaultNetwork = networks.count == 1 && networks[0].name == ClientNetwork.defaultNetworkName
|
|
|
|
// networks may only be specified for macOS 26+ (except for default network with properties)
|
|
if !isOnlyDefaultNetwork {
|
|
guard #available(macOS 26, *) else {
|
|
throw ContainerizationError(.invalidArgument, message: "non-default network configuration requires macOS 26 or newer")
|
|
}
|
|
}
|
|
|
|
// attach the first network using the fqdn, and the rest using just the container ID
|
|
return networks.enumerated().map { item in
|
|
guard item.offset == 0 else {
|
|
return AttachmentConfiguration(
|
|
network: item.element.name,
|
|
options: AttachmentOptions(hostname: containerId, macAddress: item.element.macAddress)
|
|
)
|
|
}
|
|
return AttachmentConfiguration(
|
|
network: item.element.name,
|
|
options: AttachmentOptions(hostname: fqdn ?? containerId, macAddress: item.element.macAddress)
|
|
)
|
|
}
|
|
}
|
|
// if no networks specified, attach to the default network
|
|
return [AttachmentConfiguration(network: ClientNetwork.defaultNetworkName, options: AttachmentOptions(hostname: fqdn ?? containerId, macAddress: nil))]
|
|
}
|
|
|
|
private static func getKernel(management: Flags.Management) async throws -> Kernel {
|
|
// For the image itself we'll take the user input and try with it as we can do userspace
|
|
// emulation for x86, but for the kernel we need it to match the hosts architecture.
|
|
let s: SystemPlatform = .current
|
|
if let userKernel = management.kernel {
|
|
guard FileManager.default.fileExists(atPath: userKernel) else {
|
|
throw ContainerizationError(.notFound, message: "kernel file not found at path \(userKernel)")
|
|
}
|
|
let p = URL(filePath: userKernel)
|
|
return .init(path: p, platform: s)
|
|
}
|
|
return try await ClientKernel.getDefaultKernel(for: s)
|
|
}
|
|
|
|
/// Parses key-value pairs from command line arguments.
|
|
///
|
|
/// Supports formats like "key=value" and standalone keys (treated as "key=").
|
|
/// - Parameter pairs: Array of strings in "key=value" format
|
|
/// - Returns: Dictionary mapping keys to values
|
|
public static func parseKeyValuePairs(_ pairs: [String]) -> [String: String] {
|
|
var result: [String: String] = [:]
|
|
for pair in pairs {
|
|
let components = pair.split(separator: "=", maxSplits: 1)
|
|
if components.count == 2 {
|
|
result[String(components[0])] = String(components[1])
|
|
} else {
|
|
result[pair] = ""
|
|
}
|
|
}
|
|
return result
|
|
}
|
|
|
|
/// Gets an existing volume or creates it if it doesn't exist.
|
|
/// Shows a warning for named volumes when auto-creating.
|
|
private static func getOrCreateVolume(parsed: ParsedVolume) async throws -> Volume {
|
|
let labels = parsed.isAnonymous ? [Volume.anonymousLabel: ""] : [:]
|
|
|
|
let volume: Volume
|
|
do {
|
|
volume = try await ClientVolume.create(
|
|
name: parsed.name,
|
|
driver: "local",
|
|
driverOpts: [:],
|
|
labels: labels
|
|
)
|
|
} catch let error as VolumeError {
|
|
guard case .volumeAlreadyExists = error else {
|
|
throw error
|
|
}
|
|
// Volume already exists, just inspect it
|
|
volume = try await ClientVolume.inspect(parsed.name)
|
|
} catch let error as ContainerizationError {
|
|
// Handle XPC-wrapped volumeAlreadyExists error
|
|
guard error.message.contains("already exists") else {
|
|
throw error
|
|
}
|
|
volume = try await ClientVolume.inspect(parsed.name)
|
|
}
|
|
|
|
// TODO: Warn user if named volume was auto-created
|
|
|
|
return volume
|
|
}
|
|
}
|