mirror of
https://github.com/apple/container.git
synced 2026-09-11 18:25:41 +00:00
Today, because we don't wait for execvpe to finish to continue onwards, it's possible that if you did an exec quick enough after starting an init process for a container, that you could join the init processes namespaces before pivot_root has taken place which is quite fun. Let's wait for exec to finish (or an error to occur) to prevent this.
147 lines
5.2 KiB
Swift
147 lines
5.2 KiB
Swift
//===----------------------------------------------------------------------===//
|
|
// Copyright © 2025 Apple Inc. and the Containerization project authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import ArgumentParser
|
|
import ContainerizationOCI
|
|
import Foundation
|
|
import LCShim
|
|
import Logging
|
|
import Musl
|
|
|
|
struct ExecCommand: ParsableCommand {
|
|
static let configuration = CommandConfiguration(
|
|
commandName: "exec",
|
|
abstract: "Exec in a container"
|
|
)
|
|
|
|
@Option(name: .long, help: "path to an OCI runtime spec process configuration")
|
|
var processPath: String
|
|
|
|
@Option(name: .long, help: "pid of the init process for the container")
|
|
var parentPid: Int
|
|
|
|
func run() throws {
|
|
LoggingSystem.bootstrap(App.standardError)
|
|
let log = Logger(label: "vmexec")
|
|
|
|
let src = URL(fileURLWithPath: processPath)
|
|
let processBytes = try Data(contentsOf: src)
|
|
let process = try JSONDecoder().decode(
|
|
ContainerizationOCI.Process.self,
|
|
from: processBytes
|
|
)
|
|
try execInNamespaces(process: process, log: log)
|
|
}
|
|
|
|
static func enterNS(pidFd: Int32, nsType: Int32) throws {
|
|
guard setns(pidFd, nsType) == 0 else {
|
|
throw App.Errno(stage: "setns(fd)")
|
|
}
|
|
}
|
|
|
|
private func execInNamespaces(
|
|
process: ContainerizationOCI.Process,
|
|
log: Logger
|
|
) throws {
|
|
let syncPipe = FileHandle(fileDescriptor: 3)
|
|
let ackPipe = FileHandle(fileDescriptor: 4)
|
|
|
|
let pidFd = CZ_pidfd_open(Int32(parentPid), 0)
|
|
guard pidFd > 0 else {
|
|
throw App.Errno(stage: "pidfd_open(\(parentPid))")
|
|
}
|
|
try Self.enterNS(
|
|
pidFd: pidFd,
|
|
nsType: CLONE_NEWCGROUP | CLONE_NEWPID | CLONE_NEWUTS | CLONE_NEWNS
|
|
)
|
|
|
|
let processID = fork()
|
|
|
|
guard processID != -1 else {
|
|
try? syncPipe.close()
|
|
try? ackPipe.close()
|
|
|
|
throw App.Errno(stage: "fork")
|
|
}
|
|
|
|
if processID == 0 { // child
|
|
// Wait for the grandparent to tell us that they acked our pid.
|
|
guard let data = try ackPipe.read(upToCount: App.ackPid.count) else {
|
|
throw App.Failure(message: "read ack pipe")
|
|
}
|
|
guard let pidAckStr = String(data: data, encoding: .utf8) else {
|
|
throw App.Failure(message: "convert ack pipe data to string")
|
|
}
|
|
|
|
guard pidAckStr == App.ackPid else {
|
|
throw App.Failure(message: "received invalid acknowledgement string: \(pidAckStr)")
|
|
}
|
|
|
|
guard setsid() != -1 else {
|
|
throw App.Errno(stage: "setsid()")
|
|
}
|
|
|
|
if process.terminal {
|
|
let pty = try Console()
|
|
try pty.configureStdIO()
|
|
var masterFD = pty.master
|
|
|
|
let data = Data(bytes: &masterFD, count: MemoryLayout.size(ofValue: masterFD))
|
|
try syncPipe.write(contentsOf: data)
|
|
|
|
// Wait for the grandparent to tell us that they acked our console.
|
|
guard let data = try ackPipe.read(upToCount: App.ackConsole.count) else {
|
|
throw App.Failure(message: "read ack pipe")
|
|
}
|
|
|
|
guard let consoleAckStr = String(data: data, encoding: .utf8) else {
|
|
throw App.Failure(message: "convert ack pipe data to string")
|
|
}
|
|
|
|
guard consoleAckStr == App.ackConsole else {
|
|
throw App.Failure(message: "received invalid acknowledgement string: \(consoleAckStr)")
|
|
}
|
|
|
|
guard ioctl(0, UInt(TIOCSCTTY), 0) != -1 else {
|
|
throw App.Errno(stage: "setctty(0)")
|
|
}
|
|
try pty.close()
|
|
}
|
|
|
|
// Apply O_CLOEXEC to all file descriptors except stdio.
|
|
// This ensures that all unwanted fds we may have accidentally
|
|
// inherited are marked close-on-exec so they stay out of the
|
|
// container.
|
|
try App.applyCloseExecOnFDs()
|
|
try App.setRLimits(rlimits: process.rlimits)
|
|
|
|
// Change stdio to be owned by the requested user.
|
|
try App.fixStdioPerms(user: process.user)
|
|
|
|
// Set uid, gid, and supplementary groups
|
|
try App.setPermissions(user: process.user)
|
|
|
|
try App.exec(process: process)
|
|
} else { // parent process
|
|
// Send our child's pid to our parent before we exit.
|
|
var childPid = processID
|
|
let data = Data(bytes: &childPid, count: MemoryLayout.size(ofValue: childPid))
|
|
|
|
try syncPipe.write(contentsOf: data)
|
|
}
|
|
}
|
|
}
|