mirror of
https://github.com/apple/container.git
synced 2026-09-19 06:05:46 +00:00
Today force deleting (if a container is running then stop()'ing first) is handled entirely in the cli, which is brittle. The CLI doesn't know if the container was started with --rm so it would have to do a weird timeout + list dance to check if the containers gone after stopping. This change remedies this by just having the daemon take in a `force` boolean to the delete rpc. If this is provided and the container is running then we'll stop first, and then cleanup. We can additionally not cleanup if --rm was provided as the daemon has the data to determine if a container asked for autoRemove.
121 lines
4.6 KiB
Swift
121 lines
4.6 KiB
Swift
//===----------------------------------------------------------------------===//
|
|
// Copyright © 2025 Apple Inc. and the container project authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import ArgumentParser
|
|
import ContainerClient
|
|
import ContainerizationError
|
|
import Foundation
|
|
|
|
extension Application {
|
|
struct ContainerDelete: AsyncParsableCommand {
|
|
static let configuration = CommandConfiguration(
|
|
commandName: "delete",
|
|
abstract: "Delete one or more containers",
|
|
aliases: ["rm"])
|
|
|
|
@Flag(name: .shortAndLong, help: "Force the removal of one or more running containers")
|
|
var force = false
|
|
|
|
@Flag(name: .shortAndLong, help: "Remove all containers")
|
|
var all = false
|
|
|
|
@OptionGroup
|
|
var global: Flags.Global
|
|
|
|
@Argument(help: "Container IDs/names")
|
|
var containerIDs: [String] = []
|
|
|
|
func validate() throws {
|
|
if containerIDs.count == 0 && !all {
|
|
throw ContainerizationError(.invalidArgument, message: "no containers specified and --all not supplied")
|
|
}
|
|
if containerIDs.count > 0 && all {
|
|
throw ContainerizationError(
|
|
.invalidArgument,
|
|
message: "explicitly supplied container ID(s) conflict with the --all flag"
|
|
)
|
|
}
|
|
}
|
|
|
|
mutating func run() async throws {
|
|
let set = Set<String>(containerIDs)
|
|
var containers = [ClientContainer]()
|
|
|
|
if all {
|
|
containers = try await ClientContainer.list()
|
|
} else {
|
|
let ctrs = try await ClientContainer.list()
|
|
containers = ctrs.filter { c in
|
|
set.contains(c.id)
|
|
}
|
|
// If one of the containers requested isn't present, let's throw. We don't need to do
|
|
// this for --all as --all should be perfectly usable with no containers to remove; otherwise,
|
|
// it'd be quite clunky.
|
|
if containers.count != set.count {
|
|
let missing = set.filter { id in
|
|
!containers.contains { c in
|
|
c.id == id
|
|
}
|
|
}
|
|
throw ContainerizationError(
|
|
.notFound,
|
|
message: "failed to delete one or more containers: \(missing)"
|
|
)
|
|
}
|
|
}
|
|
|
|
var failed = [String]()
|
|
let force = self.force
|
|
let all = self.all
|
|
try await withThrowingTaskGroup(of: String?.self) { group in
|
|
for container in containers {
|
|
group.addTask {
|
|
do {
|
|
if container.status == .running && !force {
|
|
guard all else {
|
|
throw ContainerizationError(.invalidState, message: "container is running")
|
|
}
|
|
return nil // Skip running container when using --all
|
|
}
|
|
|
|
try await container.delete(force: force)
|
|
print(container.id)
|
|
return nil
|
|
} catch {
|
|
log.error("failed to delete container \(container.id): \(error)")
|
|
return container.id
|
|
}
|
|
}
|
|
}
|
|
|
|
for try await ctr in group {
|
|
guard let ctr else {
|
|
continue
|
|
}
|
|
failed.append(ctr)
|
|
}
|
|
}
|
|
|
|
if failed.count > 0 {
|
|
throw ContainerizationError(
|
|
.internalError,
|
|
message: "delete failed for one or more containers: \(failed)"
|
|
)
|
|
}
|
|
}
|
|
}
|
|
}
|