mirror of
https://github.com/apple/container.git
synced 2026-07-14 05:27:02 +00:00
bc70b39182
- Closes #466. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation update ## Motivation and Context Proxy logic worked well enough for CI but broken in general. ## Testing - [x] Tested locally - [x] Added/updated tests - [ ] Added/updated docs
196 lines
7.0 KiB
Swift
196 lines
7.0 KiB
Swift
//===----------------------------------------------------------------------===//
|
|
// Copyright © 2025 Apple Inc. and the container project authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import Foundation
|
|
import Testing
|
|
|
|
@testable import ContainerPlugin
|
|
|
|
struct PluginLoaderTest {
|
|
@Test
|
|
func testFindAll() async throws {
|
|
let tempURL = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
|
|
defer { try? FileManager.default.removeItem(at: tempURL) }
|
|
let factory = try setupMock(tempURL: tempURL)
|
|
let loader = try PluginLoader(
|
|
appRoot: tempURL,
|
|
installRoot: URL(filePath: "/usr/local/"),
|
|
pluginDirectories: [tempURL],
|
|
pluginFactories: [factory]
|
|
)
|
|
let plugins = loader.findPlugins()
|
|
|
|
#expect(Set(plugins.map { $0.name }) == Set(["cli", "service"]))
|
|
}
|
|
|
|
@Test
|
|
func testFindAllSymlink() async throws {
|
|
let tempURL = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
|
|
defer { try? FileManager.default.removeItem(at: tempURL) }
|
|
let factory = try setupMock(tempURL: tempURL)
|
|
|
|
// move the CLI plugin elsewhere and symlink it
|
|
let otherTempURL = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
|
|
defer { try? FileManager.default.removeItem(at: otherTempURL) }
|
|
try FileManager.default.createDirectory(at: otherTempURL, withIntermediateDirectories: true)
|
|
let srcURL = tempURL.appendingPathComponent("cli")
|
|
let dstURL = otherTempURL.appendingPathComponent("cli")
|
|
try FileManager.default.moveItem(
|
|
at: srcURL,
|
|
to: dstURL
|
|
)
|
|
try FileManager.default.createSymbolicLink(
|
|
at: srcURL,
|
|
withDestinationURL: dstURL
|
|
)
|
|
|
|
let loader = try PluginLoader(
|
|
appRoot: tempURL,
|
|
installRoot: URL(filePath: "/usr/local/"),
|
|
pluginDirectories: [tempURL],
|
|
pluginFactories: [factory]
|
|
)
|
|
let plugins = loader.findPlugins()
|
|
|
|
#expect(Set(plugins.map { $0.name }) == Set(["cli", "service"]))
|
|
}
|
|
|
|
@Test
|
|
func testFindByName() async throws {
|
|
let tempURL = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
|
|
defer { try? FileManager.default.removeItem(at: tempURL) }
|
|
let factory = try setupMock(tempURL: tempURL)
|
|
let loader = try PluginLoader(
|
|
appRoot: tempURL,
|
|
installRoot: URL(filePath: "/usr/local/"),
|
|
pluginDirectories: [tempURL],
|
|
pluginFactories: [factory]
|
|
)
|
|
|
|
#expect(loader.findPlugin(name: "cli")?.name == "cli")
|
|
#expect(loader.findPlugin(name: "service")?.name == "service")
|
|
#expect(loader.findPlugin(name: "throw") == nil)
|
|
}
|
|
|
|
@Test
|
|
func testFilterEnvironmentWithContainerPrefix() async throws {
|
|
let env = [
|
|
"CONTAINER_FOO": "bar",
|
|
"CONTAINER_BAZ": "qux",
|
|
"OTHER_VAR": "value",
|
|
]
|
|
let filtered = PluginLoader.filterEnvironment(env: env, additionalAllowKeys: [])
|
|
|
|
#expect(filtered == ["CONTAINER_FOO": "bar", "CONTAINER_BAZ": "qux"])
|
|
}
|
|
|
|
@Test
|
|
func testFilterEnvironmentWithProxyKeys() async throws {
|
|
let env = [
|
|
"http_proxy": "http://proxy:8080",
|
|
"HTTP_PROXY": "http://proxy:8080",
|
|
"https_proxy": "https://proxy:8443",
|
|
"HTTPS_PROXY": "https://proxy:8443",
|
|
"no_proxy": "localhost,127.0.0.1",
|
|
"NO_PROXY": "localhost,127.0.0.1",
|
|
"OTHER_VAR": "value",
|
|
]
|
|
let filtered = PluginLoader.filterEnvironment(env: env)
|
|
|
|
#expect(
|
|
filtered == [
|
|
"http_proxy": "http://proxy:8080",
|
|
"HTTP_PROXY": "http://proxy:8080",
|
|
"https_proxy": "https://proxy:8443",
|
|
"HTTPS_PROXY": "https://proxy:8443",
|
|
"no_proxy": "localhost,127.0.0.1",
|
|
"NO_PROXY": "localhost,127.0.0.1",
|
|
])
|
|
}
|
|
|
|
@Test
|
|
func testFilterEnvironmentWithBothContainerAndProxy() async throws {
|
|
let env = [
|
|
"CONTAINER_FOO": "bar",
|
|
"http_proxy": "http://proxy:8080",
|
|
"OTHER_VAR": "value",
|
|
"ANOTHER_VAR": "value2",
|
|
]
|
|
let filtered = PluginLoader.filterEnvironment(env: env)
|
|
|
|
#expect(
|
|
filtered == [
|
|
"CONTAINER_FOO": "bar",
|
|
"http_proxy": "http://proxy:8080",
|
|
])
|
|
}
|
|
|
|
@Test
|
|
func testFilterEnvironmentWithCustomAllowKeys() async throws {
|
|
let env = [
|
|
"CONTAINER_FOO": "bar",
|
|
"CUSTOM_KEY": "custom_value",
|
|
"OTHER_VAR": "value",
|
|
]
|
|
let filtered = PluginLoader.filterEnvironment(env: env, additionalAllowKeys: ["CUSTOM_KEY"])
|
|
|
|
#expect(
|
|
filtered == [
|
|
"CONTAINER_FOO": "bar",
|
|
"CUSTOM_KEY": "custom_value",
|
|
])
|
|
}
|
|
|
|
@Test
|
|
func testFilterEnvironmentEmpty() async throws {
|
|
let filtered = PluginLoader.filterEnvironment(env: [:])
|
|
|
|
#expect(filtered.isEmpty)
|
|
}
|
|
|
|
@Test
|
|
func testFilterEnvironmentNoMatches() async throws {
|
|
let env = [
|
|
"PATH": "/usr/bin",
|
|
"HOME": "/Users/test",
|
|
"USER": "testuser",
|
|
]
|
|
let filtered = PluginLoader.filterEnvironment(env: env, additionalAllowKeys: [])
|
|
|
|
#expect(filtered.isEmpty)
|
|
}
|
|
|
|
private func setupMock(tempURL: URL) throws -> MockPluginFactory {
|
|
let cliConfig = PluginConfig(abstract: "cli", author: "CLI", servicesConfig: nil)
|
|
let cliPlugin: Plugin = Plugin(binaryURL: URL(filePath: "/bin/cli"), config: cliConfig)
|
|
let serviceServicesConfig = PluginConfig.ServicesConfig(
|
|
loadAtBoot: false,
|
|
runAtLoad: false,
|
|
services: [PluginConfig.Service(type: .runtime, description: nil)],
|
|
defaultArguments: []
|
|
)
|
|
let serviceConfig = PluginConfig(abstract: "service", author: "SERVICE", servicesConfig: serviceServicesConfig)
|
|
let servicePlugin: Plugin = Plugin(binaryURL: URL(filePath: "/bin/service"), config: serviceConfig)
|
|
let mockPlugins = [
|
|
"cli": cliPlugin,
|
|
MockPluginFactory.throwSuffix: nil,
|
|
"service": servicePlugin,
|
|
]
|
|
|
|
return try MockPluginFactory(tempURL: tempURL, plugins: mockPlugins)
|
|
}
|
|
}
|