mirror of
https://github.com/safishamsi/graphify.git
synced 2026-09-05 21:25:46 +00:00
fix: resolve tsconfig path aliases relative to baseUrl
_read_tsconfig_aliases joined alias targets onto the tsconfig's own directory and ignored compilerOptions.baseUrl. In the common monorepo / NestJS layout (baseUrl "./src" with "@services/*": ["services/*"]), the alias resolved to <dir>/services instead of <dir>/src/services, so every aliased import failed to resolve and the import edge was silently dropped — leaving cross-file caller graphs nearly empty on alias-heavy TS repos. Resolve `paths` relative to `baseUrl` (TypeScript's actual semantics), defaulting to "." so configs without baseUrl keep their current behavior. Add a regression test covering a subdirectory baseUrl; the existing alias test only exercised baseUrl ".", which is why this slipped through. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
cce2673021
commit
ec04152a90
@@ -334,6 +334,27 @@ def test_tsconfig_alias_import_resolves_existing_ts_file(tmp_path: Path):
|
||||
assert _has_edge(result, "src/routes/page.ts", "src/lib/types/type-helpers.ts")
|
||||
|
||||
|
||||
def test_tsconfig_alias_with_subdirectory_baseurl_resolves_existing_ts_file(tmp_path: Path):
|
||||
# `paths` are resolved relative to `baseUrl`, which is commonly a
|
||||
# subdirectory in monorepo / NestJS layouts (baseUrl "./src").
|
||||
# Regression: baseUrl was ignored, so "@services/*": ["services/*"] with
|
||||
# baseUrl "./src" resolved to <root>/services instead of <root>/src/services,
|
||||
# and every aliased import edge was silently dropped.
|
||||
_write(
|
||||
tmp_path / "tsconfig.json",
|
||||
json.dumps({"compilerOptions": {"baseUrl": "./src", "paths": {"@services/*": ["services/*"]}}}),
|
||||
)
|
||||
target = _write(tmp_path / "src/services/foo/index.ts", "export class Foo { id = '' }\n")
|
||||
importer = _write(
|
||||
tmp_path / "src/routes/page.ts",
|
||||
"import { Foo } from '@services/foo'\nnew Foo()\n",
|
||||
)
|
||||
|
||||
result = _extract_for([target, importer], tmp_path)
|
||||
|
||||
assert _has_edge(result, "src/routes/page.ts", "src/services/foo/index.ts")
|
||||
|
||||
|
||||
def test_tsconfig_array_extends_alias_resolves_existing_ts_file(tmp_path: Path):
|
||||
# TypeScript 5.0 allows `extends` as an array; later entries override
|
||||
# earlier ones. The `paths` alias is inherited from the second parent.
|
||||
|
||||
Reference in New Issue
Block a user