"""Tests for `graphify extract` CLI dispatch path in graphify.__main__.""" from __future__ import annotations import pytest import graphify.__main__ as mainmod def _make_corpus(tmp_path): """Minimal corpus: one Go code file + one Markdown doc. Both file types are needed so semantic extraction is requested (docs path triggers the LLM step we want to assert against). """ (tmp_path / "main.go").write_text("package main\nfunc main() {}\n") (tmp_path / "README.md").write_text("# Notes\nThe main function entry point.\n") return tmp_path def test_extract_exits_nonzero_when_all_semantic_chunks_fail( monkeypatch, tmp_path, capsys ): """When every semantic chunk errors (e.g. backend SDK not installed), the CLI must exit non-zero instead of silently writing an AST-only graph. The bug this guards: `pip install graphifyy` doesn't pull in `anthropic`, so `graphify extract --backend claude` would print per-chunk errors and still exit 0 with a graph.json. Callers checking exit status saw success. """ corpus = _make_corpus(tmp_path) out_dir = tmp_path / "out" # Stub the API-key check so the backend gate doesn't reject before we # reach the semantic-extraction step. monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-test-fake-key") # Patch extract_corpus_parallel to simulate "all chunks failed": # return an empty merged accumulator without ever invoking on_chunk_done. # This matches the real behavior of extract_corpus_parallel when every # chunk raises (the per-chunk failures print to stderr and the loop # continues without calling the success callback). def _all_chunks_failed(paths, **kwargs): return { "nodes": [], "edges": [], "hyperedges": [], "input_tokens": 0, "output_tokens": 0, } monkeypatch.setattr( "graphify.llm.extract_corpus_parallel", _all_chunks_failed ) monkeypatch.setattr(mainmod, "_check_skill_version", lambda _: None) monkeypatch.setattr( mainmod.sys, "argv", ["graphify", "extract", str(corpus), "--backend", "claude", "--out", str(out_dir)], ) with pytest.raises(SystemExit) as exc_info: mainmod.main() assert exc_info.value.code == 1, ( f"expected exit code 1 when all semantic chunks fail, " f"got {exc_info.value.code}" ) stderr = capsys.readouterr().err assert "all semantic chunks failed" in stderr assert "claude" in stderr # No graph.json should have been written - the failure must abort before # the merge/cluster/write phase, not after. assert not (out_dir / "graphify-out" / "graph.json").exists(), ( "graph.json must not be written when semantic extraction fails" ) def test_extract_succeeds_when_at_least_one_chunk_completes( monkeypatch, tmp_path ): """Sanity counter-test: a successful chunk run keeps exit 0. Confirms the new guard only fires on the all-failed path, not on every extract.""" corpus = _make_corpus(tmp_path) out_dir = tmp_path / "out" monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-test-fake-key") def _one_chunk_succeeded(paths, **kwargs): on_chunk = kwargs.get("on_chunk_done") if on_chunk: on_chunk(0, 1, {"nodes": [], "edges": [], "hyperedges": []}) return { "nodes": [], "edges": [], "hyperedges": [], "input_tokens": 100, "output_tokens": 50, } monkeypatch.setattr( "graphify.llm.extract_corpus_parallel", _one_chunk_succeeded ) cache_call = {} def _capture_semantic_cache(*args, **kwargs): cache_call.update(kwargs) return 0 monkeypatch.setattr( "graphify.cache.save_semantic_cache", _capture_semantic_cache ) monkeypatch.setattr(mainmod, "_check_skill_version", lambda _: None) monkeypatch.setattr( mainmod.sys, "argv", ["graphify", "extract", str(corpus), "--backend", "claude", "--out", str(out_dir)], ) # extract may still raise SystemExit at the end (clean exit code 0) # depending on platform; accept either no exception or SystemExit(0). try: mainmod.main() except SystemExit as exc: assert exc.code in (None, 0), f"unexpected exit code {exc.code}" # graph.json should exist on the happy path assert (out_dir / "graphify-out" / "graph.json").exists(), ( "graph.json must be written on the happy path" ) assert { str(path) for path in cache_call["allowed_source_files"] } == {str(corpus / "README.md")} def test_manifest_stamps_freshly_extracted_semantic_docs(monkeypatch, tmp_path): """#1897: fresh extraction returns nodes with ROOT-RELATIVE source_file, while the #933 manifest filter compared them against detect()'s ABSOLUTE paths — so `f in _sem_extracted` was always False and every freshly extracted doc was dropped from the manifest (only code/zero-node files survived). Both sides must be resolved against the scan root; a genuinely omitted doc (zero nodes) must still stay unstamped (#933 is intentional).""" import json corpus = _make_corpus(tmp_path) # main.go + README.md (corpus / "OMITTED.md").write_text("# never extracted\n") out_dir = tmp_path / "out" monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-test-fake-key") def _fresh_relative(paths, **kwargs): on_chunk = kwargs.get("on_chunk_done") if on_chunk: on_chunk(0, 1, {"nodes": [], "edges": [], "hyperedges": []}) # Root-relative source_file, exactly what a fresh extraction produces. # OMITTED.md gets no nodes/edges — the model skipped it. return { "nodes": [{"id": "readme", "source_file": "README.md", "file_type": "document"}], "edges": [], "hyperedges": [], "input_tokens": 10, "output_tokens": 5, } monkeypatch.setattr("graphify.llm.extract_corpus_parallel", _fresh_relative) monkeypatch.setattr(mainmod, "_check_skill_version", lambda _: None) monkeypatch.setattr( mainmod.sys, "argv", ["graphify", "extract", str(corpus), "--backend", "claude", "--no-cluster", "--out", str(out_dir)], ) try: mainmod.main() except SystemExit as exc: assert exc.code in (None, 0), f"unexpected exit code {exc.code}" manifest_path = out_dir / "graphify-out" / "manifest.json" assert manifest_path.exists() manifest = json.loads(manifest_path.read_text()) assert "README.md" in manifest, ( f"freshly-extracted doc missing from manifest (#1897): {sorted(manifest)}" ) assert manifest["README.md"].get("semantic_hash"), ( "freshly-extracted doc must carry a non-empty semantic_hash" ) # Code files are always stamped. assert manifest.get("main.go", {}).get("semantic_hash") # The zero-node doc stays unstamped so detect_incremental re-queues it (#933). assert "OMITTED.md" not in manifest, ( "zero-node doc must not be stamped in the manifest" ) def test_stamped_manifest_files_normalizes_both_sides(tmp_path): """Unit test for the #1897 helper: relative (fresh) and absolute (cache-hit) source_file values must both match detect()'s absolute file lists; docs with no output are filtered; code files pass through untouched.""" from graphify.cli import _stamped_manifest_files fresh_doc = tmp_path / "fresh.md"; fresh_doc.write_text("# fresh") cached_doc = tmp_path / "cached.md"; cached_doc.write_text("# cached") omitted_doc = tmp_path / "omitted.md"; omitted_doc.write_text("# omitted") code = tmp_path / "app.py"; code.write_text("x = 1") files_by_type = { "code": [str(code)], "document": [str(fresh_doc), str(cached_doc), str(omitted_doc)], } sem_result = { # fresh extraction: root-relative source_file "nodes": [{"id": "n1", "source_file": "fresh.md"}], # cache replay: absolute source_file (edge-only coverage counts too) "edges": [{"source": "a", "target": "b", "source_file": str(cached_doc)}], } out = _stamped_manifest_files(files_by_type, sem_result, tmp_path) assert out["code"] == [str(code)] assert out["document"] == [str(fresh_doc), str(cached_doc)] def _code_only_corpus(tmp_path): """A corpus with only code — no docs/papers/images.""" (tmp_path / "auth.py").write_text( "def login(user):\n return validate(user)\n\n" "def validate(user):\n return True\n" ) return tmp_path def _clear_backend_keys(monkeypatch): """Clear every env var that detect_backend() or _get_backend_api_key() reads.""" for key in ( "GEMINI_API_KEY", "GOOGLE_API_KEY", "OPENAI_API_KEY", "ANTHROPIC_API_KEY", "DEEPSEEK_API_KEY", "MOONSHOT_API_KEY", # bedrock: presence of any of these is treated as a valid credential "AWS_PROFILE", "AWS_REGION", "AWS_DEFAULT_REGION", "AWS_ACCESS_KEY_ID", # ollama: a set OLLAMA_BASE_URL triggers backend detection "OLLAMA_BASE_URL", ): monkeypatch.delenv(key, raising=False) def test_extract_codeonly_succeeds_without_api_key(monkeypatch, tmp_path): """A code-only corpus must run with no LLM API key. Regression: graphify extract validated a backend upfront and exited 1 with 'no LLM API key found' even for a code-only corpus that never calls a model. The keyless AST path now runs to a written graph.json (#1122). """ corpus = _code_only_corpus(tmp_path) out_dir = tmp_path / "out" _clear_backend_keys(monkeypatch) monkeypatch.setattr(mainmod, "_check_skill_version", lambda _: None) monkeypatch.setattr( mainmod.sys, "argv", ["graphify", "extract", str(corpus), "--out", str(out_dir)], ) try: mainmod.main() except SystemExit as exc: assert exc.code in (None, 0), f"unexpected exit code {exc.code}" graph = out_dir / "graphify-out" / "graph.json" assert graph.exists(), "code-only extract must write graph.json without a key" import json assert len(json.loads(graph.read_text()).get("nodes", [])) > 0 def test_extract_out_keeps_project_root_clean(monkeypatch, tmp_path): """`extract --out DIR` routes every artifact to DIR/graphify-out/ and the scanned project must not grow a graphify-out/ (or anything else) beside its sources. Guards the centralized-output workflow: run from the project root with --out pointing outside the repo, and the repo stays byte-identical. """ project = tmp_path / "project" project.mkdir() corpus = _code_only_corpus(project) external = tmp_path / "external-graphs" _clear_backend_keys(monkeypatch) monkeypatch.setattr(mainmod, "_check_skill_version", lambda _: None) monkeypatch.chdir(corpus) # run from the project root, like a real user monkeypatch.setattr( mainmod.sys, "argv", ["graphify", "extract", ".", "--out", str(external)], ) try: mainmod.main() except SystemExit as exc: assert exc.code in (None, 0), f"unexpected exit code {exc.code}" out = external / "graphify-out" assert (out / "graph.json").exists(), "graph.json must land under --out" assert (out / "manifest.json").exists(), "manifest.json must land under --out" assert not (corpus / "graphify-out").exists(), ( "scanned project must not grow a graphify-out/ when --out is set" ) assert sorted(p.name for p in corpus.iterdir()) == ["auth.py"], ( "no stray files may appear in the project root" ) def test_extract_without_key_still_errors_when_docs_present( monkeypatch, tmp_path, capsys ): """Key requirement still fires when semantic work is needed. A corpus with a Markdown doc needs LLM semantic extraction, so a keyless extract must exit 1 with clear guidance (#1122). """ corpus = _make_corpus(tmp_path) # includes a Markdown doc out_dir = tmp_path / "out" _clear_backend_keys(monkeypatch) # Patch detect_backend too so ambient AWS/ollama env can't slip through. monkeypatch.setattr("graphify.llm.detect_backend", lambda: None) monkeypatch.setattr(mainmod, "_check_skill_version", lambda _: None) monkeypatch.setattr( mainmod.sys, "argv", ["graphify", "extract", str(corpus), "--out", str(out_dir)], ) with pytest.raises(SystemExit) as exc_info: mainmod.main() assert exc_info.value.code == 1 err = capsys.readouterr().err assert "no LLM API key found" in err assert "code-only corpus needs no key" in err assert not (out_dir / "graphify-out" / "graph.json").exists() def test_extract_timing_flag_emits_stage_timings(monkeypatch, tmp_path, capsys): """--timing prints per-stage `[graphify timing]` lines to stderr (#1490); omitting it prints none, so default output is unchanged. Code-only corpus => no API key.""" code = tmp_path / "code" code.mkdir() (code / "a.py").write_text("def a():\n return b()\ndef b():\n return 1\n") # with --timing monkeypatch.setattr( mainmod.sys, "argv", ["graphify", "extract", str(code), "--no-cluster", "--out", str(tmp_path / "o1"), "--timing"], ) with pytest.raises(SystemExit) as exc: mainmod.main() assert exc.value.code == 0 err = capsys.readouterr().err assert "[graphify timing] detect:" in err assert "[graphify timing] total:" in err # without --timing => no timing lines monkeypatch.setattr( mainmod.sys, "argv", ["graphify", "extract", str(code), "--no-cluster", "--out", str(tmp_path / "o2")], ) with pytest.raises(SystemExit) as exc2: mainmod.main() assert exc2.value.code == 0 assert "graphify timing" not in capsys.readouterr().err # --------------------------------------------------------------------------- # #1909: a newly-excluded file's nodes must be pruned from graph.json on the # next incremental extract even when the manifest never listed the file (the # pre-#1897 state every 0.9.16 graph is in), so the manifest-diff prune set # (`manifest - corpus`) can never see it. # --------------------------------------------------------------------------- def _two_file_corpus(tmp_path): project = tmp_path / "project" project.mkdir() (project / "x.py").write_text( "def secret_helper():\n return 42\n\n" "def secret_caller():\n return secret_helper()\n" ) (project / "keep.py").write_text( "def kept():\n return still_here()\n\n" "def still_here():\n return 1\n" ) return project def _node_sources(graph_path): import json data = json.loads(graph_path.read_text(encoding="utf-8")) return {n.get("source_file", "") for n in data.get("nodes", [])} def _run_extract(monkeypatch, argv): monkeypatch.setattr(mainmod.sys, "argv", argv) try: mainmod.main() except SystemExit as exc: assert exc.code in (None, 0), f"unexpected exit code {exc.code}" def test_incremental_extract_prunes_newly_excluded_file_not_in_manifest( monkeypatch, tmp_path ): """Seed a graph with nodes for x.py, drop x.py from the manifest (pre-#1897 manifests never listed excluded/omitted files), exclude x.py via .graphifyignore, re-run extract: x.py's nodes must be gone even though it was never on the deleted list.""" import json project = _two_file_corpus(tmp_path) out_dir = tmp_path / "out" _clear_backend_keys(monkeypatch) monkeypatch.setattr(mainmod, "_check_skill_version", lambda _: None) _run_extract( monkeypatch, ["graphify", "extract", str(project), "--out", str(out_dir)], ) graph_path = out_dir / "graphify-out" / "graph.json" manifest_path = out_dir / "graphify-out" / "manifest.json" assert any("x.py" in s for s in _node_sources(graph_path)), ( "seed extract must produce nodes for x.py" ) # Simulate the pre-#1897 manifest state: x.py was never manifest-listed, # so `manifest - corpus` can never flag it. manifest = json.loads(manifest_path.read_text(encoding="utf-8")) manifest = {k: v for k, v in manifest.items() if "x.py" not in k} manifest_path.write_text(json.dumps(manifest), encoding="utf-8") (project / ".graphifyignore").write_text("x.py\n") _run_extract( monkeypatch, ["graphify", "extract", str(project), "--out", str(out_dir)], ) sources = _node_sources(graph_path) assert not any("x.py" in s for s in sources), ( f"newly-excluded x.py must be pruned from graph.json, still see {sources}" ) assert any("keep.py" in s for s in sources), ( "unchanged keep.py nodes must survive the incremental merge" ) # x.py exists on disk, is excluded, and must not creep into the manifest. manifest = json.loads(manifest_path.read_text(encoding="utf-8")) assert not any("x.py" in k for k in manifest), ( f"excluded x.py must not be (re)listed in the manifest: {set(manifest)}" ) def test_incremental_extract_prunes_excluded_file_listed_in_manifest( monkeypatch, tmp_path ): """Post-#1897 state: the excluded file IS manifest-listed. It must be pruned from graph.json AND dropped from the manifest (#1908), and stay settled on a further run.""" import json project = _two_file_corpus(tmp_path) out_dir = tmp_path / "out" _clear_backend_keys(monkeypatch) monkeypatch.setattr(mainmod, "_check_skill_version", lambda _: None) _run_extract( monkeypatch, ["graphify", "extract", str(project), "--out", str(out_dir)], ) graph_path = out_dir / "graphify-out" / "graph.json" manifest_path = out_dir / "graphify-out" / "manifest.json" assert any("x.py" in k for k in json.loads(manifest_path.read_text())) (project / ".graphifyignore").write_text("x.py\n") _run_extract( monkeypatch, ["graphify", "extract", str(project), "--out", str(out_dir)], ) sources = _node_sources(graph_path) assert not any("x.py" in s for s in sources) assert any("keep.py" in s for s in sources) manifest = json.loads(manifest_path.read_text(encoding="utf-8")) assert not any("x.py" in k for k in manifest), ( "excluded-but-alive manifest row must be pruned (#1908)" ) # Steady state: a third run neither resurrects x.py nor loses keep.py. _run_extract( monkeypatch, ["graphify", "extract", str(project), "--out", str(out_dir)], ) sources = _node_sources(graph_path) assert not any("x.py" in s for s in sources) assert any("keep.py" in s for s in sources) def test_no_cluster_incremental_prunes_newly_excluded_file( monkeypatch, tmp_path, capsys ): """--no-cluster's exclusion-only early exit must still scrub the excluded file's nodes from the raw graph.json (that path never runs build_merge), and must not report the alive file as deleted.""" import json project = _two_file_corpus(tmp_path) out_dir = tmp_path / "out" _clear_backend_keys(monkeypatch) monkeypatch.setattr(mainmod, "_check_skill_version", lambda _: None) monkeypatch.setattr( mainmod.sys, "argv", ["graphify", "extract", str(project), "--no-cluster", "--out", str(out_dir)], ) with pytest.raises(SystemExit) as exc: mainmod.main() assert exc.value.code == 0 graph_path = out_dir / "graphify-out" / "graph.json" assert any("x.py" in s for s in _node_sources(graph_path)) capsys.readouterr() (project / ".graphifyignore").write_text("x.py\n") with pytest.raises(SystemExit) as exc: mainmod.main() assert exc.value.code == 0 out_text = capsys.readouterr().out assert "1 deleted" not in out_text, ( "excluded-but-alive file must not be reported as deleted" ) sources = _node_sources(graph_path) assert not any("x.py" in s for s in sources), ( f"--no-cluster early exit must prune excluded sources, still see {sources}" ) assert any("keep.py" in s for s in sources)