mirror of
https://github.com/safishamsi/graphify.git
synced 2026-07-12 18:37:12 +00:00
tpateeq
ad6cb753c0
`graphify install --platform agents` installs the skill to the generic Agent-Skills locations: the spec's user-global ~/.agents/skills (global) and ./.agents/skills (--project) — the directories `npx skills` and spec-compliant frameworks read. `--platform skills` is an alias. Previously that user-global location was only reachable as an accidental side effect of the gemini-on-Windows branch. Bare `graphify install` is unchanged (still single-platform claude/windows). The platform is registered in tools/skillgen/platforms.toml (split, mirroring amp's agents-md body) and rendered through the skillgen drift/coverage guards. Since it is a post-v8 platform with no own v8 body, its --audit-coverage baseline is amp's v8 body (the body it re-homes). The rendered skill body is byte-identical to amp's; only the on-demand hooks reference differs (its own `graphify agents install` wording). The `graphify agents install` / `graphify skills install` subcommand is the amp-twin: it also wires an AGENTS.md always-on section, keeping it honest with the hooks reference it points at. The `--platform agents` path stays skill-only, exactly as amp's `--platform amp` does. Also: `skill-agents.md` added to package-data, and the wheel-packaging guard now covers every platform's skill body (not just references/always-on), so a missing skill body fails CI instead of only breaking install for real users. Closes #1405. Implements #1432. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
85 lines
3.2 KiB
Python
85 lines
3.2 KiB
Python
"""Packaging guard (#1121 follow-up): the 5 skillgen guards check the *repo tree*,
|
|
not the *built wheel*. A host whose references bundle or always-on block fails to
|
|
match the `package-data` globs would pass `--check`/`--audit-coverage` yet make
|
|
`graphify install` hard-exit with "not found in package" for real users.
|
|
|
|
This builds the wheel once and asserts every committed skill artifact ships in it.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import subprocess
|
|
import sys
|
|
import zipfile
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
REPO = Path(__file__).resolve().parents[1]
|
|
PKG = REPO / "graphify"
|
|
|
|
|
|
def _has_build() -> bool:
|
|
try:
|
|
subprocess.run(
|
|
[sys.executable, "-m", "build", "--version"],
|
|
check=True, capture_output=True,
|
|
)
|
|
return True
|
|
except (subprocess.CalledProcessError, FileNotFoundError):
|
|
return False
|
|
|
|
|
|
def _skill_bodies() -> list[Path]:
|
|
"""Every distinct skill body a platform installs (the SKILL.md is copied from
|
|
one of these). A body missing from the wheel makes `graphify install
|
|
--platform <host>` hard-exit "not found in package" — the exact failure that
|
|
motivated adding the agents platform's skill-agents.md to package-data."""
|
|
from graphify.__main__ import _PLATFORM_CONFIG
|
|
|
|
names = {cfg["skill_file"] for cfg in _PLATFORM_CONFIG.values()}
|
|
return sorted({PKG / name for name in names})
|
|
|
|
|
|
def _expected_artifacts() -> list[Path]:
|
|
"""Every committed skill body + references/*.md (per host) + always_on/*.md block."""
|
|
bodies = _skill_bodies()
|
|
refs = sorted((PKG / "skills").glob("*/references/*.md"))
|
|
always = sorted((PKG / "always_on").glob("*.md"))
|
|
# Sanity: if these are empty the test wiring is broken, not the wheel.
|
|
assert bodies, "no platform skill bodies found — packaging test mis-wired"
|
|
assert refs, "no skills/*/references/*.md found in repo — packaging test mis-wired"
|
|
assert always, "no always_on/*.md found in repo — packaging test mis-wired"
|
|
return bodies + refs + always
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def wheel_namelist(tmp_path_factory) -> set[str]:
|
|
if not _has_build():
|
|
pytest.skip("`python -m build` unavailable (dev extra not installed)")
|
|
out = tmp_path_factory.mktemp("wheel")
|
|
proc = subprocess.run(
|
|
[sys.executable, "-m", "build", "--wheel", "--no-isolation",
|
|
"--outdir", str(out), str(REPO)],
|
|
capture_output=True, text=True,
|
|
)
|
|
if proc.returncode != 0:
|
|
pytest.skip(f"wheel build failed in this env:\n{proc.stderr[-800:]}")
|
|
wheels = list(out.glob("graphifyy-*.whl"))
|
|
assert wheels, "no wheel produced"
|
|
with zipfile.ZipFile(max(wheels, key=lambda p: p.stat().st_mtime)) as z:
|
|
return set(z.namelist())
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"artifact",
|
|
_expected_artifacts(),
|
|
ids=lambda p: str(p.relative_to(PKG)),
|
|
)
|
|
def test_skill_artifact_ships_in_wheel(artifact: Path, wheel_namelist: set[str]) -> None:
|
|
rel = "graphify/" + artifact.relative_to(PKG).as_posix()
|
|
assert rel in wheel_namelist, (
|
|
f"{rel} is committed in the repo but NOT in the built wheel — "
|
|
f"`graphify install` would hard-exit for this host. Check the "
|
|
f"[tool.setuptools.package-data] globs in pyproject.toml."
|
|
)
|