mirror of
https://github.com/safishamsi/graphify.git
synced 2026-07-12 18:37:12 +00:00
safishamsi
47033c8b75
_check_skill_version advised "Run 'graphify install' to update" on ANY version mismatch. But `install` writes the package's OWN bundled skill and re-stamps .graphify_version, so when the skill on disk is NEWER than the running package, following that advice silently DOWNGRADES the skill to silence the warning. The docstring even said "warn if the skill is from an OLDER version" but the code never checked direction. Compare versions numerically (new _version_tuple, so 0.10 > 0.9 and a malformed stamp degrades instead of raising). When the skill is newer than the package, recommend upgrading the package (uv tool upgrade / pip install -U) instead of install; the older-skill case is unchanged. Hit in practice by a stale `uv tool` CLI and by contributors whose dev checkout stamped a newer skill. Reported by @TPAteeq. 4 tests (numeric ordering, both mismatch directions, silent-when-equal). Full suite 2730 passed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
61 lines
2.4 KiB
Python
61 lines
2.4 KiB
Python
"""Direction-aware skill-version mismatch warning (#1568).
|
|
|
|
`_check_skill_version` used to advise `graphify install` on ANY version
|
|
mismatch. But `install` writes the package's OWN bundled skill and re-stamps
|
|
the version, so when the skill on disk is NEWER than the package, following
|
|
that advice silently DOWNGRADES the skill. These tests pin that the warning is
|
|
now direction-aware: skill-older -> recommend install; skill-newer -> recommend
|
|
upgrading the package instead.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
import graphify.__main__ as mainmod
|
|
|
|
|
|
def _make_skill(tmp_path: Path, stamped: str) -> Path:
|
|
skill_dst = tmp_path / "skills" / "graphify" / "SKILL.md"
|
|
skill_dst.parent.mkdir(parents=True, exist_ok=True)
|
|
skill_dst.write_text("# graphify skill\n", encoding="utf-8")
|
|
(skill_dst.parent / ".graphify_version").write_text(stamped, encoding="utf-8")
|
|
return skill_dst
|
|
|
|
|
|
def test_version_tuple_orders_numerically():
|
|
vt = mainmod._version_tuple
|
|
assert vt("0.9.2") > vt("0.8.27") # 9 > 8, not string-compared
|
|
assert vt("0.10.0") > vt("0.9.0") # 10 > 9
|
|
assert vt("0.9.3") == vt("0.9.3")
|
|
assert vt("1.0.0rc1") == vt("1.0.0") # pre-release suffix compares by core
|
|
assert vt("") == (0,) # malformed stamp degrades, no raise
|
|
|
|
|
|
def test_skill_older_than_package_recommends_install(tmp_path, monkeypatch, capsys):
|
|
monkeypatch.setattr(mainmod, "__version__", "0.9.3")
|
|
skill_dst = _make_skill(tmp_path, "0.8.27")
|
|
mainmod._check_skill_version(skill_dst)
|
|
err = capsys.readouterr().err
|
|
assert "Run 'graphify install' to update" in err
|
|
assert "downgrade" not in err
|
|
|
|
|
|
def test_skill_newer_than_package_recommends_upgrade_not_install(tmp_path, monkeypatch, capsys):
|
|
monkeypatch.setattr(mainmod, "__version__", "0.8.27")
|
|
skill_dst = _make_skill(tmp_path, "0.9.2")
|
|
mainmod._check_skill_version(skill_dst)
|
|
err = capsys.readouterr().err
|
|
# must NOT tell the user to run install (that would downgrade the skill)
|
|
assert "Run 'graphify install' to update" not in err
|
|
assert "downgrade" in err
|
|
assert "upgrade" in err.lower()
|
|
|
|
|
|
def test_matching_version_is_silent(tmp_path, monkeypatch, capsys):
|
|
monkeypatch.setattr(mainmod, "__version__", "0.9.3")
|
|
skill_dst = _make_skill(tmp_path, "0.9.3")
|
|
mainmod._check_skill_version(skill_dst)
|
|
assert capsys.readouterr().err == ""
|