mirror of
https://github.com/safishamsi/graphify.git
synced 2026-07-13 02:47:00 +00:00
Safi
5cc7ec8a23
The Bash search hook only nudges grep/rg/find, so an agent that answers a codebase question by Read-ing many source files one by one (the most common way the graph gets skipped) slips right past it (#1114). Add _READ_SETTINGS_HOOK matching Read|Glob: it fires only when graphify-out/graph.json exists, only for a source/doc file outside graphify-out/, injects the same query-first additionalContext, and never blocks (every branch fails open). Install and uninstall now register and dedup both hooks idempotently. Implemented independently rather than merging the community PR #1120; same idea, our own hook (Read/Glob only, no fragile multi-file cat/head/tail heuristic). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
81 lines
2.9 KiB
Python
81 lines
2.9 KiB
Python
"""The Read|Glob PreToolUse hook nudges toward the graph instead of raw reads.
|
|
|
|
Closes the issue #1114 gap: the Bash search hook never sees a file read through
|
|
the native Read tool or a Glob. These tests run the hook command the way Claude
|
|
Code does - via `sh -c` with crafted stdin JSON - and assert it nudges only for
|
|
a source/doc file outside graphify-out/ when a graph exists, and otherwise stays
|
|
silent and fails open.
|
|
"""
|
|
import json
|
|
import subprocess
|
|
|
|
from graphify.__main__ import _READ_SETTINGS_HOOK
|
|
|
|
CMD = _READ_SETTINGS_HOOK["hooks"][0]["command"]
|
|
|
|
|
|
def _run(tool_input, cwd, *, graph: bool):
|
|
if graph:
|
|
(cwd / "graphify-out").mkdir(parents=True, exist_ok=True)
|
|
(cwd / "graphify-out" / "graph.json").write_text("{}", encoding="utf-8")
|
|
stdin = json.dumps({"tool_input": tool_input})
|
|
return subprocess.run(
|
|
["sh", "-c", CMD], input=stdin, capture_output=True, text=True, cwd=cwd
|
|
)
|
|
|
|
|
|
def test_matcher_targets_read_and_glob():
|
|
assert _READ_SETTINGS_HOOK["matcher"] == "Read|Glob"
|
|
|
|
|
|
def test_silent_without_graph(tmp_path):
|
|
out = _run({"file_path": "src/app.py"}, tmp_path, graph=False).stdout
|
|
assert out.strip() == ""
|
|
|
|
|
|
def test_nudges_on_source_read_with_graph(tmp_path):
|
|
out = _run({"file_path": "src/app.py"}, tmp_path, graph=True).stdout
|
|
assert "graphify query" in out
|
|
|
|
|
|
def test_nudge_payload_is_valid_pretooluse_json(tmp_path):
|
|
out = _run({"file_path": "pkg/mod.ts"}, tmp_path, graph=True).stdout
|
|
payload = json.loads(out)
|
|
assert payload["hookSpecificOutput"]["hookEventName"] == "PreToolUse"
|
|
assert "graphify query" in payload["hookSpecificOutput"]["additionalContext"]
|
|
|
|
|
|
def test_silent_on_graphify_out_targets(tmp_path):
|
|
"""Reading the graph's own report must not start a go-read-the-graph loop."""
|
|
out = _run({"file_path": "graphify-out/GRAPH_REPORT.md"}, tmp_path, graph=True).stdout
|
|
assert out.strip() == ""
|
|
|
|
|
|
def test_silent_on_non_source_files(tmp_path):
|
|
for path in ("uv.lock", "logo.png", "data.bin", ".gitignore"):
|
|
out = _run({"file_path": path}, tmp_path, graph=True).stdout
|
|
assert out.strip() == "", f"{path} should not nudge"
|
|
|
|
|
|
def test_glob_pattern_nudges(tmp_path):
|
|
out = _run({"pattern": "**/*.py", "path": "src"}, tmp_path, graph=True).stdout
|
|
assert "graphify query" in out
|
|
|
|
|
|
def test_fails_open_on_malformed_stdin(tmp_path):
|
|
(tmp_path / "graphify-out").mkdir()
|
|
(tmp_path / "graphify-out" / "graph.json").write_text("{}", encoding="utf-8")
|
|
r = subprocess.run(
|
|
["sh", "-c", CMD], input="this is not json", capture_output=True, text=True, cwd=tmp_path
|
|
)
|
|
assert r.returncode == 0
|
|
assert r.stdout.strip() == ""
|
|
|
|
|
|
def test_never_blocks(tmp_path):
|
|
"""A nudge is additionalContext only - the hook must exit 0, never deny."""
|
|
r = _run({"file_path": "src/app.py"}, tmp_path, graph=True)
|
|
assert r.returncode == 0
|
|
assert '"permissionDecision"' not in r.stdout
|
|
assert '"deny"' not in r.stdout
|