mirror of
https://github.com/safishamsi/graphify.git
synced 2026-07-15 03:47:05 +00:00
5d63aad596
to_obsidian / to_canvas / to_wiki keyed filename dedup on the exact-case name, so two labels differing only by case (e.g. `References` vs `references`) counted as non-colliding and the second write clobbered the first on case-insensitive filesystems (macOS/APFS, Windows/NTFS) — silently, no suffix, no warning. Dedup now folds case (keyed on the lowercased name) while emitting the original-case filename, so any pair that would collide on disk gets a numeric suffix. The obsidian/canvas dedup is one shared helper (`_dedup_node_filenames`) so they can't drift; wiki's slug dedup gets the matching fix; the `_COMMUNITY_*` overview notes (which had no dedup at all) are covered; and a generated `base_1` is re-checked so it can't overwrite a node literally labelled `base_1`. Ported from PR #1457 by @TPAteeq onto current v8. Verified with a rigorous edge-case battery (case-only collision, base_1 literal re-check -> base_1_1, community-label case fold, determinism) plus the PR's tests; full suite 2404 passed, ruff + skillgen clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
251 lines
11 KiB
Python
251 lines
11 KiB
Python
"""Tests for graphify.wiki — Wikipedia-style article generation."""
|
|
import pytest
|
|
from pathlib import Path
|
|
import networkx as nx
|
|
from graphify.wiki import to_wiki, _index_md, _community_article, _god_node_article
|
|
|
|
|
|
def _make_graph():
|
|
G = nx.Graph()
|
|
G.add_node("n1", label="parse", file_type="code", source_file="parser.py", community=0)
|
|
G.add_node("n2", label="validate", file_type="code", source_file="parser.py", community=0)
|
|
G.add_node("n3", label="render", file_type="code", source_file="renderer.py", community=1)
|
|
G.add_node("n4", label="stream", file_type="code", source_file="renderer.py", community=1)
|
|
G.add_edge("n1", "n2", relation="calls", confidence="EXTRACTED", weight=1.0)
|
|
G.add_edge("n1", "n3", relation="references", confidence="INFERRED", weight=1.0)
|
|
G.add_edge("n3", "n4", relation="calls", confidence="EXTRACTED", weight=1.0)
|
|
return G
|
|
|
|
|
|
COMMUNITIES = {0: ["n1", "n2"], 1: ["n3", "n4"]}
|
|
LABELS = {0: "Parsing Layer", 1: "Rendering Layer"}
|
|
COHESION = {0: 0.85, 1: 0.72}
|
|
GOD_NODES = [{"id": "n1", "label": "parse", "degree": 2}]
|
|
|
|
|
|
def test_to_wiki_writes_index(tmp_path):
|
|
G = _make_graph()
|
|
n = to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS, cohesion=COHESION, god_nodes_data=GOD_NODES)
|
|
assert (tmp_path / "index.md").exists()
|
|
|
|
|
|
def test_to_wiki_returns_article_count(tmp_path):
|
|
G = _make_graph()
|
|
# 2 communities + 1 god node = 3
|
|
n = to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS, cohesion=COHESION, god_nodes_data=GOD_NODES)
|
|
assert n == 3
|
|
|
|
|
|
def test_to_wiki_community_articles_created(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS)
|
|
assert (tmp_path / "Parsing_Layer.md").exists()
|
|
assert (tmp_path / "Rendering_Layer.md").exists()
|
|
|
|
|
|
def test_to_wiki_god_node_article_created(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS, god_nodes_data=GOD_NODES)
|
|
assert (tmp_path / "parse.md").exists()
|
|
|
|
|
|
def test_index_links_all_communities(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS)
|
|
index = (tmp_path / "index.md").read_text()
|
|
assert "[[Parsing Layer]]" in index
|
|
assert "[[Rendering Layer]]" in index
|
|
|
|
|
|
def test_index_lists_god_nodes(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS, god_nodes_data=GOD_NODES)
|
|
index = (tmp_path / "index.md").read_text()
|
|
assert "[[parse]]" in index
|
|
assert "2 connections" in index
|
|
|
|
|
|
def test_community_article_has_cross_links(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS)
|
|
parsing = (tmp_path / "Parsing_Layer.md").read_text()
|
|
# n1 (parsing) references n3 (rendering) → cross-community link
|
|
assert "[[Rendering Layer]]" in parsing
|
|
|
|
|
|
def test_community_article_shows_cohesion(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS, cohesion=COHESION)
|
|
parsing = (tmp_path / "Parsing_Layer.md").read_text()
|
|
assert "cohesion 0.85" in parsing
|
|
|
|
|
|
def test_community_article_has_audit_trail(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS)
|
|
parsing = (tmp_path / "Parsing_Layer.md").read_text()
|
|
assert "EXTRACTED" in parsing
|
|
assert "INFERRED" in parsing
|
|
|
|
|
|
def test_god_node_article_has_connections(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS, god_nodes_data=GOD_NODES)
|
|
article = (tmp_path / "parse.md").read_text()
|
|
assert "[[validate]]" in article or "[[render]]" in article
|
|
|
|
|
|
def test_god_node_article_links_community(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS, god_nodes_data=GOD_NODES)
|
|
article = (tmp_path / "parse.md").read_text()
|
|
assert "[[Parsing Layer]]" in article
|
|
|
|
|
|
def test_to_wiki_skips_missing_god_node_ids(tmp_path):
|
|
"""God node with bad ID should not crash."""
|
|
G = _make_graph()
|
|
bad_gods = [{"id": "nonexistent", "label": "ghost", "degree": 99}]
|
|
n = to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS, god_nodes_data=bad_gods)
|
|
# 2 communities + 0 god nodes (nonexistent skipped) = 2
|
|
assert n == 2
|
|
|
|
|
|
def test_to_wiki_no_labels_uses_fallback(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path) # no labels
|
|
assert (tmp_path / "Community_0.md").exists()
|
|
assert (tmp_path / "Community_1.md").exists()
|
|
|
|
|
|
def test_article_navigation_footer(tmp_path):
|
|
G = _make_graph()
|
|
to_wiki(G, COMMUNITIES, tmp_path, community_labels=LABELS)
|
|
article = (tmp_path / "Parsing_Layer.md").read_text()
|
|
assert "[[index]]" in article
|
|
|
|
|
|
def test_community_article_truncation_notice(tmp_path):
|
|
"""Communities with more than 25 nodes show a truncation notice."""
|
|
G = nx.Graph()
|
|
nodes = [f"n{i}" for i in range(30)]
|
|
for nid in nodes:
|
|
G.add_node(nid, label=f"concept_{nid}", file_type="code", source_file="a.py", community=0)
|
|
for i in range(len(nodes) - 1):
|
|
G.add_edge(nodes[i], nodes[i + 1], relation="calls", confidence="EXTRACTED", weight=1.0)
|
|
communities = {0: nodes}
|
|
to_wiki(G, communities, tmp_path, community_labels={0: "Big Community"})
|
|
article = (tmp_path / "Big_Community.md").read_text()
|
|
assert "and 5 more nodes" in article
|
|
|
|
|
|
# Regression tests for #925 - cross-community links always empty when node attrs lack community
|
|
def test_cross_community_links_without_node_community_attrs(tmp_path):
|
|
"""Cross-community links must work even when nodes have no 'community' attribute (#925)."""
|
|
G = nx.Graph()
|
|
G.add_node("n1", label="parse", file_type="code", source_file="parser.py")
|
|
G.add_node("n2", label="render", file_type="code", source_file="renderer.py")
|
|
G.add_edge("n1", "n2", relation="references", confidence="INFERRED", weight=1.0)
|
|
communities = {0: ["n1"], 1: ["n2"]}
|
|
labels = {0: "Parsing", 1: "Rendering"}
|
|
to_wiki(G, communities, tmp_path, community_labels=labels)
|
|
article = (tmp_path / "Parsing.md").read_text()
|
|
assert "[[Rendering]]" in article
|
|
|
|
|
|
def test_god_node_article_community_without_node_attr(tmp_path):
|
|
"""God node article must show community name even when node has no 'community' attr (#925)."""
|
|
G = nx.Graph()
|
|
G.add_node("n1", label="parse", file_type="code", source_file="parser.py")
|
|
G.add_node("n2", label="validate", file_type="code", source_file="parser.py")
|
|
G.add_edge("n1", "n2", relation="calls", confidence="EXTRACTED", weight=1.0)
|
|
communities = {0: ["n1", "n2"]}
|
|
labels = {0: "Core Logic"}
|
|
god_nodes = [{"id": "n1", "label": "parse", "degree": 1}]
|
|
to_wiki(G, communities, tmp_path, community_labels=labels, god_nodes_data=god_nodes)
|
|
article = (tmp_path / "parse.md").read_text()
|
|
assert "[[Core Logic]]" in article
|
|
|
|
|
|
# Regression tests for #936 - stale community node IDs crash to_wiki after dedup/re-extract
|
|
|
|
def test_to_wiki_drops_stale_community_nodes(tmp_path):
|
|
"""Stale node IDs in communities dict are silently dropped without crash (#936)."""
|
|
G = _make_graph()
|
|
# Add a stale ID that exists in communities but not in G
|
|
communities = {0: ["n1", "n2", "stale_ghost"], 1: ["n3", "n4"]}
|
|
n = to_wiki(G, communities, tmp_path, community_labels=LABELS)
|
|
assert n == 2 # both community articles still written
|
|
article = (tmp_path / "Parsing_Layer.md").read_text()
|
|
assert "parse" in article
|
|
assert "stale_ghost" not in article
|
|
|
|
|
|
def test_to_wiki_all_stale_raises(tmp_path):
|
|
"""If every community node is stale, raise ValueError with a helpful message (#936)."""
|
|
G = _make_graph()
|
|
all_stale = {0: ["ghost1", "ghost2"], 1: ["ghost3"]}
|
|
with pytest.raises(ValueError, match="stale"):
|
|
to_wiki(G, all_stale, tmp_path, community_labels=LABELS)
|
|
|
|
|
|
def test_to_wiki_stale_nodes_prints_warning(tmp_path, capsys):
|
|
"""Stale node IDs trigger a stderr warning showing the drop count (#936)."""
|
|
G = _make_graph()
|
|
communities = {0: ["n1", "stale1", "stale2"], 1: ["n3", "n4"]}
|
|
to_wiki(G, communities, tmp_path, community_labels=LABELS)
|
|
err = capsys.readouterr().err
|
|
assert "2" in err # dropped count
|
|
assert "stale" in err.lower()
|
|
|
|
|
|
def test_community_article_handles_null_source_file(tmp_path):
|
|
"""source_file=None on a node must not crash sorted() with TypeError (#1016)."""
|
|
G = nx.Graph()
|
|
G.add_node("n1", label="parse", file_type="code", source_file=None, community=0)
|
|
G.add_node("n2", label="validate", file_type="code", source_file="parser.py", community=0)
|
|
G.add_edge("n1", "n2", relation="calls", confidence="EXTRACTED", weight=1.0)
|
|
communities = {0: ["n1", "n2"]}
|
|
labels = {0: "Parsing Layer"}
|
|
# Must not raise TypeError
|
|
to_wiki(G, communities, tmp_path, community_labels=labels)
|
|
assert (tmp_path / "index.md").exists()
|
|
|
|
|
|
def test_to_wiki_case_only_distinct_labels_dont_overwrite(tmp_path):
|
|
"""Two community labels differing only by case must each get their own
|
|
article. The slug-dedup set folds case, so on case-insensitive filesystems
|
|
(macOS/APFS, Windows/NTFS) the second article gets a numeric suffix instead
|
|
of silently overwriting the first."""
|
|
G = nx.Graph()
|
|
G.add_node("n1", label="parse", file_type="code", source_file="a.py", community=0)
|
|
G.add_node("n2", label="render", file_type="code", source_file="b.py", community=1)
|
|
G.add_edge("n1", "n2", relation="calls", confidence="EXTRACTED", weight=1.0)
|
|
communities = {0: ["n1"], 1: ["n2"]}
|
|
labels = {0: "Parser", 1: "parser"}
|
|
n = to_wiki(G, communities, tmp_path, community_labels=labels)
|
|
articles = [p for p in tmp_path.glob("*.md") if p.name != "index.md"]
|
|
# both communities survive as separate files on disk (no silent overwrite)
|
|
assert len(articles) == n == 2, [p.name for p in articles]
|
|
# filenames are distinct even when compared case-insensitively
|
|
lowered = [p.stem.lower() for p in articles]
|
|
assert len(set(lowered)) == len(lowered), [p.name for p in articles]
|
|
|
|
|
|
def test_to_wiki_god_node_label_case_collides_with_community(tmp_path):
|
|
"""Community and god-node articles share one slug-dedup set, so a god-node
|
|
label differing only by case from a community label must still get its own
|
|
file rather than overwriting the community article."""
|
|
G = nx.Graph()
|
|
G.add_node("n1", label="parse", file_type="code", source_file="a.py", community=0)
|
|
G.add_node("n2", label="run", file_type="code", source_file="b.py", community=0)
|
|
G.add_edge("n1", "n2", relation="calls", confidence="EXTRACTED", weight=1.0)
|
|
communities = {0: ["n1", "n2"]}
|
|
labels = {0: "Parser"}
|
|
god_nodes = [{"id": "n1", "label": "parser", "degree": 1}]
|
|
n = to_wiki(G, communities, tmp_path, community_labels=labels, god_nodes_data=god_nodes)
|
|
articles = [p for p in tmp_path.glob("*.md") if p.name != "index.md"]
|
|
assert len(articles) == n == 2, [p.name for p in articles]
|
|
lowered = [p.stem.lower() for p in articles]
|
|
assert len(set(lowered)) == len(lowered), [p.name for p in articles]
|