mirror of
https://github.com/safishamsi/graphify.git
synced 2026-10-20 02:41:13 +00:00
berce
60cfd51b7d
A closure passed in a module-level call statement is walked under the file node (#3124), but its params and locals were never registered for that walk. A parameter passed on as a call argument then resolved against the corpus-wide label index and produced an indirect_call to any function with the same name, including module-private ones in other packages. Record the closure's bindings in closure_locals_by_body, the same way the #2568 branch already does for const-assigned closures.
73 lines
2.9 KiB
Python
73 lines
2.9 KiB
Python
"""A parameter of a file-scope anonymous callback must shadow same-named
|
|
functions elsewhere in the corpus (#4448).
|
|
|
|
#3124 walks the body of a closure passed in a module-level call statement
|
|
(`items.forEach(function (value) { ... })`, AngularJS `.controller(...)`,
|
|
`it("...", () => { ... })`) under the file node, but did not register the
|
|
closure's own params/locals for that walk. A parameter passed on as a call
|
|
argument was then resolved against the corpus-wide label index and became an
|
|
`indirect_call` from the file to any function named like it. Inside a named
|
|
function the same code was already handled (#2241, #2568).
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from graphify.extract import extract
|
|
|
|
_TARGET = {"b.js": "function value(x) { return x; }\n"}
|
|
|
|
|
|
def _indirect(tmp_path, a_js: str):
|
|
files = {"a.js": a_js, **_TARGET}
|
|
for name, body in files.items():
|
|
(tmp_path / name).write_text(body)
|
|
r = extract([tmp_path / n for n in files],
|
|
cache_root=tmp_path / "graphify-out", parallel=False)
|
|
lbl = {n["id"]: n["label"] for n in r["nodes"]}
|
|
return {(lbl.get(e["source"]), lbl.get(e["target"])) for e in r["edges"]
|
|
if e["relation"] == "indirect_call"}
|
|
|
|
|
|
def test_callback_param_passed_to_a_member_call_is_not_a_reference(tmp_path):
|
|
assert _indirect(tmp_path, "items.forEach(function (value) { s.on(value); });\n") == set()
|
|
|
|
|
|
def test_callback_param_passed_to_a_bare_call_is_not_a_reference(tmp_path):
|
|
assert _indirect(tmp_path, "items.forEach(function (value) { emit(value); });\n") == set()
|
|
|
|
|
|
def test_param_of_a_nested_file_scope_callback_is_not_a_reference(tmp_path):
|
|
src = "m.c(function (s) { items.forEach(function (value) { s.on(value); }); });\n"
|
|
assert _indirect(tmp_path, src) == set()
|
|
|
|
|
|
def test_arrow_callback_params_are_not_references(tmp_path):
|
|
src = "items.forEach((value) => emit(value));\nitems.map(value => emit(value));\n"
|
|
assert _indirect(tmp_path, src) == set()
|
|
|
|
|
|
def test_callback_var_is_not_a_reference(tmp_path):
|
|
src = "items.forEach(function () { var value = 1; emit(value); });\n"
|
|
assert _indirect(tmp_path, src) == set()
|
|
|
|
|
|
def test_unbound_name_inside_a_file_scope_callback_still_resolves(tmp_path):
|
|
assert _indirect(tmp_path, "items.forEach(function (x) { emit(value); });\n") == {("a.js", "value()")}
|
|
|
|
|
|
def test_a_sibling_callbacks_param_does_not_shadow(tmp_path):
|
|
src = "m.c(function (value) { emit(1); }, function () { emit(value); });\n"
|
|
assert _indirect(tmp_path, src) == {("a.js", "value()")}
|
|
|
|
|
|
def test_param_of_a_callback_inside_a_test_block_is_not_a_reference(tmp_path):
|
|
# The inner arrow is itself an expression statement inside the `it`
|
|
# callback, so the #3124 branch tracks it as its own body too.
|
|
src = (
|
|
"describe('d', () => {\n"
|
|
" it('t', async () => {\n"
|
|
" intercept((value) => respond(value, 1));\n"
|
|
" });\n"
|
|
"});\n"
|
|
)
|
|
assert _indirect(tmp_path, src) == set()
|