mirror of
https://github.com/safishamsi/graphify.git
synced 2026-10-15 00:19:33 +00:00
Mpasha17
672441393e
A type hint like `w: Widget` before `class Widget` in widget.py minted a
bare 'widget' stub, which collides with the file node id once paths are made
relative, so the file node vanished and Widget ended up containing itself.
Point that reference at the local class id instead.
Co-Authored-By: Grok Bot
(cherry picked from commit c25d1626e9)
55 lines
1.7 KiB
Python
55 lines
1.7 KiB
Python
"""#4334: a forward-referenced class named after its file must not swallow the file node."""
|
|
from pathlib import Path
|
|
|
|
from graphify.extract import extract
|
|
|
|
WIDGET = """from __future__ import annotations
|
|
|
|
class Helper:
|
|
def make(self, w: Widget) -> None:
|
|
w.draw()
|
|
|
|
class Widget:
|
|
def draw(self):
|
|
return 1
|
|
"""
|
|
|
|
APP = """from widget import Widget
|
|
|
|
def use(w: Widget):
|
|
w.draw()
|
|
"""
|
|
|
|
|
|
def _extract(tmp_path: Path, files: dict[str, str]):
|
|
paths = []
|
|
for name, src in files.items():
|
|
p = tmp_path / name
|
|
p.write_text(src)
|
|
paths.append(p)
|
|
result = extract(paths, cache_root=tmp_path, root=tmp_path, parallel=False)
|
|
labels = {n["id"]: n["label"] for n in result["nodes"]}
|
|
edges = {(labels.get(e["source"]), e["relation"], labels.get(e["target"])) for e in result["edges"]}
|
|
return result, labels, edges
|
|
|
|
|
|
def _check(result, labels, edges):
|
|
file_nodes = [n for n in result["nodes"] if n["label"] == "widget.py"]
|
|
assert len(file_nodes) == 1, labels
|
|
assert ("widget.py", "contains", "Widget") in edges
|
|
assert ("widget.py", "contains", "Helper") in edges
|
|
assert ("Widget", "contains", "Widget") not in edges
|
|
assert ("Widget", "contains", "Helper") not in edges
|
|
assert (".make()", "calls", ".draw()") in edges
|
|
|
|
|
|
def test_forward_ref_keeps_file_node_single_file(tmp_path):
|
|
_check(*_extract(tmp_path, {"widget.py": WIDGET}))
|
|
|
|
|
|
def test_forward_ref_keeps_file_node_with_importer(tmp_path):
|
|
result, labels, edges = _extract(tmp_path, {"widget.py": WIDGET, "app.py": APP})
|
|
_check(result, labels, edges)
|
|
assert ("app.py", "imports_from", "widget.py") in edges
|
|
assert ("app.py", "imports_from", "Widget") not in edges
|