mirror of
https://github.com/safishamsi/graphify.git
synced 2026-07-24 16:21:31 +00:00
safishamsi
1f4e3b2fe1
Part 2: `god_nodes` was an analyzer, an MCP tool, and a README-advertised capability, but `graphify god_nodes` errored with "unknown command". Add a read-only `god-nodes`/`god_nodes` subcommand mirroring `affected` (--graph, --top, --json), routing labels through sanitize_label. Part 3: `--output DIR` on `extract` was silently dropped (output fell back to the default dir). It is now an alias of `--out` (both space and =forms), matching what `graphify tree` already documents. Help/usage text updated. Part 1 (affected/reverse-dep import-id mismatch) is deferred — a build-time id-resolution change, tracked separately.
77 lines
2.9 KiB
Python
77 lines
2.9 KiB
Python
"""`graphify god-nodes` CLI subcommand (#2004 part 2).
|
|
|
|
god_nodes has long been an analyzer + MCP tool + README-advertised capability
|
|
but was never wired as a CLI subcommand, so `graphify god_nodes` errored with
|
|
"unknown command". These tests pin the subcommand (both spellings), its flags,
|
|
and that file nodes are excluded from the ranking.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
|
|
import networkx as nx
|
|
import pytest
|
|
from networkx.readwrite import json_graph
|
|
|
|
import graphify.__main__ as mainmod
|
|
|
|
|
|
def _write_graph(tmp_path):
|
|
g = nx.DiGraph()
|
|
# A high-degree real entity (not a file/concept node): label != basename.
|
|
g.add_node("hub", label="Auth", file_type="code", source_file="auth.py", source_location="L1")
|
|
g.add_node("f", label="auth.py", file_type="code", source_file="auth.py", source_location=None)
|
|
for i in range(4):
|
|
g.add_node(f"caller{i}", label=f"c{i}()", file_type="code", source_file=f"m{i}.py", source_location="L1")
|
|
g.add_edge(f"caller{i}", "hub", relation="calls", confidence="EXTRACTED")
|
|
g.add_edge("f", "hub", relation="contains", confidence="EXTRACTED")
|
|
gp = tmp_path / "graph.json"
|
|
gp.write_text(json.dumps(json_graph.node_link_data(g, edges="links")), encoding="utf-8")
|
|
return gp
|
|
|
|
|
|
def _run(monkeypatch, argv):
|
|
monkeypatch.setattr(mainmod, "_check_skill_version", lambda _: None)
|
|
monkeypatch.setattr(mainmod.sys, "argv", argv)
|
|
mainmod.main()
|
|
|
|
|
|
def test_god_nodes_cli_text_output(monkeypatch, tmp_path, capsys):
|
|
gp = _write_graph(tmp_path)
|
|
_run(monkeypatch, ["graphify", "god-nodes", "--graph", str(gp)])
|
|
out = capsys.readouterr().out
|
|
assert "God nodes (most connected):" in out
|
|
assert "Auth" in out
|
|
assert "edges" in out
|
|
assert "auth.py" not in out # file node excluded from the ranking
|
|
|
|
|
|
def test_god_nodes_cli_underscore_alias(monkeypatch, tmp_path, capsys):
|
|
# The exact spelling from the issue title.
|
|
gp = _write_graph(tmp_path)
|
|
_run(monkeypatch, ["graphify", "god_nodes", "--graph", str(gp)])
|
|
assert "Auth" in capsys.readouterr().out
|
|
|
|
|
|
def test_god_nodes_cli_top_limits(monkeypatch, tmp_path, capsys):
|
|
gp = _write_graph(tmp_path)
|
|
_run(monkeypatch, ["graphify", "god-nodes", "--graph", str(gp), "--top", "1"])
|
|
body = capsys.readouterr().out
|
|
assert body.count(" edges") == 1
|
|
|
|
|
|
def test_god_nodes_cli_json(monkeypatch, tmp_path, capsys):
|
|
gp = _write_graph(tmp_path)
|
|
_run(monkeypatch, ["graphify", "god-nodes", "--graph", str(gp), "--json"])
|
|
data = json.loads(capsys.readouterr().out)
|
|
assert isinstance(data, list) and data
|
|
assert {"id", "label", "degree"} <= set(data[0])
|
|
assert data[0]["label"] == "Auth"
|
|
|
|
|
|
def test_god_nodes_cli_missing_graph_errors(monkeypatch, tmp_path, capsys):
|
|
with pytest.raises(SystemExit) as exc:
|
|
_run(monkeypatch, ["graphify", "god-nodes", "--graph", str(tmp_path / "nope.json")])
|
|
assert exc.value.code == 1
|
|
assert "graph file not found" in capsys.readouterr().err
|