mirror of
https://github.com/safishamsi/graphify.git
synced 2026-07-11 18:07:31 +00:00
safishamsi
1288a557e3
krishnateja7 reported that on a full-repo run a stable subset of Ruby files yields zero nodes (not even a file node), each fine in isolation, drop set byte-stable across runs. Root cause is a transient batch/parallel extraction that produces an empty result, which then gets cached and persists. Every extractable file yields at least a file node, so a zero-node result is anomalous. Both extraction paths (parallel worker and sequential fallback) now skip the cache write when a non-error result has no nodes, so a rerun re-extracts and self-heals instead of loading the stale empty. extract() also warns, listing the files that landed in the graph with zero nodes, so the previously-silent blindness in affected/explain is visible. This addresses the persistence and the silent blindness. The underlying trigger (why a valid file occasionally extracts empty when co-processed with certain others) was not reproducible with synthetic corpora; the warning now surfaces it for a concrete report if it recurs. Full suite: 2912 passed, 3 skipped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
55 lines
2.1 KiB
Python
55 lines
2.1 KiB
Python
"""#1666 — an extractable source file that yields zero nodes must not be cached,
|
|
and must be surfaced.
|
|
|
|
Every supported file produces at least a file node, so a zero-node result is
|
|
anomalous (a transient batch/parallel hiccup). Caching it made the empty
|
|
byte-stable across runs and silently blinded affected/explain to the file. We
|
|
now skip the cache write for a zero-node result (so a rerun self-heals) and warn.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import graphify.extract as ex
|
|
|
|
|
|
def test_zero_node_result_not_cached_then_self_heals(tmp_path, capsys, monkeypatch):
|
|
f = tmp_path / "thing.rb"
|
|
f.write_text("class Foo\n def bar; end\nend\n")
|
|
|
|
real = ex._safe_extract_with_xaml_root
|
|
|
|
def _empty(extractor, path, root):
|
|
return {"nodes": [], "edges": []}
|
|
|
|
# First run: force a zero-node extraction for this file.
|
|
monkeypatch.setattr(ex, "_safe_extract_with_xaml_root", _empty)
|
|
ex.extract([f], cache_root=tmp_path / "out", parallel=False)
|
|
|
|
err = capsys.readouterr().err
|
|
assert "zero nodes" in err and "thing.rb" in err, err
|
|
|
|
# Second run with the real extractor: because the empty was NOT cached, the
|
|
# file re-extracts and lands in the graph (self-heal).
|
|
monkeypatch.setattr(ex, "_safe_extract_with_xaml_root", real)
|
|
r2 = ex.extract([f], cache_root=tmp_path / "out", parallel=False)
|
|
assert any(str(n.get("source_file", "")).endswith("thing.rb") for n in r2["nodes"])
|
|
|
|
|
|
def test_normal_file_still_cached(tmp_path):
|
|
# Guard against over-correction: a normal (non-empty) result must still cache.
|
|
f = tmp_path / "ok.rb"
|
|
f.write_text("class Bar\n def baz; end\nend\n")
|
|
r1 = ex.extract([f], cache_root=tmp_path / "out", parallel=False)
|
|
assert r1["nodes"]
|
|
from graphify.cache import load_cached
|
|
assert load_cached(f, tmp_path / "out") is not None, "non-empty result should be cached"
|
|
|
|
|
|
def test_no_warning_when_all_files_produce_nodes(tmp_path, capsys):
|
|
f = tmp_path / "fine.rb"
|
|
f.write_text("module M\n def self.go; end\nend\n")
|
|
ex.extract([f], cache_root=tmp_path / "out", parallel=False)
|
|
err = capsys.readouterr().err
|
|
assert "zero nodes" not in err
|