From c8962a4e67037f009bb6dcc1fec1f20684d9e45b Mon Sep 17 00:00:00 2001 From: Alexander Shaduri Date: Wed, 17 May 2017 17:10:57 +0000 Subject: [PATCH] Fix Info Identity tab to look like the gtk2 version. --- gsmartcontrol/src/gsc_info_window.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gsmartcontrol/src/gsc_info_window.cpp b/gsmartcontrol/src/gsc_info_window.cpp index 9ae5585..c212ee2 100644 --- a/gsmartcontrol/src/gsc_info_window.cpp +++ b/gsmartcontrol/src/gsc_info_window.cpp @@ -404,15 +404,19 @@ void GscInfoWindow::fill_ui_with_info(bool scan, bool clear_ui, bool clear_tests identity_table->hide(); StorageProperty::warning_t max_warning = StorageProperty::warning_none; - int row = 1; // row 0 is always empty. this way it's much easier. + int row = 0; for (prop_iterator iter = id_props.begin(); iter != id_props.end(); ++iter) { if (!iter->show_in_ui) { continue; // hide debug messages from smartctl } - if (iter->generic_name == "overall_health") // a little distance for this one + if (iter->generic_name == "overall_health") { // a little distance for this one + Gtk::Label* empty_label = Gtk::manage(new Gtk::Label()); + empty_label->set_can_focus(false); + identity_table->attach(*empty_label, 0, row, 2, 1); ++row; + } Gtk::Label* name = Gtk::manage(new Gtk::Label()); // name->set_ellipsize(Pango::ELLIPSIZE_END); @@ -437,7 +441,6 @@ void GscInfoWindow::fill_ui_with_info(bool scan, bool clear_ui, bool clear_tests value->set_markup(""+ value->get_label() + ""); } -// identity_table->insert_row(row); identity_table->attach(*name, 0, row, 1, 1); identity_table->attach(*value, 1, row, 1, 1); @@ -451,8 +454,6 @@ void GscInfoWindow::fill_ui_with_info(bool scan, bool clear_ui, bool clear_tests ++row; } - identity_table->insert_row(row+1); // add one more row for symmetry - identity_table->show_all(); // tab label @@ -1117,7 +1118,6 @@ void GscInfoWindow::clear_ui_info(bool clear_tests_too) for (std::vector::iterator iter = children.begin(); iter != children.end(); ++iter) { identity_table->remove(*(*iter)); } - // identity_table->remove_row(1); // row 0 is always empty, so it clears it. (0, 0) is prohibited. } // tab label