From 0fe8463e81d13c658b68da29bddc18efd1f589cd Mon Sep 17 00:00:00 2001
From: Tim Hennekey <thennekey@hubspot.com>
Date: Wed, 15 Jan 2020 13:04:09 -0500
Subject: [PATCH] Remove AtomicInteger loop counter

This test isn't multithreaded so I see no need for this
---
 .../util/ObjectIdentityBdbManualCacheTest.java      | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/commons/src/test/java/org/archive/util/ObjectIdentityBdbManualCacheTest.java b/commons/src/test/java/org/archive/util/ObjectIdentityBdbManualCacheTest.java
index 1a688616..2873be5c 100644
--- a/commons/src/test/java/org/archive/util/ObjectIdentityBdbManualCacheTest.java
+++ b/commons/src/test/java/org/archive/util/ObjectIdentityBdbManualCacheTest.java
@@ -61,7 +61,6 @@ public class ObjectIdentityBdbManualCacheTest extends TmpDirTestCase {
                     IdentityCacheableWrapper.class,
                     env.getClassCatalog());
         try {
-            final AtomicInteger level = new AtomicInteger(0);
             final int keyCount = 128 * 1024; // 128K  keys
             final int maxLevel = 64; 
             // initial fill
@@ -71,19 +70,19 @@ public class ObjectIdentityBdbManualCacheTest extends TmpDirTestCase {
                         key, 
                         new Supplier<IdentityCacheableWrapper<AtomicInteger>>(
                                 new IdentityCacheableWrapper<AtomicInteger>(
-                                        key, new AtomicInteger(level.get()))));
+                                        key, new AtomicInteger(0))));
             }
             // increment all keys
-            for(; level.get() < maxLevel; level.incrementAndGet()) {
+            for(int level = 0; level < maxLevel; level++) {
                 for(int k = 0; k < keyCount; k++) {
                     IdentityCacheableWrapper<AtomicInteger> wrap = cbdbmap.get(""+k);
                     int foundValue = wrap.get().getAndIncrement();
                     wrap.makeDirty();
-                    assertEquals("stale value preinc key "+k, level.get(), foundValue);
+                    assertEquals("stale value preinc key "+k, level, foundValue);
                 }
-                if(level.get() % 10 == 0) {
-                    System.out.println("level to "+level.get());
-                    if(level.get()>0) {
+                if(level % 10 == 0) {
+                    System.out.println("level to "+level);
+                    if(level>0) {
                         TestUtils.forceScarceMemory();
                     }
                     System.out.println("OIBMCT:"+cbdbmap.composeCacheSummary());