From 5caa83d3277406dc915e6e37f5fd4054cc1e4ee1 Mon Sep 17 00:00:00 2001
From: Andy Jackson <anj@anjackson.net>
Date: Fri, 28 May 2021 12:42:17 +0100
Subject: [PATCH] Only update last checkpoint stats if the checkpoint
 completed, for #392.

---
 .../java/org/archive/crawler/framework/CheckpointService.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/engine/src/main/java/org/archive/crawler/framework/CheckpointService.java b/engine/src/main/java/org/archive/crawler/framework/CheckpointService.java
index 73027b83..76245ba9 100644
--- a/engine/src/main/java/org/archive/crawler/framework/CheckpointService.java
+++ b/engine/src/main/java/org/archive/crawler/framework/CheckpointService.java
@@ -308,12 +308,14 @@ public class CheckpointService implements Lifecycle, ApplicationContextAware, Ha
             
             appCtx.publishEvent(new CheckpointSuccessEvent(this,
                     checkpointInProgress));
+            
+            // Record the stats associated with this successfully-completed checkpoint:
+            lastCheckpointSnapshot = controller.getStatisticsTracker().getSnapshot();
         } catch (Exception e) {
             checkpointFailed(e);
         } finally {
             checkpointInProgress.writeValidity(
                 controller.getStatisticsTracker().getProgressStamp());
-            lastCheckpointSnapshot = controller.getStatisticsTracker().getSnapshot();
             // close (incl. release locks)
             long finishStart = System.currentTimeMillis();
             for (Checkpointable c : toCheckpoint.values()) {