diff --git a/commons/src/main/java/org/archive/state/ModuleTestBase.java b/commons/src/main/java/org/archive/state/ModuleTestBase.java index 7c50df66..90e167c4 100644 --- a/commons/src/main/java/org/archive/state/ModuleTestBase.java +++ b/commons/src/main/java/org/archive/state/ModuleTestBase.java @@ -163,8 +163,11 @@ public abstract class ModuleTestBase extends TestCase { * * @throws Exception if the module cannot be serialized */ - public void testSerialization() throws Exception { + public void testSerializationIfAppropriate() throws Exception { Object first = makeModule(); + if(!(first instanceof Serializable)) { + return; + } byte[] firstBytes = SerializationUtils.serialize((Serializable)first); Object second = SerializationUtils.deserialize(firstBytes); @@ -178,7 +181,6 @@ public abstract class ModuleTestBase extends TestCase { // verifySerialization(first, firstBytes, second, secondBytes); verifySerialization(first, firstBytes, third, thirdBytes); } - /** * Verifies that serialization was successful. diff --git a/engine/src/test/java/org/archive/crawler/frontier/BdbFrontierTest.java b/engine/src/test/java/org/archive/crawler/frontier/BdbFrontierTest.java index 5d8ada4a..8025f590 100644 --- a/engine/src/test/java/org/archive/crawler/frontier/BdbFrontierTest.java +++ b/engine/src/test/java/org/archive/crawler/frontier/BdbFrontierTest.java @@ -28,17 +28,6 @@ import org.archive.crawler.framework.CrawlerProcessorTestBase; */ public class BdbFrontierTest extends CrawlerProcessorTestBase { - @Override - public void testSerialization() { - // FIXME - } - - @Override - protected void verifySerialization(Object first, byte[] firstBytes, - Object second, byte[] secondBytes) throws Exception { - } - - // TODO TESTME } diff --git a/modules/src/main/java/org/archive/modules/Processor.java b/modules/src/main/java/org/archive/modules/Processor.java index 38bd0149..9f4b632f 100644 --- a/modules/src/main/java/org/archive/modules/Processor.java +++ b/modules/src/main/java/org/archive/modules/Processor.java @@ -20,7 +20,6 @@ package org.archive.modules; import java.io.IOException; -import java.io.Serializable; import java.util.Set; import java.util.concurrent.atomic.AtomicLong; @@ -49,8 +48,7 @@ import org.springframework.context.Lifecycle; * @author pjack */ public abstract class Processor -implements Serializable, - HasKeyedProperties, +implements HasKeyedProperties, Lifecycle, BeanNameAware, Checkpointable {