From 303ffb486e7c331ea4b7eb872c791f800160b2c2 Mon Sep 17 00:00:00 2001 From: Noah Levitt Date: Wed, 10 Apr 2019 10:43:22 -0700 Subject: [PATCH] close the rethinkdb connection! --- contrib/src/main/java/org/archive/trough/TroughClient.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/contrib/src/main/java/org/archive/trough/TroughClient.java b/contrib/src/main/java/org/archive/trough/TroughClient.java index 08899d6b..6139492f 100644 --- a/contrib/src/main/java/org/archive/trough/TroughClient.java +++ b/contrib/src/main/java/org/archive/trough/TroughClient.java @@ -182,6 +182,7 @@ public class TroughClient { Exception lastE = null; for (int i = 0; i <= retries; i++) { int whichServer = rand.nextInt(rethinkServers.length); + Connection conn = null; try { String[] hostPort = rethinkServers[whichServer].split(":", 2); String host = hostPort[0]; @@ -189,12 +190,16 @@ public class TroughClient { if (hostPort.length == 2) { port = Integer.valueOf(hostPort[1]); } - Connection conn = r.connection().hostname(host).port(port).db(rethinkDb).connect(); + conn = r.connection().hostname(host).port(port).db(rethinkDb).connect(); Object result = reql.run(conn); return result; } catch (Exception e) { logger.warning("rethinkdb query failed (server=" + rethinkServers[whichServer] + "; " + i + " retries left)"); lastE = e; + } finally { + if (conn != null) { + conn.close(); + } } }