From 48b0ddfb037fa19a8d8899790955496e3ef09a39 Mon Sep 17 00:00:00 2001 From: nlevitt Date: Mon, 12 Sep 2011 22:00:54 +0000 Subject: [PATCH] Fix for HER-1942 CheckpointService: inconsistent synchronization around use of isRunning. Doubtful if isRunning thing is a real problem, but it looks like a good idea to synchronize this method anyway, in case there are concurrent calls to it. * CheckpointService.java setRecoveryCheckpointByName() - mark synchronized --- .../java/org/archive/crawler/framework/CheckpointService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/src/main/java/org/archive/crawler/framework/CheckpointService.java b/engine/src/main/java/org/archive/crawler/framework/CheckpointService.java index c22d45f3..ef62f364 100644 --- a/engine/src/main/java/org/archive/crawler/framework/CheckpointService.java +++ b/engine/src/main/java/org/archive/crawler/framework/CheckpointService.java @@ -325,7 +325,7 @@ public class CheckpointService implements Lifecycle, ApplicationContextAware, Ha * * @param selectedCheckpoint */ - public void setRecoveryCheckpointByName(String selectedCheckpoint) { + public synchronized void setRecoveryCheckpointByName(String selectedCheckpoint) { if(isRunning) { throw new RuntimeException("may not set recovery Checkpoint after launch"); }