From 4cd9eb2e419ba22690f2bbe2fae8db78e80cccc1 Mon Sep 17 00:00:00 2001 From: gojomo Date: Tue, 28 Jul 2009 00:48:36 +0000 Subject: [PATCH] Work for [HER-1654] suspicious Cookie bottlenecks: synchronization, growth * Cookie.java simple non-contending String compare (fixed similarly upstream in HttpClient; see https://cwiki.apache.org/jira/browse/HTTPCLIENT-645 ) --- .../src/main/java/org/apache/commons/httpclient/Cookie.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/commons/src/main/java/org/apache/commons/httpclient/Cookie.java b/commons/src/main/java/org/apache/commons/httpclient/Cookie.java index 49984fae..2dcf987a 100644 --- a/commons/src/main/java/org/apache/commons/httpclient/Cookie.java +++ b/commons/src/main/java/org/apache/commons/httpclient/Cookie.java @@ -482,7 +482,11 @@ public class Cookie extends NameValuePair implements Serializable, Comparator { return 1; } } else { - return STRING_COLLATOR.compare(c1.getPath(), c2.getPath()); +// BEGIN IA/HERITRIX CHANGE +// based on: https://cwiki.apache.org/jira/browse/HTTPCLIENT-645 + return c1.getPath().compareTo(c2.getPath()); +// return STRING_COLLATOR.compare(c1.getPath(), c2.getPath()); +// END IA/HERITRIX CHANGE } }