From 643f16d20cc9a9bb19f8f2e5ed89278d49d30cdc Mon Sep 17 00:00:00 2001
From: Alex Osborne <aosborne@nla.gov.au>
Date: Tue, 22 Jun 2021 13:40:09 +0900
Subject: [PATCH] Remove arbitrary 1.5 second sleep() when launching jobs

I think the sleep is supposed to make launch() not return until the job
has actually been launched but it doesn't work as launch()
and getCrawlController() are both synchronized therefore the
launcher thread can't actually call startContext() until launch()
returns after sleeping.

So let's replace the sleep call with join and unsynchronize launch()
so it doesn't deadlock. All the relevant methods it calls seem to be
synchronized so I think it's no worse to not synchronize it itself.
---
 .../main/java/org/archive/crawler/framework/CrawlJob.java    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/engine/src/main/java/org/archive/crawler/framework/CrawlJob.java b/engine/src/main/java/org/archive/crawler/framework/CrawlJob.java
index 02bdbe2e..c96aa000 100644
--- a/engine/src/main/java/org/archive/crawler/framework/CrawlJob.java
+++ b/engine/src/main/java/org/archive/crawler/framework/CrawlJob.java
@@ -408,7 +408,7 @@ public class CrawlJob implements Comparable<CrawlJob>, ApplicationListener<Appli
      * (Note the crawl may have been configured to start in a 'paused'
      * state.) 
      */
-    public synchronized void launch() {
+    public void launch() {
         if (isProfile()) {
             throw new IllegalArgumentException("Can't launch profile" + this);
         }
@@ -449,9 +449,8 @@ public class CrawlJob implements Comparable<CrawlJob>, ApplicationListener<Appli
         getJobLogger().log(Level.INFO,"Job launched");
         scanJobLog();
         launcher.start();
-        // look busy (and give startContext/crawlStart a chance)
         try {
-            Thread.sleep(1500);
+            launcher.join();
         } catch (InterruptedException e) {
             // do nothing
         }