From 7ca3574b1bec8e2d2094d2b1c4b97149e13f4530 Mon Sep 17 00:00:00 2001 From: Alex Osborne Date: Wed, 11 Nov 2026 22:39:17 +0900 Subject: [PATCH] WebDriverBiDi: move isAlive() onto the interface --- .../java/org/archive/net/webdriver/LocalWebDriverBiDi.java | 4 +--- .../main/java/org/archive/net/webdriver/WebDriverBiDi.java | 5 +++++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/commons/src/main/java/org/archive/net/webdriver/LocalWebDriverBiDi.java b/commons/src/main/java/org/archive/net/webdriver/LocalWebDriverBiDi.java index cec07e09..df988df2 100644 --- a/commons/src/main/java/org/archive/net/webdriver/LocalWebDriverBiDi.java +++ b/commons/src/main/java/org/archive/net/webdriver/LocalWebDriverBiDi.java @@ -175,9 +175,7 @@ public class LocalWebDriverBiDi implements WebDriverBiDi, Closeable { return future; } - /** - * Returns true if the browser process is running and the WebDriver connection is still open. - */ + @Override public boolean isAlive() { return process.isAlive() && !webSocket.isInputClosed() && !webSocket.isOutputClosed(); } diff --git a/commons/src/main/java/org/archive/net/webdriver/WebDriverBiDi.java b/commons/src/main/java/org/archive/net/webdriver/WebDriverBiDi.java index 7dee12b8..272620bb 100644 --- a/commons/src/main/java/org/archive/net/webdriver/WebDriverBiDi.java +++ b/commons/src/main/java/org/archive/net/webdriver/WebDriverBiDi.java @@ -22,6 +22,11 @@ package org.archive.net.webdriver; public interface WebDriverBiDi { T module(Class moduleClass); + /** + * Returns true if the browser is running and the WebDriver connection is still open. + */ + boolean isAlive(); + default Browser browser() { return module(Browser.class); }