From 37a8504fda0e02c52738bcb8418e520eccaa1f38 Mon Sep 17 00:00:00 2001 From: Noah Levitt Date: Mon, 16 Jul 2012 20:02:56 -0700 Subject: [PATCH] HER-2015 credentials cached to server never used * FetchHTTP.java populateCredentials() - return true when credentials populated from server cache --- .../main/java/org/archive/modules/fetcher/FetchHTTP.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/modules/src/main/java/org/archive/modules/fetcher/FetchHTTP.java b/modules/src/main/java/org/archive/modules/fetcher/FetchHTTP.java index f0580160..1a1e7576 100644 --- a/modules/src/main/java/org/archive/modules/fetcher/FetchHTTP.java +++ b/modules/src/main/java/org/archive/modules/fetcher/FetchHTTP.java @@ -1143,17 +1143,20 @@ public class FetchHTTP extends Processor implements Lifecycle { } catch (URIException e) { return false; } + + boolean result = false; + CrawlServer server = serverCache.getServerFor(serverKey); if (server.hasCredentials()) { for (Credential cred : server.getCredentials()) { if (cred.isEveryTime()) { - cred.populate(curi, this.http, method); + if (cred.populate(curi, this.http, method)) { + result = true; + } } } } - boolean result = false; - // Now look in the curi. The Curi will have credentials loaded either // by the handle401 method if its a rfc2617 or it'll have been set into // the curi by the preconditionenforcer as this login uri came through.