From a45252de2274aa7277d04dbf52b64f07f962ef6d Mon Sep 17 00:00:00 2001 From: Alex Osborne Date: Thu, 12 Nov 2026 13:33:30 +0900 Subject: [PATCH] LocalWebDriverBiDi: allow the launch timeout for creating the session --- .../java/org/archive/net/webdriver/LocalWebDriverBiDi.java | 2 +- commons/src/main/java/org/archive/net/webdriver/Session.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/commons/src/main/java/org/archive/net/webdriver/LocalWebDriverBiDi.java b/commons/src/main/java/org/archive/net/webdriver/LocalWebDriverBiDi.java index 03e6643b..584127b6 100644 --- a/commons/src/main/java/org/archive/net/webdriver/LocalWebDriverBiDi.java +++ b/commons/src/main/java/org/archive/net/webdriver/LocalWebDriverBiDi.java @@ -75,7 +75,7 @@ public class LocalWebDriverBiDi implements WebDriverBiDi, Closeable { webSocket = HttpClient.newHttpClient().newWebSocketBuilder() .buildAsync(URI.create(url + "/session"), new Listener()) .get(LAUNCH_TIMEOUT_SECONDS, TimeUnit.SECONDS); - sessionId = session().new_(capabilities).sessionId(); + sessionId = session().newAsync(capabilities).get(LAUNCH_TIMEOUT_SECONDS, TimeUnit.SECONDS).sessionId(); } catch (TimeoutException e) { destroyProcess(); throw new IOException("Browser did not start within " + LAUNCH_TIMEOUT_SECONDS + " seconds", e); diff --git a/commons/src/main/java/org/archive/net/webdriver/Session.java b/commons/src/main/java/org/archive/net/webdriver/Session.java index 5f7ef55a..748891f9 100644 --- a/commons/src/main/java/org/archive/net/webdriver/Session.java +++ b/commons/src/main/java/org/archive/net/webdriver/Session.java @@ -24,10 +24,11 @@ import org.json.JSONPropertyName; import java.util.List; import java.util.Map; +import java.util.concurrent.CompletableFuture; // https://w3c.github.io/webdriver-bidi/#module-session public interface Session extends BiDiModule { - NewResult new_(CapabilitiesRequest capabilities); + CompletableFuture newAsync(CapabilitiesRequest capabilities); void subscribe(List events, List contexts);