lee/heritrix3
1
0 Fork 0
mirror of https://github.com/internetarchive/heritrix3.git synced 2026-11-15 10:20:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unit tests (carried over from H1)

Browse Source 
* WARCWriterTest.java
    (testSpaceInUrl),(testTabInURL): don't expect exception; expect nothing-written
This commit is contained in:
szznax committed 2009-10-05 18:35:06 +00:00
1 parent 86974e2e1d
commit ba5bc1a20c
1 file changed
+10 -19
Download Patch File Download Diff File Expand all files Collapse all files
commons/src/main/java/org/archive/io/warc/WARCWriterTest.java
+10 -19
View File
@@ -368,37 +368,28 @@ extends TmpDirTestCase implements WARCConstants {
return writer;
}
public void testSpaceInURL() {
String eMessage = null;
try {
holeyUrl("testSpaceInURL-" + PREFIX, false, " ");
} catch (IOException e) {
eMessage = e.getMessage();
}
assertTrue("Didn't get expected exception: " + eMessage,
eMessage.startsWith("Contains disallowed"));
public void testSpaceInURL() throws IOException {
long bytesWritten = holeyUrl("testSpaceInURL-" + PREFIX, false, " ");
assertEquals("Unexpected successful writing occurred",0,bytesWritten);
}
public void testTabInURL() {
String eMessage = null;
try {
holeyUrl("testTabInURL-" + PREFIX, false, "\t");
} catch (IOException e) {
eMessage = e.getMessage();
}
assertTrue("Didn't get expected exception: " + eMessage,
eMessage.startsWith("Contains illegal"));
public void testTabInURL() throws IOException {
long bytesWritten = holeyUrl("testTabInURL-" + PREFIX, false, "\t");
assertEquals("Unexpected successful writing occurred",0,bytesWritten);
}
protected void holeyUrl(String name, boolean compress, String urlInsert)
protected long holeyUrl(String name, boolean compress, String urlInsert)
throws IOException {
WARCWriter writer = createWithOneRecord(name, compress);
// Add some bytes on the end to mess up the record.
long startPos = writer.getPosition();
String content = getContent();
ByteArrayOutputStream baos = getBaos(content);
writeRecord(writer, SOME_URL + urlInsert + "/index.html", "text/html",
content.length(), baos);
long endPos = writer.getPosition();
writer.close();
return endPos-startPos;
}
/**